ci(vcpkg): keep baseline updates synchronized and auto-mergeable
Improve the vcpkg baseline updater so automated dependency PRs stay synchronized with main and can be queued for native GitHub auto-merge.
Main changes:
- Fetch full repository history before updating the baseline branch.
- Synchronize the updater branch with the latest origin/main before applying baseline changes.
- Rebase existing updater branches onto main.
- Create missing updater branches directly from origin/main.
- Use force-with-lease when refreshing bot-managed branches.
- Restrict existing PR lookup to open baseline PRs targeting main.
- Queue both existing and newly created baseline PRs for native GitHub squash auto-merge.
- Set a consistent squash commit subject and body for automated baseline merges.
- Validate PR numbers before attempting to enable auto-merge.
- Warn and leave the PR open when auto-merge cannot be queued.
- Continue triggering CI when the requested baseline is already present.
- Update CI path filters so changes to update_vcpkg_baseline.yml trigger Windows, macOS, Android, Docker, and browser validation.
Safety:
- The updater does not approve reviews.
- The updater does not bypass branch protection.
- Auto-merge remains subject to required reviews and status checks.
- Branch rewrites use force-with-lease instead of an unconditional force push.
Validation:
- actionlint passed.
- YAML parsing passed.
- Extracted updater shell script passed bash -n.
- git diff --check passed.
This makes automated vcpkg baseline maintenance more reliable by preventing stale update branches and allowing GitHub to complete the merge once all repository requirements are satisfied.
fix(cache): canonicalize vcpkg manifest line endings
Normalize manifest line endings when generating shared build-cache fingerprints so equivalent vcpkg configurations use the same dependency pool regardless of Git checkout settings.
Root cause:
- Equivalent Git content can be checked out using CRLF or LF depending on core.autocrlf and local Git configuration.
- The previous shared-cache resolver hashed raw manifest bytes.
- Two otherwise equivalent worktrees could therefore resolve to different dependency fingerprints and separate vcpkg pools.
Main changes:
- Normalize CRLF and LF when fingerprinting vcpkg.json.
- Normalize CRLF and LF when fingerprinting vcpkg-configuration.json.
- Keep registry, overlay, port, patch, and arbitrary payload trees byte-signatured because their contents may be line-ending-sensitive.
- Advance the shared-cache contract from schema v3 to schema v4.
- Retain recognition of schemas v1 through v3 for auditing and transient cleanup.
- Require an exact full-fingerprint metadata match before cleaning fingerprint-specific transient data.
- Keep shortened cache directory names backed by full SHA-256 identity metadata.
- Update shared-cache setup and cleanup tooling for the v4 layout.
- Update documentation with v4 fingerprinting behavior, migration rules, cleanup procedures, and cache paths.
Windows build updates:
- Move Windows CI to the Visual Studio 2026 hosted runner.
- Verify that Visual Studio 2026 provides the native C++ v145 toolset.
- Configure MSBuild discovery specifically for the Visual Studio 18.x prerelease range.
- Remove the previous Chocolatey-based Visual Studio toolset installation path.
Validation:
- Reproduced the Release x64 dependency contract in two worktrees with different manifest line endings.
- Verified both worktrees now resolve to the same schema v4 dependency fingerprint.
- Ran SharedBuildCache.cmake in CMake script mode.
- Verified the windows-release preset listing.
- Ran PowerShell parser checks.
- Ran JSON parsing checks.
- Ran documentation portability checks.
- Ran git diff --check.
This keeps shared vcpkg cache identity stable across CRLF and LF checkouts while preserving byte-sensitive hashing for dependency content where physical file representation can affect behavior.
Add shared vcpkg dependency cache for CMake and Visual Studio builds
This commit adds a content addressed vcpkg dependency cache that can be reused across compatible Git worktrees independent forks CMake presets and Visual Studio Solution builds.
The goal is to reduce repeated dependency installation and rebuild time while keeping build outputs isolated per worktree. The cache only shares dependency artifacts that are proven compatible through a complete dependency contract. Project build outputs such as object files PCH files PDB files generated sources intermediate files and executables remain local to each checkout.
The shared cache is opt in. When the cache is not configured or when the resolver cannot prove that reuse is safe both CMake and Visual Studio fall back to local worktree specific vcpkg roots.
Main behavior added
• Shares vcpkg downloads globally
• Shares vcpkg binary packages globally
• Shares expanded vcpkg installed trees only when the dependency fingerprint matches
• Shares vcpkg buildtrees and packages only when the dependency fingerprint matches
• Keeps CMake build trees local to each worktree
• Keeps Visual Studio output directories local to each worktree
• Keeps generated files intermediate files executables PCH files PDB files and object files local
• Allows compatible Git worktrees to reuse dependency artifacts
• Allows compatible forks to reuse dependency artifacts
• Allows compatible CMake presets and Visual Studio configurations to converge on the same dependency cache
• Falls back to local vcpkg storage when shared cache safety cannot be verified
CMake integration
The new CMake shared cache module runs before project initialization and resolves the vcpkg dependency contract before the normal configure flow continues.
The resolver validates the manifest registries overlays triplets features vcpkg revision compiler toolset SDK and cache implementation before selecting fingerprinted dependency roots. This prevents incompatible configurations from sharing the same expanded dependency tree.
If the CMake version is too old for the shared cache module and shared cache variables are present the build warns and continues with build local vcpkg storage instead.
CMake preset changes
• Removes hardcoded VCPKG_INSTALLED_DIR values from presets
• Lets the shared cache resolver select the installed root when safe
• Keeps local fallback behavior available
• Replaces the previous preset binary source override with clean packages and clean buildtrees options
• Prevents Visual Studio CMake presets from inheriting Ninja compiler overrides where they should not
• Keeps CMake build outputs under their configured build preset directories
Visual Studio integration
The Visual Studio bridge uses the same dependency resolver as CMake. It evaluates each Solution configuration through MSBuild, generates a machine local ignored SharedVcpkgCache props file and revalidates the complete contract before vcpkg manifest installation.
Different Visual Studio configurations receive separate consumer fingerprints. They can still share an expanded dependency tree when their dependency inputs are identical, but their consumer contracts remain separate so MSBuild specific details cannot corrupt CMake or another Solution configuration.
The Visual Studio project now imports vcpkg props more reliably, supports the generated shared cache props, and validates the generated contract through SharedVcpkgCache targets before dependency installation and build preparation.
Visual Studio changes included
• Adds SharedVcpkgCache targets
• Adds generated SharedVcpkgCache props support
• Adds vcpkg bootstrap property resolution from VCPKG ROOT
• Keeps local fallback when the shared Solution cache is inactive
• Validates manifest root target triplet host triplet configuration toolset SDK and install options before using the shared cache
• Pins the Visual Studio instance used by vcpkg for the shared Solution contract
• Requires the dependency CMake tool used by the generated contract
• Revalidates the generated contract before vcpkg manifest install
• Uses fingerprinted installed buildtrees and packages roots for compatible Solution builds
• Keeps Solution outputs local
Shared cache safety boundaries
The shared cache is intentionally conservative. It only activates when the environment and contract can be fully validated.
Safety rules enforced
• The shared pool must be on a verified local fixed filesystem
• The shared pool must live outside every registered checkout
• UNC paths are rejected for the shared cache root
• Reparse points and symlink escapes are rejected in sensitive paths
• Mutable dependency roots are isolated by full contract fingerprint
• vcpkg and shared cache operation locks protect mutable cache operations
• Existing authenticated VCPKG BINARY SOURCES values are preserved
• Existing authenticated binary source values are never printed
• Existing authenticated binary source values are never persisted by the helper
• Cleanup fails closed when validation is incomplete
• Cleanup refuses to run while build related processes are active
• Cleanup validates repositories configure trees generated contracts paths identities and locks before removing transient data
• CI containers runtime data deployment paths and release behavior remain unchanged unless shared cache is explicitly enabled
PowerShell tooling
This commit adds setup audit cleanup repository registration and Solution contract generation tools.
The main shared cache setup script configures the cache root registers the current Git repository family manages relevant user environment variables configures vcpkg downloads and binary cache locations updates managed sccache base directories and can invoke the Solution bridge when applicable.
The Solution cache script evaluates MSBuild properties resolves the shared dependency contract through the CMake resolver writes the generated props file and supports audit only and validate only modes.
Both PowerShell tools require PowerShell 7 2 and run under strict mode.
Tooling added
• tools configure shared build cache ps1
• tools configure shared solution cache ps1
• setup mode for shared cache configuration
• audit only mode for validating existing shared cache state
• guarded transient vcpkg cleanup
• guarded fingerprint specific transient cleanup
• repository registration and unregister support
• generated Solution props creation
• generated Solution props validation
• generated Solution props audit
• MSBuild property based contract evaluation
• local fixed filesystem validation
• active build process protection before cleanup
Protobuf and Solution build fixes
This branch also includes follow up fixes around protobuf generation and Solution build behavior.
Protobuf and Solution changes
• Fixes Solution protobuf generation by using one normalized absolute proto root
• Uses the host triplet protoc path for protobuf generation
• Adds incremental inputs and outputs to the ProtoCompile target
• Excludes generated protobuf compile items when protobuf support is disabled
• Keeps protobuf generated source handling tied to RunProtoCompile
• Lets both CMake and Solution builds honor configured global vcpkg binary sources
• Avoids leaking Ninja compiler overrides into Visual Studio CMake presets
Documentation and repository updates
• Adds shared build cache documentation
• Documents setup and migration flow
• Documents CMake and Visual Studio integration
• Documents cache contract rules
• Documents concurrency and locking behavior
• Documents fallback behavior
• Documents recovery and cleanup procedures
• Documents cross fork compatibility rules
• Updates README with shared cache guidance
• Updates gitignore for generated local shared cache files
• Updates CI path filters so vcpkg configuration overlay and cache related changes trigger the correct workflows
Validation performed
• PowerShell parser validation for both cache tools
• PowerShell 5 1 prerequisite failure verified
• CMake preset validation
• JSON validation
• Visual Studio project XML validation
• Evaluated MSBuild property and item checks
• Checked protobuf enabled mode
• Checked protobuf disabled mode
• Local shared cache Solution build validation
• GitHub Actions Windows CMake matrix
• GitHub Actions Windows Solution matrix
Overall this commit adds a safe content addressed shared dependency cache for OTClient builds. It lets compatible CMake and Visual Studio configurations reuse expensive vcpkg dependency artifacts while keeping all build outputs local and falling back to worktree local storage whenever the shared contract cannot be fully validated.
Chores:
• Tests are disabled by default; enable explicitly to build tests.
• Configuration now fails if tests are enabled but test dependencies/features are not declared.
• Package manager integration isolated installs and caches per platform/config; per-variant install locations are used.
• Test dependency declaration moved into an optional "tests" feature.
• CI configure for macOS explicitly disables client tests by default.
New Features:
• Added dedicated presets and build variants for release, debug and test workflows.
New Features:
- Native macOS app with Cocoa windowing, OpenGL view, improved input, clipboard and cursor handling.
- Platform-aware keyboard and shortcut behavior with clearer primary/meta/control semantics and normalized key combos.
Bug Fixes:
- Expanded detection for "connection refused" network errors.
Chores:
- macOS build/bundle and packaging improvements; new dependency overlay added; CI now runs macOS build when relevant.
Tests:
- AddressSanitizer support added for test builds.
New Features:
- Added scrollable areas to general options, action bar settings, and game panel controls for improved navigation on compact displays.
- Integrated Android APK build automation into the CI pipeline.
Chores:
- Enhanced build system to support flexible Android architecture configuration during automated builds.
- Remove duplicated entry from editorconfig (again, don't know why it got back after
PR that fixed this)
- Added entry for cmake files on editorconfig
- Removed not used GitVersion
- Update ubuntu build workflow (Removed ccache that will not work with UNITY and PCH)
- Disabled UNITY and PCH for debug images and enabled more warning flags (Show build warning on PR changes)
- Update docker workflow to use newer version (Using newer versions of the actions helped cleaning the workflow, now it is smaller and easier to understand)
- Do not upload artifacts when building PR as it failing and we need to re-run the build
Signed-off-by: Renato Foot <renato@foot.br>
To prevent future build breaks due to changes in the vcpkg repository, added a step in the GitHub Actions to install vcpkg based on the builtin-baseline in the vcpkg.json file. This allows us to set vcpkg to be installed from specific commits in both GitHub Actions and in Ubuntu/Windows, centralizing everything in one location. We can only update vcpkg when there is an official release.
Full Github Action Rework (GHA), so that builds are fixed: Windows, Linux, Docker; Review checks: C++, Lua, XML and others checks
Complete Cmake Rework, modernized the code so that you can work with GHA.
Removed:
VCPKG Build
Removed generated Files from file .gitignore (all build files are required for Cmake cache generation)
Lib Lua5.1 was removed and maintained only Luajit (faster and better)
Removed the "consoleapplication" file
Removed the "lbitlib" file, after all, if the idea is the project to use updated Libs, why do we want files that bring compatibility to old Libs? I just updated the files to use the functions of the new LIBs
Modified:
The metadata of the Bitwise functions have been changed, now being in place of "bit32." is
"bit."
Protobuf will now be chased along with the client build, avoiding random errors related to Protobuf's version is different from the compiled file (this way, no matter if the repository file is outdated, as a new one will always be generated in a compilation from rebuild all)
Modified the structure of some folders, such as "protobuf" and "cmake" folder, "protobuf" was sent to the src main folder and "cmake" to the client main folder
Namespace protobuf changed from "tibia" to "otclient"
Merged the files of the Protobuf "shared.proto and appearances.proto" in one (appearances)
Added:
Issue Template
Pull Request Template
Pull Request Labeller
Check to inform that clang is not supported (it is possible to use docker on mac, this way we avoid headaches related to support for an OS that is practically not used)
GHA:
Codacy
CodeQL
Review dog
SonarCloud
Build docker
Build Ubuntu
Build Windows
Cmake:
Cmakepresets
VCPKG Manifest
Otcicon
Client:
Added the functions LuaInterface::registerTable and LuaInterface::registerMethod and Bitwise Functions (if necessary at some point compatibility with the Lua 5.1)
Note: Some checks are failing as they should only work after the merge, they should be ignored, the main ones are ok
Thanks to @costallat for for helping and assisting with addition of GHA and CMake build
commit 1d614e294c
Author: vfjpl <cosiekvfj@o2.pl>
Date: Wed Aug 25 19:24:08 2021 +0200
Fix std::istream::streampos deprecation warning (#1154)
commit e0d5b7d7fd
Author: Marcin Michalski <evulmastah@gmail.com>
Date: Sun Aug 22 01:21:17 2021 +0200
Update vcpkg & switch back to ubuntu 18.04 in workflow (#1161)
commit 10100342b9
Author: Marcin Michalski <evulmastah@gmail.com>
Date: Sun Aug 22 00:51:18 2021 +0200
Fix opening "https://"-prefixed links on Windows (#1160)
commit 302748b2f3
Author: Marcin Michalski <evulmastah@gmail.com>
Date: Sun Aug 22 00:48:34 2021 +0200
Fix opening URLs on macOS (#1159)
commit f173b03dbd
Author: Marcin Michalski <evulmastah@gmail.com>
Date: Sun Aug 22 00:38:58 2021 +0200
Map option to alt and command to meta keys on macOS (#1158)
* Removed Ubuntu Clang workflow
* Removed FindCXX.cmake (in favor of native feature)
* Added support for building Windows binaries with CMake when using MSVC
* Cleaned up a number of Find*.cmake modules
