- Remove duplicated entry from editorconfig (again, don't know why it got back after
PR that fixed this)
- Added entry for cmake files on editorconfig
- Removed not used GitVersion
- Update ubuntu build workflow (Removed ccache that will not work with UNITY and PCH)
- Disabled UNITY and PCH for debug images and enabled more warning flags (Show build warning on PR changes)
- Update docker workflow to use newer version (Using newer versions of the actions helped cleaning the workflow, now it is smaller and easier to understand)
- Do not upload artifacts when building PR as it failing and we need to re-run the build
Signed-off-by: Renato Foot <renato@foot.br>
To prevent future build breaks due to changes in the vcpkg repository, added a step in the GitHub Actions to install vcpkg based on the builtin-baseline in the vcpkg.json file. This allows us to set vcpkg to be installed from specific commits in both GitHub Actions and in Ubuntu/Windows, centralizing everything in one location. We can only update vcpkg when there is an official release.
Full Github Action Rework (GHA), so that builds are fixed: Windows, Linux, Docker; Review checks: C++, Lua, XML and others checks
Complete Cmake Rework, modernized the code so that you can work with GHA.
Removed:
VCPKG Build
Removed generated Files from file .gitignore (all build files are required for Cmake cache generation)
Lib Lua5.1 was removed and maintained only Luajit (faster and better)
Removed the "consoleapplication" file
Removed the "lbitlib" file, after all, if the idea is the project to use updated Libs, why do we want files that bring compatibility to old Libs? I just updated the files to use the functions of the new LIBs
Modified:
The metadata of the Bitwise functions have been changed, now being in place of "bit32." is
"bit."
Protobuf will now be chased along with the client build, avoiding random errors related to Protobuf's version is different from the compiled file (this way, no matter if the repository file is outdated, as a new one will always be generated in a compilation from rebuild all)
Modified the structure of some folders, such as "protobuf" and "cmake" folder, "protobuf" was sent to the src main folder and "cmake" to the client main folder
Namespace protobuf changed from "tibia" to "otclient"
Merged the files of the Protobuf "shared.proto and appearances.proto" in one (appearances)
Added:
Issue Template
Pull Request Template
Pull Request Labeller
Check to inform that clang is not supported (it is possible to use docker on mac, this way we avoid headaches related to support for an OS that is practically not used)
GHA:
Codacy
CodeQL
Review dog
SonarCloud
Build docker
Build Ubuntu
Build Windows
Cmake:
Cmakepresets
VCPKG Manifest
Otcicon
Client:
Added the functions LuaInterface::registerTable and LuaInterface::registerMethod and Bitwise Functions (if necessary at some point compatibility with the Lua 5.1)
Note: Some checks are failing as they should only work after the merge, they should be ignored, the main ones are ok
Thanks to @costallat for for helping and assisting with addition of GHA and CMake build
commit 1d614e294c
Author: vfjpl <cosiekvfj@o2.pl>
Date: Wed Aug 25 19:24:08 2021 +0200
Fix std::istream::streampos deprecation warning (#1154)
commit e0d5b7d7fd
Author: Marcin Michalski <evulmastah@gmail.com>
Date: Sun Aug 22 01:21:17 2021 +0200
Update vcpkg & switch back to ubuntu 18.04 in workflow (#1161)
commit 10100342b9
Author: Marcin Michalski <evulmastah@gmail.com>
Date: Sun Aug 22 00:51:18 2021 +0200
Fix opening "https://"-prefixed links on Windows (#1160)
commit 302748b2f3
Author: Marcin Michalski <evulmastah@gmail.com>
Date: Sun Aug 22 00:48:34 2021 +0200
Fix opening URLs on macOS (#1159)
commit f173b03dbd
Author: Marcin Michalski <evulmastah@gmail.com>
Date: Sun Aug 22 00:38:58 2021 +0200
Map option to alt and command to meta keys on macOS (#1158)
* Removed Ubuntu Clang workflow
* Removed FindCXX.cmake (in favor of native feature)
* Added support for building Windows binaries with CMake when using MSVC
* Cleaned up a number of Find*.cmake modules