Commit graph

124 commits

Author SHA1 Message Date
Martin
0c88de0d8a
Fix SonarQube's "String.IsNullOrEmpty" should be used / Code Smell. (#4935) 2021-05-12 18:27:41 +01:00
LG Archer
7ea8145095
Assets (#4914)
* Move game asset factories in to Assets directory.

* * Core
 + Improved file sharing capability.
  ~ A running client and shard can now share an install location)

* Assets
 + Thread safety for image loading.
 + Improved detection for UOP or MUL support. (prioritize UOP)
 + Always load and convert raw image data from 16bpp to 32bpp.
  ~ This change is aimed at improving cross-platform support.
2021-01-06 16:27:18 +00:00
LG Archer
eeb9b15393
Assets (#4907) 2020-11-30 12:25:20 +00:00
TrueUO
277cee4ee4
Deco Folder (#4888)
- Cleaned up the decoration folder and removed / combined older decoration spawn files.
- The beginning of the XMLSpawner cleanup.
  - The end goal is to eventually remove it/ rename what it is left of it so that people can once again easily add their own versions of XMLSpawner, if they wish to use all of it's abilities.
- Fixed various bugs with the Bane Dragon
- Removed ununused/outdated Config options from VetRewards.cfg
2020-10-21 13:44:49 -07:00
TrueUO
550ff0e207
Restructure (#4875)
- Removed the Expansion folder in Services.
- Put everything that was in that folder in its appropriate location.

NO FILES WERE ACTUALLY CHANGED IN THIS PR - SIMPLY MOVED.
2020-10-04 09:12:11 -07:00
TrueUO
6ff5ae05df
Bug Fixes (#4873)
* Bug Fixes

Fixed crash while enabling Kotl System
Added support for invoking commands without a mobile
Bolt of CLoth is no longer flipable with housing
Fixed issue with castle ladders
Chest guardians will now get Soul Bound tag during active Event
Fixed issue where physcial resist wasnt returning to normal value when disabling magic reflect spell

* Bug Fix

- https://www.servuo.com/threads/black-rock-stew-recipe-ingredients-are-not-consumed.13056/
2020-10-03 07:09:47 -07:00
TrueUO
851a7ef809 Update
- Removes the projects dependency on the Ultima.dll

Thanks to @argalep
2020-09-27 16:33:21 -04:00
TrueUO
fb1802305f Bug Fixes
- Removed unneeded usings
- World chat log now has a Config option. Turned off by default now.
- Added two new timer priorities.
- Fixed a crash with box of ropes.
- Consolidation of the Pathing movements and algorithms.
- Correctly makes sure you are inside the house you are trying to place addons in.
2020-09-21 09:53:44 -04:00
TrueUO
98d111ae35 Cleanup
- Last of the yearly "cleanup" pushes.
2020-09-18 10:59:33 -04:00
TrueUO
b73897e554
Cleanup (#4848)
- Cleanup of various double calls and simplified code where possible.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-16 07:43:44 -07:00
TrueUO
262c273723
Cleanup (#4846)
- No code changes in this branch. This is simply clean up.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 08:15:23 -07:00
TrueUO
8e0544a0aa
Cleanup (#4841)
- Removed unneeded usings
- Added recompile support for [restart <true> and console commands (save recompile, nosave recompile)

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-07 21:33:30 -07:00
TrueUO
43ef3b7cf2
Changes (#4820)
- Shop item prices now reset at startup, per EA
- Nether Cyclone spell damage fixed
- magic reflect spell now EA like
- Vis list now persists through restarts.
- Fixed an exploit with ChickenStatue and CowStatue.cs
- Fishing poles now get luck accounted
- Restless soul is now grey
- Added proper CUB point value to tmaps
- Doom spawns are now seperated and EA accurate.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-26 18:18:34 -07:00
TrueUO
ffa594cbbb Changes
Removed CanBeWornByGargoyle, RequiredRace properties from all equipment. It is now handled in RaceDefinitions.cs and each race is responsible for validating their own equipment. It is, for the most part, done by ItemID
Consolidated various timers into one static timer: PlayerVendor, RentedVendor, FountainOfLife, Hireables
Fixed a few timer memory leaks
Clockwork leggings can now be imbued
Fixed Phylactery hue
Destard Dungeon Spawn = EA
2020-07-22 16:06:13 -04:00
TrueUO
05f0d7cbfe
Bug Fixes (#4796)
- Bone Crusher should now work properly.
- Scrappers should now have a chance to add 3 properties at 120 magery
- Players can now heal Vollem's from the crystal (CuB bought) with bandages
- Fixed snow tree/trunk id's and z offset
- Dagger from Fabrizio quest should now deleted when quest is Complete
- Fixed exploit with auto-stabling pets. Basically, added a stable count check for auto stable
- Luck can now be inc/dec by 1 for imbuing (10 for loot)
- Cleanup of various unneeded variables or preaos checks.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-06-22 08:57:10 -07:00
TrueUO
470f62cdba Bug Fixes
- Fixed an issue where certain special loot items were getting magical properties when they shouldn't.
- Fixed an issue with the Khaldun pit teleporter working correctly in Trammel.
- Fixed a crash related to Osiredon.
- Formula adjustments to the Death Strike and White Tiger Form spells.
- Turned back on GC.
2020-06-06 07:42:41 -04:00
TrueUO
a010421b05 Bug Fixes
added square goza mats
Corgul now drops scrolls of transcendence
Corgul spawn now has a chance to drop SOT's
Dark Guardians now drop level 1or2 treasure maps
fixed issue with Ultima Store search
cloth bought from weavers now give the proper itemid
stacked items now limited to 17, per EA (was 20)
Treasures of Khaldun and Treasures of Doom should now function correctly.
2020-05-23 12:59:22 -04:00
TrueUO
a99dec6807
Changes (#4781)
All loot pack items are now generated when the mobile is killed.

Reworked monster stealing and begging.

Various re-structuring and bug fixes.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-13 07:58:04 -07:00
TrueUO
af14d351da
Changes/Fixes (#4773)
Replaced standard create world teleporter items with regions.
Fixed an exploit with the Huntmaster.
MessageInABottle uses the new ItemID.
Various boat clean up and command fixes.
Fixed a crash that could result when t-hunting and a guardian is blocked from spawning.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-04 07:51:02 -07:00
TrueUO
4ed27e117f
Fixes an issue where bards could not use their abilities when calmed. (#4766)
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-04-22 11:40:20 -07:00
TrueUO
f608d123a4
Bug Fixes (#4762)
-Fixed issue where client helpers could bypass the container gump and add items directly to the seed box
-SearedFireAntGoo is no longer stackable
-Blue NPC's (mainly vendors, not initial innocent) can no longer be attacked on trammel maps
-Aggressors/Aggressed from pet masters now works properly. This was suspected to crated large numbers to redundant aggressor/aggressed added to a mobiles aggressor/aggressed lists
-Aggressive action for healing a mobile while fighting another mobile has been re-enabled
-AuraDamage is now a harmful act, ie those affected will aggro on your pet!
-MLDryads should no longer attack other wild creatures during Blackthorn Invasion Instance
-More code cleanup
2020-04-21 17:25:24 -07:00
TrueUO
65ea32264b
Imbue fix. (#4761)
Various Cleanup
2020-04-20 10:09:58 -07:00
TrueUO
8427e1fc91 No more this.stuff 2020-04-16 18:41:32 -07:00
TrueUO
01f18a3eff A total convert of get return to => 2020-04-16 20:37:29 -04:00
TrueUO
5ba7d4dc76 Scripts folder cleanup. 2020-04-16 18:42:38 -04:00
TrueUO
ac78f2e568 VS cleanup of no longer needed / used INTs 2020-04-15 13:18:43 -04:00
TrueUO
528c0e0459 Made private fields readonly, where possible.
If a class has a field that's not marked readonly but is only set in the constructor, it could cause confusion about the field's intended use. To avoid confusion, such fields should be marked readonly to make their intended use explicit, and to prevent future maintainers from inadvertently changing their use.
2020-04-15 10:13:04 -04:00
TrueUO
7db8084550
Core cleanup (#4720)
* using cleanup on Commands and ContextMenu folders.

* Cleanup of spaces (( and using in the core.
2020-04-13 20:43:52 -07:00
Dexter
9017c78222
More cleanup (#4692)
* Removed faction args from AcquireFocusMob in BaseAI

* Cleanup: *RE\equires core recompile*
Removed PetTraining Era Checks
Removed GuildType and New Guyild System checks
Fixed Guld titles being removed

* Fixed issue where galleon cannons were not set in the correct location.

* Fixed message gump so it shows the title

* Re-Added [whatisit command
2020-04-10 06:40:36 -04:00
Argalep
32c9080e72
* old client packets remove (#4691) 2020-04-09 18:54:52 -07:00
TrueUO
f62f257ac8
Removed AOSSpeeds. (#4674)
Renamed MlSpeed to Speed.
2020-04-05 17:22:09 -07:00
Dexter
af1e785b78
Revert "Revert "- remove all old OnSingleClick functions (#4660)" (#4661)" (#4662)
This reverts commit 43ebeabc20.
2020-04-02 13:59:24 -04:00
Dexter
43ebeabc20
Revert "- remove all old OnSingleClick functions (#4660)" (#4661)
This reverts commit 69442afc1b.
2020-04-02 13:13:23 -04:00
Argalep
69442afc1b
- remove all old OnSingleClick functions (#4660) 2020-04-02 10:22:26 -04:00
Argalep
11fd71af34
remove CustomsFramework (#4641) 2020-03-30 15:12:08 -04:00
Dexter
69cbd8db36
Removed Era Checks from multiple files (#4635)
* Removed faction args from AcquireFocusMob in BaseAI

* Removed Pre-AOS properties from BaseArmor

* Cleanup BaseClothing and PlayerMobile (removed era checks)

* Removed old Opposition Group, replaced by Tribe. UPdated BaseCreature

* Spell Cleanup

* Cleanued up Loot.cs, Lootpack.cs

* Removed Era Checks from multiple files

* removed old tmap config
2020-03-28 22:48:55 +03:00
Dexter
ac8b30bde9
Remove Factions (#4612) 2020-03-24 19:05:36 -04:00
TrueUO
e5a4078a27
Dan2 (#4609)
* This removes the remaining unused Quests that use locations no longer used on EA.
DarkTides
EminosUndertaking

* Removed the "OldDespise" spawn file. Consolidated the other folders.

* Minor edits

* Cleanup

* Minor updates.

* Update Scripts.csproj

Updated DreamWraith.cs name.

Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-03-24 11:22:28 -04:00
Tasanar
83cef83820 More clilocs updates. If we have clilocs, why not use them! 2019-08-13 21:32:13 -04:00
Tasanar
978cfd9206 Removed StaffRobe.
Fixed an issue where players could open an unlimited number of BankerGump and the Help gump inside of BankerGump.cs
2019-08-09 20:23:01 -04:00
Tasanar
076053a518 2019-08-08 18:43:32 -04:00
VitaNex
d12479961c Type cache; Fix issues with conflicting type names by implementing nested caching for types.
Type sorting; Types implementing IEntity will always take priority when performing lookups.

[Add command; Check for IEntity implementation using Type.GetInterface instead of Type.IsAssignableFrom.

SackFlour; Removed redundant TypeAliasAttribute.
(TypeAliasAttribute should only be used when the aliased type no longer exists)
2019-05-13 03:20:15 +01:00
Dexter
0c1385a05a Additions:
Astronomy https://uo.com/wiki/ultima-online-wiki/gameplay/astronomy/

Don't forget to configure the dates for the AnniversaryGiver21st in AnniversaryGiver21st.cs. The date set needs to be AFTER the current date to ensure each player gets a gift.

Bug Fixes
- Fixed an issue where certain addons were not being created properly in world decorate. Next server start will replace addons that were deleted
- Aegis of Grace (circlet version) is now meddable
- Flesh Ripper now has Mage Slayer, per EA
- Sand is now stackable and supports int32 constructor Arg
- City Trade Deals that increase stats not work properly
- Createing characters in Enhanced Client now gives the proper starting stats and skills
- Removed invalid FacialHairItemID from Garamon
- Fixed NAN error when calculating MinTameChance when skill was set to zero
- Tiger Cub now takes damage from their Master
- Tiger Cub Statuette can now only be used once. Until this is verified on EA, this will eb how it remains
- Tiger Cubs can now be trained up to 3 slots
- Added EOWMU (Spelling?) to pet training table. It will be like all other vanity pets.
- Remove Trap now has a skill variance of 10 (used to be 30) for skill gains, per EA
2019-04-03 12:25:34 -07:00
Dexter
497fd05cfd Treasures of Khaldun Complete. A couple things to note:
I did not put all the decorations in. This is annoying, shard owners can finish it.
2019-02-21 20:01:57 -07:00
Dexter
c1685a055e Removed Convert Players Command
Added enabled check to base trash to check CUB points
2018-12-11 19:14:52 -07:00
Dexter
a09b9dea90 Added prevention of set typo that sets playermobile map to null. this is bad. 2018-12-02 15:57:15 -07:00
Dexter
e6dffb60dd Bug Fixes
- Crash Fix in AutoRestart Command
- Primeval Lich Puzzle now generates when actual champ spawn is generated
2018-11-09 20:45:39 -07:00
Dexter
86b89b7729 Era Checks Initial Commit
- Added Era Specific world start locations
- Added Era UOR - SA for toggle champion title menu
2018-08-17 22:04:40 -07:00
VitaNex
e1670e7044 + Replace Dupe Command with a version that supports duping containers and their contents.
* Dupe Command will now properly check the access level of items with access-limited constructors.
2018-08-03 00:49:41 +01:00
VitaNex
7851c5e88c + Removed most file header regions.
+ Add MONO to Makefile compile definitions.
+ Update Ultima SDK to support MONO compile definition.
+ Rename Properties Gump parent directory to prevent VS issues.
+ Console error messages will now use red instead of dark red font.
+ Add crash state handler function to Core.
+ AI optimizations and housekeeping.
+ Context Menu optimizations and housekeeping.
+ Add ability to drop throttled packets.
+ Add string parsing support to Rectangle3D.
+ Optimize guild messages and chat.
+ IAddon implements IChopable.
+ Add more flexibility for altering Mobile names.
+ Add ability to enable or disable OPL for individual mobiles.
+ Optimize damaging regions and ensure timers are removed properly.
+ Update Welcome Timer with more intuitive message groups.
+ Normalize all virtue related objects to the Server.Services.Virtues namespace.
+ Add ability for ISpawner to append OPL and Context Menus to their spawn.
+ Add EventSink events for obtaining items, equipping items, context menus, and world broadcasts.
+ Add ability to lock a creature's direction and movement regardless of AI manipulation.
+ Add ability to dynamically change a creature's approach range and wait state.
+ Add extended enumeration features for AOS attributes.
+ Add ability to control whether creatures have blood, and its color.
+ Expose corpse flag manipulation methods.
+ Add ability to prevent criminal action when looting a corpse.
+ Corpse will now be permanently tagged as murderer at time of death if owner is a murderer.
+ Add TextDefinition support for Commodity Deed descriptions.
+ House add-on and component optimizations and housekeeping.
+ Item light is no longer backed by the direction property.
+ ITool implements IEntity.
+ Prevent trading of Siege Bless items.
+ Guards are naturally be immune to guards.
+ Siege Shard initialization housekeeping.
+ Character Creation housekeeping.
+ Generic commands housekeeping.
+ Add Mark command for staff.
2018-07-19 22:12:52 +01:00