Commit graph

1738 commits

Author SHA1 Message Date
TrueUO
0ac5795331
Fix (#5074)
Co-authored-by: Daniel Knight <knight.daniel.r@gmail.com>
2023-11-18 09:13:32 +00:00
tr1age
493fde408a
Update DyeTub.cs - Crash Fix (#5060)
This could potentially crash the server from a null error.

---------

Co-authored-by: Voxpire <admin@vita-nex.com>
2023-05-21 00:53:47 +01:00
kaczy93
46c36918a1
Fix spellbook hitpoints deserialization (#5052) 2023-04-30 20:35:02 +01:00
Kamron Batman
bbb91fc153
Fixes wrong variable updated in WallBanner (#5046) 2023-03-13 14:52:16 +00:00
TrueUO
47c368addb
ScrollBinderExploitFix (#5042)
* ScrollBinderExploitFix

- If you add two 1.0 scrolls of transcendence to a scroll binder it will correctly delete the first one but when you target the other one it will create a new 2.0 SOT while leaving the last 1.0 SOT. This can allow users to "dupe" these scrolls. It only happens when you hit 2.0 exactly in a scroll binding deed.
- This small edit resolves the exploit.

* Update ScrollBinderDeed.cs

---------

Co-authored-by: Daniel Knight <knight.daniel.r@gmail.com>
2023-02-14 02:10:08 +00:00
Kimuji
41c0da3e38
Infinite Loop bug (#5021)
Method public static void ApplyAttributesTo(Item item, int attributeCount, int min, int max)
using a FishingPole create an infinite loop because this method was missing :
public static void ApplyAttributesTo(FishingPole pole, int attributeCount, int min, int max)
2022-10-01 23:55:58 +01:00
Kevin Tuttle
af93abbe56
Fix for crafting to set LockableContainer PlayerContruscted (#5003) 2022-04-19 17:01:21 +01:00
Hjornskar
d0505c9e41
Update AmuletOfRighteousness.cs (#4997)
Necklace used from backpack or while equipped.
2022-02-28 16:12:30 +00:00
TrueUO
5c2d322c9b
RepairBenchFix (#4992) 2022-02-13 17:26:37 +00:00
noodleses
0ba024a5d3
Adding new config file and values for carry weight values and calculations (#4979) 2022-01-30 01:52:21 +00:00
berndrausch
5f627b00ff
Rename file to match class name (#4965) 2021-10-05 12:56:30 -07:00
Hjornskar
569fface0a
Update SmithHammer.cs (#4944)
SmithHammer with no parameters was unequippable.
2021-07-04 16:49:37 +01:00
Martin
0c88de0d8a
Fix SonarQube's "String.IsNullOrEmpty" should be used / Code Smell. (#4935) 2021-05-12 18:27:41 +01:00
Dan
7aadd4796c Bug Fixes
- Safely removed depreciated quests.
- Fixed an exploit where AutoLoot own corpse should only auto loot items that were in there when killed. (prevents people from dropping items in a corpse to get them auto looted)
- Animals with instruments will no longer drop them to the world OnDrop OnRelease.
- Fixed a crash with the City Election system when it has multiple people running.
2020-12-06 00:02:27 +03:00
Dan
46998bd414 Bug Fixes
- Adds missing items to Huntmaster Reward gump
- Fixes an access issue with the Jewelry box, when turning pages.
- Travesty Mirror Images will no longer turn players criminal.
- Fixes an exploit where items could be used inside of mail boxes, even without the correct access
2020-11-27 22:52:49 +03:00
Dan
3d4c04e051 Bug Fixes
- Fixes issue FermentationBarrel.cs
- Fixes issues with Fellowship Medallion
- Fixes issue where players could use the Primevil Lich champion spawn to get into the Abyss, without the quest.
2020-11-24 23:24:11 +03:00
Dan
63d251645b Bug Fixes
Fixed an issue where various new potions were incorrectly able to be placed inside potion kegs.
Fixed a display issue with the Fermentation Barrel.
Fixed an issue with Vendor Search and certain vendor maps that were being created incorrectly.
Fixed an issue where a pet owner's luck was not always being calculated when determining basic loot drops.
Fixed an issue where monsters and pets could get "stuck" while casting a spell and would not cast anymore until after a restart.
2020-11-19 05:22:25 -05:00
Dan
af4bc26255 Additions
- Various missing store items
- Certain items can now correctly be used as trash barrels by the home owner.
- Fixes an issue with Ethereal Soulbinders
- No changes were made to XMLFind.
2020-11-12 17:23:37 -05:00
Dan
3c92ccea4a Addition
- Adds the Field Garden Bed
Thanks @argalep
2020-11-03 17:43:11 -05:00
TrueUO
e17be42caa
Fixes (#4895)
- Spelling mistakes on corpses in Treasures of Sorcerers Dungeon event. Event mini bosses no longer flee.
- Matched spelling typed grey vs gray wolf

Additions
- Adds the Wedding package.
This was all @argalep
2020-11-02 08:49:41 -07:00
TrueUO
a717d70a9c
Decorative Farm Set (#4894)
- This PR adds the DecoFarmSet - Thanks @argalep
2020-10-30 10:38:00 -07:00
TrueUO
469e1d94b1
CleanUp (#4889)
- Guild clean up and removal of old unused methods.
- Interior Decorator now correctly works on the older style trophies to raise and lower.
2020-10-23 08:16:09 -07:00
TrueUO
277cee4ee4
Deco Folder (#4888)
- Cleaned up the decoration folder and removed / combined older decoration spawn files.
- The beginning of the XMLSpawner cleanup.
  - The end goal is to eventually remove it/ rename what it is left of it so that people can once again easily add their own versions of XMLSpawner, if they wish to use all of it's abilities.
- Fixed various bugs with the Bane Dragon
- Removed ununused/outdated Config options from VetRewards.cfg
2020-10-21 13:44:49 -07:00
TrueUO
1c7f53a414
OCT17 (#4887)
* OCT17

Minor gump cleanup and XML cleanup.

* Improvements

- Skill Gain is no longer redundantly checked against the same values inside of XMLSpawner.
- AI_Animal (which was not used and just defaulted to AI_Melee) along with AI_Beserk, AI_Predator, and AI_Thief have been safely removed.
- ItemFlags.cs has been moved from XMLSpawner to MISC.
- Removed some misc double calls.

* Needed for recent AI fix.

* Item Fix
2020-10-21 10:15:47 -07:00
TrueUO
e54723ab05
Fixes (#4885)
- Kotl Black Rod now retains its correct color oncraft.
- Removed old/unreachable code in Polymorph.cs (pre aos methods)
- Spawner Cleanup.
- Removal of redundant calls.
2020-10-15 11:26:12 -07:00
TrueUO
8b82bdd254
Additions (#4881)
* Additions

- Adds two missing deco mail boxes.
- Pumpkins you wish to carve must now be in your backpack.

* More changes and bug fixes.
2020-10-13 13:31:23 -07:00
TrueUO
ff3f6d713c
Restructure (#4880)
- No code was changed here, just moved.
2020-10-08 07:23:53 -07:00
TrueUO
21ce1dd042
Changes (#4878)
* Changes

- More timer registry conversions.
- Cleanup of un-needed code.

* Change
2020-10-06 07:44:17 -07:00
TrueUO
550ff0e207
Restructure (#4875)
- Removed the Expansion folder in Services.
- Put everything that was in that folder in its appropriate location.

NO FILES WERE ACTUALLY CHANGED IN THIS PR - SIMPLY MOVED.
2020-10-04 09:12:11 -07:00
TrueUO
6ff5ae05df
Bug Fixes (#4873)
* Bug Fixes

Fixed crash while enabling Kotl System
Added support for invoking commands without a mobile
Bolt of CLoth is no longer flipable with housing
Fixed issue with castle ladders
Chest guardians will now get Soul Bound tag during active Event
Fixed issue where physcial resist wasnt returning to normal value when disabling magic reflect spell

* Bug Fix

- https://www.servuo.com/threads/black-rock-stew-recipe-ingredients-are-not-consumed.13056/
2020-10-03 07:09:47 -07:00
TrueUO
d8670d7150
Changes (#4872)
Added stam/hits/mana regen timers to registry. Players and creatures will have their own timers to reduce any timer drift for players.
Moved TimerRegistry.cs to Server folder
Fixed issue where champ spawns weren't generating after they were deleted
Fixed issue where champ spawn corpses weren't deleting after 1 minute
Added timer object threshold where if met, a new timer will be created. This will prevent timers from processing potentially large lists causing server hangups.
removed huge memory leaks of un-needed timers firing during mobile creation and deserialization
Corpse decay times are now controlled by the mobile
2020-10-02 12:50:37 -07:00
TrueUO
fb4bb8cb13
Bug Fixes (#4871)
- Fixes an issue where monsters and pets could walk through doors.
- Can dye certain Kings Collection items.
- Added in Animdata.
2020-10-01 09:36:55 -07:00
Dan
c4b8643886 Removed:
- Removed the mostly outdated and little, if ever, used reports.
- Fixes a crash from the new magincia bazaar.
- Added missing Halloween begging items and consolidated them all into one folder.
2020-09-29 03:50:48 -04:00
Dan
7b160c0784 Changes
- Not all Unsummons were correctly disposing of their timers.
- This has been fixed and all Summons are now on one static timer.
- Circuit Trap Trainging kit bug fix.
- Small cleanup.
2020-09-27 19:20:09 -04:00
TrueUO
0bc5fffb3d Fixes
- Added in 15 missing halloween pumpkin designs to the carving kit.
- Fixed loot and properties on Pumpkin Head and The Butcher to match EA.
- Some champ cleanup.
2020-09-26 08:43:04 -04:00
TrueUO
62e5bf519d
Bug Fixes (#4856)
- Fixes an issue where certain items could be incorrectly chopped (deleted) with an ax.
-

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-23 07:58:02 -07:00
TrueUO
4987b5ecb1
- Revert recent changes to Assistants. (#4855)
* - Revert recent changes to Assistants.
- Ship painting was giving the wrong charge.
- Renamed TreasureChestMod to DungeonChest.cs

* Assistant edit

* Update BaseDungeonChest.cs

* Update BaseDungeonChest.cs

Reverted back.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-22 12:53:20 -07:00
TrueUO
fb1802305f Bug Fixes
- Removed unneeded usings
- World chat log now has a Config option. Turned off by default now.
- Added two new timer priorities.
- Fixed a crash with box of ropes.
- Consolidation of the Pathing movements and algorithms.
- Correctly makes sure you are inside the house you are trying to place addons in.
2020-09-21 09:53:44 -04:00
TrueUO
98d111ae35 Cleanup
- Last of the yearly "cleanup" pushes.
2020-09-18 10:59:33 -04:00
TrueUO
b73897e554
Cleanup (#4848)
- Cleanup of various double calls and simplified code where possible.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-16 07:43:44 -07:00
TrueUO
105cde79e0
Bug Fixes (#4847)
- Dryad Allured creatures now delete correctly when released.
- Addons can no longer be placed on front steps per production.
- Fixed an issue with some of the newer stairs in house customization.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 15:23:52 -07:00
TrueUO
262c273723
Cleanup (#4846)
- No code changes in this branch. This is simply clean up.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 08:15:23 -07:00
TrueUO
6beef4c3d1
Bug Fixes (#4845)
- Fixes a crash with the Maze of Death
- Various addon placement improvements.
- Various fixes for galleons and their addons remaining in proper locations when using a plotted course.
- Added in the various missing new Keep and Castle designs.
- Removed a few depreciated files.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-14 15:51:04 -07:00
TrueUO
a18e34074c
Additions (#4843)
- Adds in the Anvil of Artifacts https://uo.com/wiki/ultima-online-wiki/items/ultima-store-inventory/anvil-of-artifacts/
- Fixed an issue with the WinchAssembly not working correctly to access the Shadowlord peerless.
- Magic Reflect now lowers max physical resist correctly.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-10 08:59:30 -07:00
TrueUO
7b016ebe8e
Bug Fixes (#4842)
Non-VvV players can no longer use vvv mounts
slasher of veils is now weak while inside the chamber of virtue. (shards should move his spawn up north more outside the chamber)
Removed annoying spamming sound for despise creatures

Controlled pets will now take slightly more damage from monsters and bosses.
This is the beginning of our attempts to better balance out pets vs how they are on production in regards to their ability to tank major end content bosses without the need of the tamer to heal or monitor the said pet.
All testing has been done on OSI and we are interested in feedback from OSI players.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-08 09:49:19 -07:00
TrueUO
8e0544a0aa
Cleanup (#4841)
- Removed unneeded usings
- Added recompile support for [restart <true> and console commands (save recompile, nosave recompile)

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-07 21:33:30 -07:00
TrueUO
1b76fac3a6
Bug Fixes (#4839)
Flee is now more EA like
Undead creatures no longer flee
Removed AnimalAI
Fixed dispel field so mobiles can be targeted, removed messages per EA
White Tiger Form no longer reveals on cast

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-03 11:14:32 -07:00
TrueUO
6ef1e31f12
Bug Fixes (#4837)
- Fixed the loot intensity values for DCI and HCI.
- Changed how the exodus dungeon and key getting works.
- Various quest fixes.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-31 17:54:54 -07:00
TrueUO
cc2bf5cbcb
Additions (#4836)
- Dexter added in the Artisan Festival
https://uo.com/wiki/ultima-online-wiki/seasonal-events/artisan-festival/
- Redid the seasons system slightly.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-31 06:53:09 -07:00
LG Archer
93646bc5bd
Various Fixes (#4834)
* Properly implement ICommodity.Description in CommodityDeed tooltips.

* Improve arbitrary formatting for merge compatibility.

* Fix a timer dump export error.

* Remove redundant missing file from csproj list.

* Add an overload for Gump.AddTooltip that takes a single string argument.

* Fix access level checks for VvV potions.

* Rename Server.Items.Size enum to Server.Items.ItemSize to prevent ambiguity with System.Drawing.Size.

* Add helper method for adding TextDefinitions to gumps as a tooltip.

* Collection rewards now support TextDefinition tooltips.

* Removed conflicting AddTooltip(string text)

* Fixed Compile error with new ToolTip Support.

Co-authored-by: TrueUO <staff@trueuo.com>
Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-08-29 10:27:44 -07:00