Commit graph

221 commits

Author SHA1 Message Date
Kamron Batman
bbb91fc153
Fixes wrong variable updated in WallBanner (#5046) 2023-03-13 14:52:16 +00:00
TrueUO
5c2d322c9b
RepairBenchFix (#4992) 2022-02-13 17:26:37 +00:00
Martin
0c88de0d8a
Fix SonarQube's "String.IsNullOrEmpty" should be used / Code Smell. (#4935) 2021-05-12 18:27:41 +01:00
Dan
46998bd414 Bug Fixes
- Adds missing items to Huntmaster Reward gump
- Fixes an access issue with the Jewelry box, when turning pages.
- Travesty Mirror Images will no longer turn players criminal.
- Fixes an exploit where items could be used inside of mail boxes, even without the correct access
2020-11-27 22:52:49 +03:00
Dan
af4bc26255 Additions
- Various missing store items
- Certain items can now correctly be used as trash barrels by the home owner.
- Fixes an issue with Ethereal Soulbinders
- No changes were made to XMLFind.
2020-11-12 17:23:37 -05:00
TrueUO
1c7f53a414
OCT17 (#4887)
* OCT17

Minor gump cleanup and XML cleanup.

* Improvements

- Skill Gain is no longer redundantly checked against the same values inside of XMLSpawner.
- AI_Animal (which was not used and just defaulted to AI_Melee) along with AI_Beserk, AI_Predator, and AI_Thief have been safely removed.
- ItemFlags.cs has been moved from XMLSpawner to MISC.
- Removed some misc double calls.

* Needed for recent AI fix.

* Item Fix
2020-10-21 10:15:47 -07:00
TrueUO
e54723ab05
Fixes (#4885)
- Kotl Black Rod now retains its correct color oncraft.
- Removed old/unreachable code in Polymorph.cs (pre aos methods)
- Spawner Cleanup.
- Removal of redundant calls.
2020-10-15 11:26:12 -07:00
TrueUO
21ce1dd042
Changes (#4878)
* Changes

- More timer registry conversions.
- Cleanup of un-needed code.

* Change
2020-10-06 07:44:17 -07:00
TrueUO
6ff5ae05df
Bug Fixes (#4873)
* Bug Fixes

Fixed crash while enabling Kotl System
Added support for invoking commands without a mobile
Bolt of CLoth is no longer flipable with housing
Fixed issue with castle ladders
Chest guardians will now get Soul Bound tag during active Event
Fixed issue where physcial resist wasnt returning to normal value when disabling magic reflect spell

* Bug Fix

- https://www.servuo.com/threads/black-rock-stew-recipe-ingredients-are-not-consumed.13056/
2020-10-03 07:09:47 -07:00
TrueUO
fb4bb8cb13
Bug Fixes (#4871)
- Fixes an issue where monsters and pets could walk through doors.
- Can dye certain Kings Collection items.
- Added in Animdata.
2020-10-01 09:36:55 -07:00
TrueUO
4987b5ecb1
- Revert recent changes to Assistants. (#4855)
* - Revert recent changes to Assistants.
- Ship painting was giving the wrong charge.
- Renamed TreasureChestMod to DungeonChest.cs

* Assistant edit

* Update BaseDungeonChest.cs

* Update BaseDungeonChest.cs

Reverted back.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-22 12:53:20 -07:00
TrueUO
fb1802305f Bug Fixes
- Removed unneeded usings
- World chat log now has a Config option. Turned off by default now.
- Added two new timer priorities.
- Fixed a crash with box of ropes.
- Consolidation of the Pathing movements and algorithms.
- Correctly makes sure you are inside the house you are trying to place addons in.
2020-09-21 09:53:44 -04:00
TrueUO
98d111ae35 Cleanup
- Last of the yearly "cleanup" pushes.
2020-09-18 10:59:33 -04:00
TrueUO
b73897e554
Cleanup (#4848)
- Cleanup of various double calls and simplified code where possible.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-16 07:43:44 -07:00
TrueUO
105cde79e0
Bug Fixes (#4847)
- Dryad Allured creatures now delete correctly when released.
- Addons can no longer be placed on front steps per production.
- Fixed an issue with some of the newer stairs in house customization.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 15:23:52 -07:00
TrueUO
262c273723
Cleanup (#4846)
- No code changes in this branch. This is simply clean up.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 08:15:23 -07:00
TrueUO
6beef4c3d1
Bug Fixes (#4845)
- Fixes a crash with the Maze of Death
- Various addon placement improvements.
- Various fixes for galleons and their addons remaining in proper locations when using a plotted course.
- Added in the various missing new Keep and Castle designs.
- Removed a few depreciated files.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-14 15:51:04 -07:00
TrueUO
a18e34074c
Additions (#4843)
- Adds in the Anvil of Artifacts https://uo.com/wiki/ultima-online-wiki/items/ultima-store-inventory/anvil-of-artifacts/
- Fixed an issue with the WinchAssembly not working correctly to access the Shadowlord peerless.
- Magic Reflect now lowers max physical resist correctly.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-10 08:59:30 -07:00
TrueUO
1b76fac3a6
Bug Fixes (#4839)
Flee is now more EA like
Undead creatures no longer flee
Removed AnimalAI
Fixed dispel field so mobiles can be targeted, removed messages per EA
White Tiger Form no longer reveals on cast

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-03 11:14:32 -07:00
TrueUO
9b5739551b
Changes (#4829)
- Fixed exploit with Mysterious Wisp outside dungeon Despise. It now works according to EA.
- Added in Publish 109 store and 23rd Anniversary Items (Thanks @argalep)

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-21 08:58:28 -07:00
TrueUO
eea7b596c0
Fixes (#4827)
- Fixed a rare crash that could occur with Vendor Search.
- Mysterious fragments drop in t-maps correctly now when Jolly Rogers is enabled.
- Display issue fix for various Kings Collection Items.cs
- Bola has incorrect (reversed) logic, this has been corrected.
- Various changes to make Exploding Tar Potion work per EA.
- Merchants Trinket upgraded to match EA. (Has charges now)
- Various confirmed loot tone downs on various ML named monsters.
- Fixed an exploit with Exploring the Deep quest monsters.
- Fixed various exploits with using the help menu to circumvent the Trade Order restrictions.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-18 09:08:48 -07:00
TrueUO
ffa594cbbb Changes
Removed CanBeWornByGargoyle, RequiredRace properties from all equipment. It is now handled in RaceDefinitions.cs and each race is responsible for validating their own equipment. It is, for the most part, done by ItemID
Consolidated various timers into one static timer: PlayerVendor, RentedVendor, FountainOfLife, Hireables
Fixed a few timer memory leaks
Clockwork leggings can now be imbued
Fixed Phylactery hue
Destard Dungeon Spawn = EA
2020-07-22 16:06:13 -04:00
TrueUO
8067c1bbcf
Additions (#4813)
- Account vaults have been added.
- Added in new aquariums.
- All missing recipes have been added.

Bug Fixes
- Fixes an exploit with mail boxes.
- Auction Safes now work correctly in regards to bid / match bid.
- Cleanup

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-14 09:54:52 -07:00
TrueUO
1b8e5d723b
Cleanup (#4795)
- Various code removed that was using checks we no longer need.
- Required a core re-compile.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-06-16 13:23:30 -07:00
TrueUO
f1ecd0b168
Bug Fixes (#4793)
- FruitTrees now spawn and hold their fruit correctly.
- Mantle of the Fallen can now be repaired correctly.
- Caddellite property is now properly applied to the Treasures of Khaldun reward items.
- Bonsai seeds now display correctly inside the seed box.
- House Deeds have been removed.
- Old houseKey code was removed.
- Khal Ankur now always gives the 4 120 powerscrolls, 8 if using Justice, if killed while the Treasures of Khaldun event is active.
- Dread Warhorse now does its cosmetic "trick" ability.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-06-09 07:50:59 -07:00
TrueUO
a010421b05 Bug Fixes
added square goza mats
Corgul now drops scrolls of transcendence
Corgul spawn now has a chance to drop SOT's
Dark Guardians now drop level 1or2 treasure maps
fixed issue with Ultima Store search
cloth bought from weavers now give the proper itemid
stacked items now limited to 17, per EA (was 20)
Treasures of Khaldun and Treasures of Doom should now function correctly.
2020-05-23 12:59:22 -04:00
TrueUO
26480ad389
Bug Fixes (#4783)
- Addons now ignore roofs (since they ignore floors if their height is > 16), as per EA.
- Blessed items will now drop as loot
- Consolidated methods for getting a random player from looting rights list
- PlunderBeacons and its spawn now give cargo, per EA
- Pirate/Merchant ships now give the proper amount of cargo during rising tides events
- Players can now sell commodities to brokers with no stock
- Mirror Image formula fix.
- Slayer Longbows can now be imbued.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-20 20:09:35 -07:00
TrueUO
80e0d42d33
Bug Fixes (#4782)
- Whirlwind Attack now does the correct amount of damage.
- Added in new Aqaurium system, with new catchable fish. https://uo.com/wiki/ultima-online-wiki/gameplay/aquariums/
- Fixed an issue where players could get a weird client crash, and be unable to log back in right away, when fighting Beacons.
- Fixed an exploit with RunicReforging. Recommend updating to newest Reforging code.
- Fixed an issue where item stats from equipment sets were not adding their values correctly on Mannequins.
- Fixed an issue where you sometimes had to exit and re-enter a house to get all the items the load correctly.
- Players can now correctly craft Charybdis bait.
- All scale types can now correctly be turned in to community collection Mobiles.cs
- Thieve Consumables from the Monster Stealing system now all work correctly.
- Some more file structure cleanup.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-16 15:31:52 -07:00
TrueUO
a99dec6807
Changes (#4781)
All loot pack items are now generated when the mobile is killed.

Reworked monster stealing and begging.

Various re-structuring and bug fixes.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-13 07:58:04 -07:00
TrueUO
c9ac634b2d
Fixed various errors. (#4768)
Repair bench gump will no longer lock up.
Summons now properly flag the caster when they engage in combat.
Cusidhe odds slightly tweaked to match EA.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-04-28 08:28:07 -07:00
TrueUO
8b8519dba4
Bug Fixes (#4767)
Added removed mobiles to Spawner Persistence to remove them from spawners.
Re-Added harful effects for aura effect, reduced range to 3.
Various code cleanup.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-04-23 21:02:21 -07:00
TrueUO
4ed27e117f
Fixes an issue where bards could not use their abilities when calmed. (#4766)
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-04-22 11:40:20 -07:00
TrueUO
f608d123a4
Bug Fixes (#4762)
-Fixed issue where client helpers could bypass the container gump and add items directly to the seed box
-SearedFireAntGoo is no longer stackable
-Blue NPC's (mainly vendors, not initial innocent) can no longer be attacked on trammel maps
-Aggressors/Aggressed from pet masters now works properly. This was suspected to crated large numbers to redundant aggressor/aggressed added to a mobiles aggressor/aggressed lists
-Aggressive action for healing a mobile while fighting another mobile has been re-enabled
-AuraDamage is now a harmful act, ie those affected will aggro on your pet!
-MLDryads should no longer attack other wild creatures during Blackthorn Invasion Instance
-More code cleanup
2020-04-21 17:25:24 -07:00
TrueUO
65ea32264b
Imbue fix. (#4761)
Various Cleanup
2020-04-20 10:09:58 -07:00
TrueUO
8427e1fc91 No more this.stuff 2020-04-16 18:41:32 -07:00
TrueUO
01f18a3eff A total convert of get return to => 2020-04-16 20:37:29 -04:00
TrueUO
5ba7d4dc76 Scripts folder cleanup. 2020-04-16 18:42:38 -04:00
TrueUO
1a40e06495 Removes unneeded ints from the entire project.
VS checked.

Tested and works fine.
2020-04-16 09:27:30 -04:00
TrueUO
528c0e0459 Made private fields readonly, where possible.
If a class has a field that's not marked readonly but is only set in the constructor, it could cause confusion about the field's intended use. To avoid confusion, such fields should be marked readonly to make their intended use explicit, and to prevent future maintainers from inadvertently changing their use.
2020-04-15 10:13:04 -04:00
TrueUO
6c3cf594a4
Using items folder (#4730)
* Services Folder Cleanup

* using and VS cleanup of the Mobile folder.

* using VS cleanup of Items
2020-04-14 15:23:42 -04:00
TrueUO
f67b4fd776
Just some random cleanup. (#4711) 2020-04-13 07:22:42 -07:00
Dexter
af1e785b78
Revert "Revert "- remove all old OnSingleClick functions (#4660)" (#4661)" (#4662)
This reverts commit 43ebeabc20.
2020-04-02 13:59:24 -04:00
Dexter
43ebeabc20
Revert "- remove all old OnSingleClick functions (#4660)" (#4661)
This reverts commit 69442afc1b.
2020-04-02 13:13:23 -04:00
Argalep
69442afc1b
- remove all old OnSingleClick functions (#4660) 2020-04-02 10:22:26 -04:00
Argalep
03776a94cc
Removes era checks (#4643)
* remove CustomsFramework

* Removes era checks

* fix

* Removes ML era checks

* fix.

* Removes SE era checks

* fix.

* Removes era checks

* ix

Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-03-30 19:36:30 -07:00
Argalep
83a980c803
Removes era checks (#4642)
* remove CustomsFramework

* Removes era checks

* fix

* Removes ML era checks

* fix.

* Removes SE era checks

* fix.

Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-03-31 00:52:37 +03:00
TrueUO
537f2dc5e3
Merges guilds and fixes a [createworldcrash / badspawnerrors on first time creation. (#4611) 2020-03-24 13:28:05 -04:00
Dexter
0c4d0dcc19
Bug Fixes (#4589)
* - Internal Galleon Update: Galleon Facing now  uses the Multi Component List to change the ID's of fixtures. Some of the ID's (weapon pads) were not using the correct ID's, and this way the code is much more simplified. All fixture lists have been consolidated into one list.
- Gargish Jewels no longer drop on non-SA Core
- Fixed issue with trapped boxes
- Added Event Sink for sending detailed house foundation packet.
- Fixed issue where imbued jewelry weren't getting durability.

* update solution
fixed graphical issue

* Bug Fixes
- Added Blackthorne DUngeon stealables
- Added proper base resists to Leather Ninja Hood
- Medusa now drops Medusa Floor Tile Addon Deed (THANKS MILVA!)
- AOSWeaponAttributes now work on Armor
- Protection now expires after player death
- Fixed crash in PVP Arena Gumps
- Exceptional Damage Inc no longer gives extra points for Clean up Britannia Turn In
- Fixed Loyalty Gump Crash
- Fixed Stygian Dragon arty drops per EA

* Potential Crash Fix

* csproj update

* Fixed conflict issue... WTF?

* Bug Fixes *Requires Core Recompile*
- Fixed cliloc on new belt craftables
- failed craft no longer deletes crimson cincture and luck mempo
- Added a core edit to Container.cs (had to do it folks) for better resource evaluation when considering resources to consume while crafting. In this instance, we don't want VvV or Faction items being used as craftable resources due to thier ease of obtaining.
- Consolidated no-delete resources in CraftSystem.cs
- Fellowship Data now serializes to prevent generation at each server start

* Resolve Conflicts

* Bug Fixes
- Shield bash forumula no more EA like (still not perfect)
- Healers now show to dead players (needs work)
- Honor buff now persists through death
-

* crash fix

* Initial Commit - Publish 105 Forgotten Treasures
- Removed Remove trap skill prerequisites

* Moongate Fix
- You have to be 1 tile to double click it. All other range checks are correct.

* Commit #2

* crash fix

* Commit #3

* Crash Fix

* Commit #3

* More updates and additions. Compiles!

* Final Commit

* Project Update

* Shields no longer engraveable w/ armor engraving tool.

* Fixed THunting Town Crier Quest
Fixed issue where initial guardians were not spawning for level 1 maps

* Compile error fix.

* COmpire error #2 fix

* Bug Fixes
- Summoners Kilt is now repairable
- Orange petals are now 1 stone each (HS era check)
- Enabled altering artifact (IsArtifact) footwear
- Altering certain artifact (IsArtifact) items now carry over the proper resistance bonuses
- Fixed Primeval Lich Unholy Touch special ability
- Orc brutes now have a chance to throw an orc on any damage Received
- Name changes now show up on the paperdoll (you have to close/re-open)
- Removed "Gravewater Lake" region. It was conflicting with region functionality in Exploring the Deep Quest
- Shadowguard Orchard Encounter apples now spawn a treefellow on each player in the region when deleted and thrown at the incorrect Tree
- Shanty the Pirate no longer does reflect damage attack
- Animal Lore gump now shows adjusted stats, ie cursed/blessed
- Vendor Maps in Tokuno no longer crash the client
- Nether Blase cast delay moved to 2.0 seconds, per EA
- Arcane Empowerment SDI buff now shows in the status bar
- Wildfire should no longer stack

* Bug Fixes
- Toggling weapon specials now expires Injected Strike
- Crafting stacked items will now drastically reduce the amount of skill gains, per EA
- Fixed issue where items were invisible to players in castle courtyards
- Fixed issue where Assistants were kicking EC clients during Handshake
- Added proper area effects to Fire Beetle

* Added singing ball

* Bug Fixes
- Increases Spinning Wheel timer to 6s
- Attacking pets now use active speed when combatant is not a player, per EA
- Fixed name issue for certain CUB pigments
- Fixed issue where only young players could use stash treasure maps
- Blackthorn invasion creatures will no longer be able to swim (water elementals)
2020-03-13 13:34:56 -04:00
Dexter
0189230576
Forgotten treasures (#4580)
* - Internal Galleon Update: Galleon Facing now  uses the Multi Component List to change the ID's of fixtures. Some of the ID's (weapon pads) were not using the correct ID's, and this way the code is much more simplified. All fixture lists have been consolidated into one list.
- Gargish Jewels no longer drop on non-SA Core
- Fixed issue with trapped boxes
- Added Event Sink for sending detailed house foundation packet.
- Fixed issue where imbued jewelry weren't getting durability.

* update solution
fixed graphical issue

* Bug Fixes
- Added Blackthorne DUngeon stealables
- Added proper base resists to Leather Ninja Hood
- Medusa now drops Medusa Floor Tile Addon Deed (THANKS MILVA!)
- AOSWeaponAttributes now work on Armor
- Protection now expires after player death
- Fixed crash in PVP Arena Gumps
- Exceptional Damage Inc no longer gives extra points for Clean up Britannia Turn In
- Fixed Loyalty Gump Crash
- Fixed Stygian Dragon arty drops per EA

* Potential Crash Fix

* csproj update

* Fixed conflict issue... WTF?

* Bug Fixes *Requires Core Recompile*
- Fixed cliloc on new belt craftables
- failed craft no longer deletes crimson cincture and luck mempo
- Added a core edit to Container.cs (had to do it folks) for better resource evaluation when considering resources to consume while crafting. In this instance, we don't want VvV or Faction items being used as craftable resources due to thier ease of obtaining.
- Consolidated no-delete resources in CraftSystem.cs
- Fellowship Data now serializes to prevent generation at each server start

* Resolve Conflicts

* Bug Fixes
- Shield bash forumula no more EA like (still not perfect)
- Healers now show to dead players (needs work)
- Honor buff now persists through death
-

* crash fix

* Initial Commit - Publish 105 Forgotten Treasures
- Removed Remove trap skill prerequisites

* Moongate Fix
- You have to be 1 tile to double click it. All other range checks are correct.

* Commit #2

* crash fix

* Commit #3

* Crash Fix

* Commit #3

* More updates and additions. Compiles!

* Final Commit

* Project Update

* Shields no longer engraveable w/ armor engraving tool.
2020-03-11 09:38:28 -04:00
Argalep
99c0bb1a40
Add Publish 108 Items (#4570)
* add Metal Ladder
add Decorative Wine Rack
add Decorative Garden Sculpture

* - Enchanted Granite Cart fix.

* * add spiral staircase

* fixs

* remove property

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-02-27 18:20:47 -05:00