Commit graph

108 commits

Author SHA1 Message Date
TrueUO
0ac5795331
Fix (#5074)
Co-authored-by: Daniel Knight <knight.daniel.r@gmail.com>
2023-11-18 09:13:32 +00:00
Dan
3d4c04e051 Bug Fixes
- Fixes issue FermentationBarrel.cs
- Fixes issues with Fellowship Medallion
- Fixes issue where players could use the Primevil Lich champion spawn to get into the Abyss, without the quest.
2020-11-24 23:24:11 +03:00
TrueUO
550ff0e207
Restructure (#4875)
- Removed the Expansion folder in Services.
- Put everything that was in that folder in its appropriate location.

NO FILES WERE ACTUALLY CHANGED IN THIS PR - SIMPLY MOVED.
2020-10-04 09:12:11 -07:00
TrueUO
fb1802305f Bug Fixes
- Removed unneeded usings
- World chat log now has a Config option. Turned off by default now.
- Added two new timer priorities.
- Fixed a crash with box of ropes.
- Consolidation of the Pathing movements and algorithms.
- Correctly makes sure you are inside the house you are trying to place addons in.
2020-09-21 09:53:44 -04:00
TrueUO
98d111ae35 Cleanup
- Last of the yearly "cleanup" pushes.
2020-09-18 10:59:33 -04:00
TrueUO
b73897e554
Cleanup (#4848)
- Cleanup of various double calls and simplified code where possible.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-16 07:43:44 -07:00
TrueUO
262c273723
Cleanup (#4846)
- No code changes in this branch. This is simply clean up.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 08:15:23 -07:00
TrueUO
6beef4c3d1
Bug Fixes (#4845)
- Fixes a crash with the Maze of Death
- Various addon placement improvements.
- Various fixes for galleons and their addons remaining in proper locations when using a plotted course.
- Added in the various missing new Keep and Castle designs.
- Removed a few depreciated files.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-14 15:51:04 -07:00
TrueUO
cc2bf5cbcb
Additions (#4836)
- Dexter added in the Artisan Festival
https://uo.com/wiki/ultima-online-wiki/seasonal-events/artisan-festival/
- Redid the seasons system slightly.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-31 06:53:09 -07:00
LG Archer
93646bc5bd
Various Fixes (#4834)
* Properly implement ICommodity.Description in CommodityDeed tooltips.

* Improve arbitrary formatting for merge compatibility.

* Fix a timer dump export error.

* Remove redundant missing file from csproj list.

* Add an overload for Gump.AddTooltip that takes a single string argument.

* Fix access level checks for VvV potions.

* Rename Server.Items.Size enum to Server.Items.ItemSize to prevent ambiguity with System.Drawing.Size.

* Add helper method for adding TextDefinitions to gumps as a tooltip.

* Collection rewards now support TextDefinition tooltips.

* Removed conflicting AddTooltip(string text)

* Fixed Compile error with new ToolTip Support.

Co-authored-by: TrueUO <staff@trueuo.com>
Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-08-29 10:27:44 -07:00
TrueUO
9b5739551b
Changes (#4829)
- Fixed exploit with Mysterious Wisp outside dungeon Despise. It now works according to EA.
- Added in Publish 109 store and 23rd Anniversary Items (Thanks @argalep)

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-21 08:58:28 -07:00
TrueUO
7b33cfc710
Fixes (#4825)
- fixes issue where you could still use teleporters and moongates while completing trade orders
- Exploding Tar Potions now work correctly.
- Added logging to Auctions.
- Can't sell items in locked containers.
- Explode potions no longer follow mobiles.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-09 19:25:04 -07:00
TrueUO
43ef3b7cf2
Changes (#4820)
- Shop item prices now reset at startup, per EA
- Nether Cyclone spell damage fixed
- magic reflect spell now EA like
- Vis list now persists through restarts.
- Fixed an exploit with ChickenStatue and CowStatue.cs
- Fishing poles now get luck accounted
- Restless soul is now grey
- Added proper CUB point value to tmaps
- Doom spawns are now seperated and EA accurate.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-26 18:18:34 -07:00
TrueUO
f2e8033ef1 Bug Fixes
Orchard apples can now be eaten by pets (that eat apples)
Per EA, added action delay per each item for EC equip macro
Fixed crash for shadowguard
Fixed issue where shadowguard would get hung up
Players can now use detect hidden (not passive) on blues in fel
consolidated ItemSocket expire timers in one static timer
Mastery spells will now bypass mana check to expire
Fixed issue where shadowguard apple was hanging up encounter after server restart
Fixed issue where creatures weren't regenerating stats if they were below 100
2020-07-20 16:14:45 +03:00
LG Archer
2b20fd4a56 Crash fix for enchanted hot item sockets
RootParent needs to be cached, it can change when accessed due to it being a computed property.
The crash in reference to this update was caused by the parent of the target item being validated as a Mobile, but then evaluating as a Corpse at a later point.

Exception:
System.InvalidCastException: Unable to cast object of type 'Server.Items.Corpse' to type 'Server.Mobile'.
2020-07-04 17:32:31 -04:00
TrueUO
f1ecd0b168
Bug Fixes (#4793)
- FruitTrees now spawn and hold their fruit correctly.
- Mantle of the Fallen can now be repaired correctly.
- Caddellite property is now properly applied to the Treasures of Khaldun reward items.
- Bonsai seeds now display correctly inside the seed box.
- House Deeds have been removed.
- Old houseKey code was removed.
- Khal Ankur now always gives the 4 120 powerscrolls, 8 if using Justice, if killed while the Treasures of Khaldun event is active.
- Dread Warhorse now does its cosmetic "trick" ability.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-06-09 07:50:59 -07:00
TrueUO
80e0d42d33
Bug Fixes (#4782)
- Whirlwind Attack now does the correct amount of damage.
- Added in new Aqaurium system, with new catchable fish. https://uo.com/wiki/ultima-online-wiki/gameplay/aquariums/
- Fixed an issue where players could get a weird client crash, and be unable to log back in right away, when fighting Beacons.
- Fixed an exploit with RunicReforging. Recommend updating to newest Reforging code.
- Fixed an issue where item stats from equipment sets were not adding their values correctly on Mannequins.
- Fixed an issue where you sometimes had to exit and re-enter a house to get all the items the load correctly.
- Players can now correctly craft Charybdis bait.
- All scale types can now correctly be turned in to community collection Mobiles.cs
- Thieve Consumables from the Monster Stealing system now all work correctly.
- Some more file structure cleanup.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-16 15:31:52 -07:00
TrueUO
a99dec6807
Changes (#4781)
All loot pack items are now generated when the mobile is killed.

Reworked monster stealing and begging.

Various re-structuring and bug fixes.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-13 07:58:04 -07:00
TrueUO
af14d351da
Changes/Fixes (#4773)
Replaced standard create world teleporter items with regions.
Fixed an exploit with the Huntmaster.
MessageInABottle uses the new ItemID.
Various boat clean up and command fixes.
Fixed a crash that could result when t-hunting and a guardian is blocked from spawning.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-04 07:51:02 -07:00
TrueUO
d695fdaeaf
Fixes (#4771)
Added decorative stable and dungeon set to the UO Store.
Fixed an exploit where anyone could gain control of someone elses mannequin.
"Expansion" is now hard coded as we no longer set it.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-04-29 07:13:55 -07:00
TrueUO
8b8519dba4
Bug Fixes (#4767)
Added removed mobiles to Spawner Persistence to remove them from spawners.
Re-Added harful effects for aura effect, reduced range to 3.
Various code cleanup.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-04-23 21:02:21 -07:00
TrueUO
f608d123a4
Bug Fixes (#4762)
-Fixed issue where client helpers could bypass the container gump and add items directly to the seed box
-SearedFireAntGoo is no longer stackable
-Blue NPC's (mainly vendors, not initial innocent) can no longer be attacked on trammel maps
-Aggressors/Aggressed from pet masters now works properly. This was suspected to crated large numbers to redundant aggressor/aggressed added to a mobiles aggressor/aggressed lists
-Aggressive action for healing a mobile while fighting another mobile has been re-enabled
-AuraDamage is now a harmful act, ie those affected will aggro on your pet!
-MLDryads should no longer attack other wild creatures during Blackthorn Invasion Instance
-More code cleanup
2020-04-21 17:25:24 -07:00
TrueUO
8427e1fc91 No more this.stuff 2020-04-16 18:41:32 -07:00
TrueUO
01f18a3eff A total convert of get return to => 2020-04-16 20:37:29 -04:00
TrueUO
5ba7d4dc76 Scripts folder cleanup. 2020-04-16 18:42:38 -04:00
TrueUO
1a40e06495 Removes unneeded ints from the entire project.
VS checked.

Tested and works fine.
2020-04-16 09:27:30 -04:00
TrueUO
528c0e0459 Made private fields readonly, where possible.
If a class has a field that's not marked readonly but is only set in the constructor, it could cause confusion about the field's intended use. To avoid confusion, such fields should be marked readonly to make their intended use explicit, and to prevent future maintainers from inadvertently changing their use.
2020-04-15 10:13:04 -04:00
TrueUO
6c3cf594a4
Using items folder (#4730)
* Services Folder Cleanup

* using and VS cleanup of the Mobile folder.

* using VS cleanup of Items
2020-04-14 15:23:42 -04:00
TrueUO
d2a4e0b8e4
Just more cleanup (#4713) 2020-04-13 13:41:30 -07:00
Dexter
af1e785b78
Revert "Revert "- remove all old OnSingleClick functions (#4660)" (#4661)" (#4662)
This reverts commit 43ebeabc20.
2020-04-02 13:59:24 -04:00
Dexter
43ebeabc20
Revert "- remove all old OnSingleClick functions (#4660)" (#4661)
This reverts commit 69442afc1b.
2020-04-02 13:13:23 -04:00
Argalep
69442afc1b
- remove all old OnSingleClick functions (#4660) 2020-04-02 10:22:26 -04:00
Argalep
03776a94cc
Removes era checks (#4643)
* remove CustomsFramework

* Removes era checks

* fix

* Removes ML era checks

* fix.

* Removes SE era checks

* fix.

* Removes era checks

* ix

Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-03-30 19:36:30 -07:00
Argalep
83a980c803
Removes era checks (#4642)
* remove CustomsFramework

* Removes era checks

* fix

* Removes ML era checks

* fix.

* Removes SE era checks

* fix.

Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-03-31 00:52:37 +03:00
TrueUO
01182e2af6
Removes unneeded netstate checks. (#4625) 2020-03-26 14:00:50 -07:00
Dexter
ac8b30bde9
Remove Factions (#4612) 2020-03-24 19:05:36 -04:00
TrueUO
537f2dc5e3
Merges guilds and fixes a [createworldcrash / badspawnerrors on first time creation. (#4611) 2020-03-24 13:28:05 -04:00
TrueUO
e5a4078a27
Dan2 (#4609)
* This removes the remaining unused Quests that use locations no longer used on EA.
DarkTides
EminosUndertaking

* Removed the "OldDespise" spawn file. Consolidated the other folders.

* Minor edits

* Cleanup

* Minor updates.

* Update Scripts.csproj

Updated DreamWraith.cs name.

Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-03-24 11:22:28 -04:00
TrueUO
1475511fd5
DO NOT COMMIT UNTIL LAST RELEASE IS COMPILED (#4606)
* DO NOT COMMIT UNTIL LAST RELEASE IS COMPILED

FOR REVIEW ONLY RIGHT NOW.

Removes the unused Ethics system.

* Removed the outdated Uzeraan Turmoil quest chain. (Used Old Haven, now destroyed)

This safely "disables" it. These quests are Ser/Deser within the old quest system so we can find a way to remove them all at once.

There are 3 more I will break down to this level.
2020-03-24 00:30:31 -04:00
Dexter
661ebefa09
Merge branch 'master' into BugFixes 2019-08-15 21:15:44 -07:00
Dexter
3034ab72ee added missing file 2019-08-15 21:14:41 -07:00
Tasanar
9535de39cb Just some more bored cleanup and Cliloc additions. 2019-08-14 17:39:30 -04:00
Tasanar
83cef83820 More clilocs updates. If we have clilocs, why not use them! 2019-08-13 21:32:13 -04:00
Tasanar
4a9f991cfe More code cleanup - Added a bunch of missing Clilocs. 2019-08-13 14:37:24 -04:00
Dexter
3cbde67d29 Bug Fixes:
- Special SCrolls books are now accessible to those who locked it down
- Caddelite harvest resources should now stack properly
- Ossein Ram now has the proper trainable pet abilities
2019-06-29 09:43:19 -07:00
Dexter
cefa6fc218 Rising Tide:
Near complete, a small amount of testing to be done.
2019-06-22 23:00:42 -07:00
Dexter
5b557fc00e Bug Fixes
- Added 1 more core mod for object property list stacking. Thanks EA for this, but we finally it close to EA
- Fixed skill gain method for stacked craftables.
- Added skill gain amount to Region.cs. This will enable shard owners to modify skill gain amount  enhancement in regions, as was a couple past EA events.
-
2019-06-12 21:45:42 -07:00
Dexter
3e846f7390 Bug Fixes
- Added IResource interface to Ingots and Boards/Logs
- Fixed Mana Leech Formula, per EA
- Rowboats can now be placed when another ship is in the world
- Rowboat display issue fixed when Moving
- Fixed shadowguard exploit when party is disbanded inside the roof encoutner
- Shadowguard now uses region mobiles for tasks such as messaging, death checks, credit, etc as opposed to a party check in the event party disbands
- Fixed issue where void pool cretaures were leaking to internal Map
- Enchanted apple now removes Mortal Wound
- Fixed (hopefully) crash anomaly in Wildfire
2019-05-11 17:01:32 -07:00
Dexter
dbe818296e Added more event sinks *Requires Core Re-Compile*
-This are currently not used, and can be added as to custom code to keep the distro code Clean
-Cleaned up and consolidated some klunky code in various scripts to be handled as event sinks, ie Container.cs, BaseCreature.cs, etc
-Reduced amount of Niporailem Spawn (Spectral Armor), and fixed gold/sand to decay after 15 Minutes
-Added support to Corpse.cs for a Corpse Loot event to keep track of corpses original loot, to prevent exploits
-Enhanced Kill Handler in Points System to handle any mobile (as opposed to BaseCreature only) for more flexibility or possible future systems
2019-04-29 19:56:47 -07:00
Dexter
e5384662e9 New Features:
- Added Config for murderer travel restriction. Default is true. Change to false to allow reds in Trammel. They will not be able to use vendors in guardzones
- Added overrideable property in Region.cs for insurance multiplier. Set to 0 if you want no insurance cost, etc.
2019-03-23 20:50:41 -07:00