Method public static void ApplyAttributesTo(Item item, int attributeCount, int min, int max)
using a FishingPole create an infinite loop because this method was missing :
public static void ApplyAttributesTo(FishingPole pole, int attributeCount, int min, int max)
- Adds missing items to Huntmaster Reward gump
- Fixes an access issue with the Jewelry box, when turning pages.
- Travesty Mirror Images will no longer turn players criminal.
- Fixes an exploit where items could be used inside of mail boxes, even without the correct access
Fixed an issue where various new potions were incorrectly able to be placed inside potion kegs.
Fixed a display issue with the Fermentation Barrel.
Fixed an issue with Vendor Search and certain vendor maps that were being created incorrectly.
Fixed an issue where a pet owner's luck was not always being calculated when determining basic loot drops.
Fixed an issue where monsters and pets could get "stuck" while casting a spell and would not cast anymore until after a restart.
- Kotl Black Rod now retains its correct color oncraft.
- Removed old/unreachable code in Polymorph.cs (pre aos methods)
- Spawner Cleanup.
- Removal of redundant calls.
- Removed the Expansion folder in Services.
- Put everything that was in that folder in its appropriate location.
NO FILES WERE ACTUALLY CHANGED IN THIS PR - SIMPLY MOVED.
Added stam/hits/mana regen timers to registry. Players and creatures will have their own timers to reduce any timer drift for players.
Moved TimerRegistry.cs to Server folder
Fixed issue where champ spawns weren't generating after they were deleted
Fixed issue where champ spawn corpses weren't deleting after 1 minute
Added timer object threshold where if met, a new timer will be created. This will prevent timers from processing potentially large lists causing server hangups.
removed huge memory leaks of un-needed timers firing during mobile creation and deserialization
Corpse decay times are now controlled by the mobile
- Removed unneeded usings
- World chat log now has a Config option. Turned off by default now.
- Added two new timer priorities.
- Fixed a crash with box of ropes.
- Consolidation of the Pathing movements and algorithms.
- Correctly makes sure you are inside the house you are trying to place addons in.
- Fixes a crash with the Maze of Death
- Various addon placement improvements.
- Various fixes for galleons and their addons remaining in proper locations when using a plotted course.
- Added in the various missing new Keep and Castle designs.
- Removed a few depreciated files.
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
- Fixed exploit with Mysterious Wisp outside dungeon Despise. It now works according to EA.
- Added in Publish 109 store and 23rd Anniversary Items (Thanks @argalep)
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
- fixes issue where you could still use teleporters and moongates while completing trade orders
- Exploding Tar Potions now work correctly.
- Added logging to Auctions.
- Can't sell items in locked containers.
- Explode potions no longer follow mobiles.
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
Removed CanBeWornByGargoyle, RequiredRace properties from all equipment. It is now handled in RaceDefinitions.cs and each race is responsible for validating their own equipment. It is, for the most part, done by ItemID
Consolidated various timers into one static timer: PlayerVendor, RentedVendor, FountainOfLife, Hireables
Fixed a few timer memory leaks
Clockwork leggings can now be imbued
Fixed Phylactery hue
Destard Dungeon Spawn = EA
- Account vaults have been added.
- Added in new aquariums.
- All missing recipes have been added.
Bug Fixes
- Fixes an exploit with mail boxes.
- Auction Safes now work correctly in regards to bid / match bid.
- Cleanup
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
- Fixed issue where SOS chests were not being flipped properly with the interior decorator
- increased ecru citrine ring chance for the enhance pots
- ecru citrine rings no longer get random mods, but will get str bonus if the Enhance Pots roll fails, per EA
- Slightly increased chances to fish up rare and legendary fish
- Fixed issue where zombie fish was fished up almost eveyr time in Gravewater Lake
- BaseCreatures aggressed by controlled creatures will not have the creatures master added to aggressor list. This prevents young players from using summons/pets to kill monsters and not being attacked Back
- Added new loot drops to HS bosses
- Weapon Attributes will now be properly counted on BaseClothing items
- Fixed damage from Spell Plague
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
- Whirlwind Attack now does the correct amount of damage.
- Added in new Aqaurium system, with new catchable fish. https://uo.com/wiki/ultima-online-wiki/gameplay/aquariums/
- Fixed an issue where players could get a weird client crash, and be unable to log back in right away, when fighting Beacons.
- Fixed an exploit with RunicReforging. Recommend updating to newest Reforging code.
- Fixed an issue where item stats from equipment sets were not adding their values correctly on Mannequins.
- Fixed an issue where you sometimes had to exit and re-enter a house to get all the items the load correctly.
- Players can now correctly craft Charybdis bait.
- All scale types can now correctly be turned in to community collection Mobiles.cs
- Thieve Consumables from the Monster Stealing system now all work correctly.
- Some more file structure cleanup.
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
Repair bench gump will no longer lock up.
Summons now properly flag the caster when they engage in combat.
Cusidhe odds slightly tweaked to match EA.
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
Added removed mobiles to Spawner Persistence to remove them from spawners.
Re-Added harful effects for aura effect, reduced range to 3.
Various code cleanup.
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
-Fixed issue where client helpers could bypass the container gump and add items directly to the seed box
-SearedFireAntGoo is no longer stackable
-Blue NPC's (mainly vendors, not initial innocent) can no longer be attacked on trammel maps
-Aggressors/Aggressed from pet masters now works properly. This was suspected to crated large numbers to redundant aggressor/aggressed added to a mobiles aggressor/aggressed lists
-Aggressive action for healing a mobile while fighting another mobile has been re-enabled
-AuraDamage is now a harmful act, ie those affected will aggro on your pet!
-MLDryads should no longer attack other wild creatures during Blackthorn Invasion Instance
-More code cleanup
If a class has a field that's not marked readonly but is only set in the constructor, it could cause confusion about the field's intended use. To avoid confusion, such fields should be marked readonly to make their intended use explicit, and to prevent future maintainers from inadvertently changing their use.
* Removed faction args from AcquireFocusMob in BaseAI
* Fixed issue with vendor rental contracts not unliking from house when using "retrieve" context menu
fixed pen of wisdom not deleting
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
* BaseXmlSpawner Cleanup
* More clean up
* Starting to cleanup outdated OnSingleClick calls. (Not all OnSingleClick should be removed but these ones are safe)
* Removed faction args from AcquireFocusMob in BaseAI
* Removed Pre-AOS properties from BaseArmor
* Cleanup BaseClothing and PlayerMobile (removed era checks)
* Removed old Opposition Group, replaced by Tribe. UPdated BaseCreature
* Spell Cleanup
* Cleanued up Loot.cs, Lootpack.cs
* Removed Era Checks from multiple files
* removed old tmap config
* Bug Fixes
- Added Bag of Gold, Bag of Gems, and Bag of Regs to TMap contents
- Honor now updates perfect % property when perfection is achieved
- Remove Trap now gains property on gm made traps
- Nether Blast and Nether Cyclone now will combat flag caster on the mobile damaged
* Fixed issue where certain properties weren't applying to name prefix/suffix themed items.
* Bug Fixes
- Fixed issue where alchemy special scrolls couldn't be dropped from special scroll books
- Removed Bad Spawn from Spawners
- Cora can now be counted as a kill in A Forced Sacrafice Quest
- Removed IsSoulBound from serialization in BaseCreature
- Fixed issue where Mysterious Potion wasn't working on Cora's mana Attack
* removed debug code, added other bad of sending hue
* remove CustomsFramework
* Removes era checks
* fix
* Removes ML era checks
* fix.
* Removes SE era checks
* fix.
* Removes era checks
* ix
Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
* - Internal Galleon Update: Galleon Facing now uses the Multi Component List to change the ID's of fixtures. Some of the ID's (weapon pads) were not using the correct ID's, and this way the code is much more simplified. All fixture lists have been consolidated into one list.
- Gargish Jewels no longer drop on non-SA Core
- Fixed issue with trapped boxes
- Added Event Sink for sending detailed house foundation packet.
- Fixed issue where imbued jewelry weren't getting durability.
* update solution
fixed graphical issue
* Bug Fixes
- Added Blackthorne DUngeon stealables
- Added proper base resists to Leather Ninja Hood
- Medusa now drops Medusa Floor Tile Addon Deed (THANKS MILVA!)
- AOSWeaponAttributes now work on Armor
- Protection now expires after player death
- Fixed crash in PVP Arena Gumps
- Exceptional Damage Inc no longer gives extra points for Clean up Britannia Turn In
- Fixed Loyalty Gump Crash
- Fixed Stygian Dragon arty drops per EA
* Potential Crash Fix
* csproj update
* Fixed conflict issue... WTF?
* Bug Fixes *Requires Core Recompile*
- Fixed cliloc on new belt craftables
- failed craft no longer deletes crimson cincture and luck mempo
- Added a core edit to Container.cs (had to do it folks) for better resource evaluation when considering resources to consume while crafting. In this instance, we don't want VvV or Faction items being used as craftable resources due to thier ease of obtaining.
- Consolidated no-delete resources in CraftSystem.cs
- Fellowship Data now serializes to prevent generation at each server start
* Resolve Conflicts
* Bug Fixes
- Shield bash forumula no more EA like (still not perfect)
- Healers now show to dead players (needs work)
- Honor buff now persists through death
-
* crash fix
* Initial Commit - Publish 105 Forgotten Treasures
- Removed Remove trap skill prerequisites
* Moongate Fix
- You have to be 1 tile to double click it. All other range checks are correct.
* Commit #2
* crash fix
* Commit #3
* Crash Fix
* Commit #3
* More updates and additions. Compiles!
* Final Commit
* Project Update
* Shields no longer engraveable w/ armor engraving tool.
* Fixed THunting Town Crier Quest
Fixed issue where initial guardians were not spawning for level 1 maps
* Compile error fix.
* COmpire error #2 fix
* Bug Fixes
- Summoners Kilt is now repairable
- Orange petals are now 1 stone each (HS era check)
- Enabled altering artifact (IsArtifact) footwear
- Altering certain artifact (IsArtifact) items now carry over the proper resistance bonuses
- Fixed Primeval Lich Unholy Touch special ability
- Orc brutes now have a chance to throw an orc on any damage Received
- Name changes now show up on the paperdoll (you have to close/re-open)
- Removed "Gravewater Lake" region. It was conflicting with region functionality in Exploring the Deep Quest
- Shadowguard Orchard Encounter apples now spawn a treefellow on each player in the region when deleted and thrown at the incorrect Tree
- Shanty the Pirate no longer does reflect damage attack
- Animal Lore gump now shows adjusted stats, ie cursed/blessed
- Vendor Maps in Tokuno no longer crash the client
- Nether Blase cast delay moved to 2.0 seconds, per EA
- Arcane Empowerment SDI buff now shows in the status bar
- Wildfire should no longer stack
* Bug Fixes
- Toggling weapon specials now expires Injected Strike
- Crafting stacked items will now drastically reduce the amount of skill gains, per EA
- Fixed issue where items were invisible to players in castle courtyards
- Fixed issue where Assistants were kicking EC clients during Handshake
- Added proper area effects to Fire Beetle
* Added singing ball
* Bug Fixes
- Increases Spinning Wheel timer to 6s
- Attacking pets now use active speed when combatant is not a player, per EA
- Fixed name issue for certain CUB pigments
- Fixed issue where only young players could use stash treasure maps
- Blackthorn invasion creatures will no longer be able to swim (water elementals)
* Bug Fixes
- Adjusted Frenzied Whirlwind min damage
- Thiefs now train remove trap
- Training remove trap no longer requires lockpicking and detect hidden
- Death ray can no longer be stacked on single targets
* Removed unused code
* More adjustments.
* Final Frenzied whirlwind fix
* Bug Fixes
- Treasure Maps now only spawn 1 ancient guardian at a time during remove trap
- Players can now cast spells while digging up Chest
- Removed skill wait time if chest is out of range
- Nether blast mana rip no longer works if target has no mana
* - Fixed Eodonian Potion Crash
- Fixed Ararat Artifact Spawn Locations
- Added Hues to TMap Guardians per EA
* Bug Fixes
- only crewman+ can now repair galleons
- Updated Davie's Locker to handle new TMap System
* added doors
* Nether Blast Nerf. Damage no longer stacks. Fixed reg for Spell Plague Scroll.
* Crash Fix
* Bug Fixes
- Snake Charmers Flute now is crafted the proper hue
- Clean up Brit now gives the proper points for t-maps
- Fixed issue where t-chests could be opened, even if ancient guardian was still alive
* Pets now heal owners who are poisoned.
Shipwright in Tokuno docks now sell galleons.
* Keeps track of script compile time
* Factions removed
* project update
* Conflict Error Fix
* Fixed new gump locations
* oopsy vorspire
* solution fix
* removed disrobe
* Removed pre-AOS BaseWeapon stuff
* removed gitignore "Customs"
* Removed Conflicts
* compile error fix
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
* If the plank is locked, no one can enter the ship from the outside.
* you cannot perform lock operations while the ship plank is open.
* ship refresh messages fixed.
* Players in the normal ship will be able to control the ships.
- Whips can now be dyed with leather dye tubs, and reforged with runic tailor kits
- Refinements now limited to Felucca in town chests
- Quivers now apply the proper bonuses (if worn) when server restarts
- Updated scouring toxin clilocs,
- Scouring toxins no longer consume if there are charges remaining
- Creature stat gains will now gain the corresponding secondary stat, as long as its below the Cap
- Bodyguard can now be used by creatures/pets
- Updated Triton stats/resists
- Fixed issue where true imbuing weight was being used instead of actual imbuing Weight
- Imbuing skills now replace the proper skills belonging to that skill group
- Weapon Velocity Cap fixed
- Pets can now enter the Khaldun Camp Region if their master has the proper credentials
- Regeneration timer now resets when Resilience is casted
