Commit graph

850 commits

Author SHA1 Message Date
pyro17
bebc100d6c
Ranger Equipment fix, Additem delete (#5012)
* Ranger Equipment fix, Additem delete
- add parameter with default value to AddItem
- On Conflict, still log conflict, but delete the conflicting Item by default

- Delete the base boots of Rangers befor adding the new boots

* Updated Mobile Scripts

- went through all scripts to update them to SetWearable
- reverted change to AddItem

* Update to SetWearable

- last item being set will be worn (if no override to OnEquip returns false
- delete the item on the layer that is the same as the new item (if existend)
- used ifs to cap item.Movable, therefor no need to call to Random if <= 0 or >= 1

* Update base InitOutFit

- replaced the Additem for Backpack with SetWearable, Movable is getting set this way too
- altered the other SetWearable calls, to allow the items to be moved / dropped (as they should normally)

* Null reference sanity check.

Co-authored-by: Voxpire <admin@vita-nex.com>
2022-06-16 04:44:54 +01:00
LG Archer
1ae0e57648
Fix erroneous BaseCreature deserialization for old save upgrades (#4938) 2021-05-19 14:40:41 +01:00
Dan
7aadd4796c Bug Fixes
- Safely removed depreciated quests.
- Fixed an exploit where AutoLoot own corpse should only auto loot items that were in there when killed. (prevents people from dropping items in a corpse to get them auto looted)
- Animals with instruments will no longer drop them to the world OnDrop OnRelease.
- Fixed a crash with the City Election system when it has multiple people running.
2020-12-06 00:02:27 +03:00
Dan
63d251645b Bug Fixes
Fixed an issue where various new potions were incorrectly able to be placed inside potion kegs.
Fixed a display issue with the Fermentation Barrel.
Fixed an issue with Vendor Search and certain vendor maps that were being created incorrectly.
Fixed an issue where a pet owner's luck was not always being calculated when determining basic loot drops.
Fixed an issue where monsters and pets could get "stuck" while casting a spell and would not cast anymore until after a restart.
2020-11-19 05:22:25 -05:00
PyrO
19d05fe89e Enum value check to equals instead of is 2020-10-29 14:24:43 -04:00
TrueUO
1c7f53a414
OCT17 (#4887)
* OCT17

Minor gump cleanup and XML cleanup.

* Improvements

- Skill Gain is no longer redundantly checked against the same values inside of XMLSpawner.
- AI_Animal (which was not used and just defaulted to AI_Melee) along with AI_Beserk, AI_Predator, and AI_Thief have been safely removed.
- ItemFlags.cs has been moved from XMLSpawner to MISC.
- Removed some misc double calls.

* Needed for recent AI fix.

* Item Fix
2020-10-21 10:15:47 -07:00
TrueUO
8b82bdd254
Additions (#4881)
* Additions

- Adds two missing deco mail boxes.
- Pumpkins you wish to carve must now be in your backpack.

* More changes and bug fixes.
2020-10-13 13:31:23 -07:00
TrueUO
21ce1dd042
Changes (#4878)
* Changes

- More timer registry conversions.
- Cleanup of un-needed code.

* Change
2020-10-06 07:44:17 -07:00
TrueUO
550ff0e207
Restructure (#4875)
- Removed the Expansion folder in Services.
- Put everything that was in that folder in its appropriate location.

NO FILES WERE ACTUALLY CHANGED IN THIS PR - SIMPLY MOVED.
2020-10-04 09:12:11 -07:00
TrueUO
d8670d7150
Changes (#4872)
Added stam/hits/mana regen timers to registry. Players and creatures will have their own timers to reduce any timer drift for players.
Moved TimerRegistry.cs to Server folder
Fixed issue where champ spawns weren't generating after they were deleted
Fixed issue where champ spawn corpses weren't deleting after 1 minute
Added timer object threshold where if met, a new timer will be created. This will prevent timers from processing potentially large lists causing server hangups.
removed huge memory leaks of un-needed timers firing during mobile creation and deserialization
Corpse decay times are now controlled by the mobile
2020-10-02 12:50:37 -07:00
Dan
c4b8643886 Removed:
- Removed the mostly outdated and little, if ever, used reports.
- Fixes a crash from the new magincia bazaar.
- Added missing Halloween begging items and consolidated them all into one folder.
2020-09-29 03:50:48 -04:00
Dan
7b160c0784 Changes
- Not all Unsummons were correctly disposing of their timers.
- This has been fixed and all Summons are now on one static timer.
- Circuit Trap Trainging kit bug fix.
- Small cleanup.
2020-09-27 19:20:09 -04:00
TrueUO
0bc5fffb3d Fixes
- Added in 15 missing halloween pumpkin designs to the carving kit.
- Fixed loot and properties on Pumpkin Head and The Butcher to match EA.
- Some champ cleanup.
2020-09-26 08:43:04 -04:00
TrueUO
4987b5ecb1
- Revert recent changes to Assistants. (#4855)
* - Revert recent changes to Assistants.
- Ship painting was giving the wrong charge.
- Renamed TreasureChestMod to DungeonChest.cs

* Assistant edit

* Update BaseDungeonChest.cs

* Update BaseDungeonChest.cs

Reverted back.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-22 12:53:20 -07:00
TrueUO
fb1802305f Bug Fixes
- Removed unneeded usings
- World chat log now has a Config option. Turned off by default now.
- Added two new timer priorities.
- Fixed a crash with box of ropes.
- Consolidation of the Pathing movements and algorithms.
- Correctly makes sure you are inside the house you are trying to place addons in.
2020-09-21 09:53:44 -04:00
LG Archer
e3581d2a15
Updates (#4850)
Update to increase merge friendliness for shards updating to the latest codebase.
Fixed an inconsistency with PlayerMobile EquipMacro statements.
2020-09-18 23:27:35 +01:00
TrueUO
98d111ae35 Cleanup
- Last of the yearly "cleanup" pushes.
2020-09-18 10:59:33 -04:00
TrueUO
b73897e554
Cleanup (#4848)
- Cleanup of various double calls and simplified code where possible.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-16 07:43:44 -07:00
TrueUO
105cde79e0
Bug Fixes (#4847)
- Dryad Allured creatures now delete correctly when released.
- Addons can no longer be placed on front steps per production.
- Fixed an issue with some of the newer stairs in house customization.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 15:23:52 -07:00
TrueUO
262c273723
Cleanup (#4846)
- No code changes in this branch. This is simply clean up.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 08:15:23 -07:00
TrueUO
7b016ebe8e
Bug Fixes (#4842)
Non-VvV players can no longer use vvv mounts
slasher of veils is now weak while inside the chamber of virtue. (shards should move his spawn up north more outside the chamber)
Removed annoying spamming sound for despise creatures

Controlled pets will now take slightly more damage from monsters and bosses.
This is the beginning of our attempts to better balance out pets vs how they are on production in regards to their ability to tank major end content bosses without the need of the tamer to heal or monitor the said pet.
All testing has been done on OSI and we are interested in feedback from OSI players.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-08 09:49:19 -07:00
TrueUO
8e0544a0aa
Cleanup (#4841)
- Removed unneeded usings
- Added recompile support for [restart <true> and console commands (save recompile, nosave recompile)

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-07 21:33:30 -07:00
TrueUO
e2dd8b44dd
Change (#4840)
Converted Winch Assembly to peerless Altar
Converted Shadowlord to BasePeerless
Converted peerless keys to BaseDecayingItem
Server startup will require you to delete items. This if fine. It will auto re-generate deleted items.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-06 09:13:59 -07:00
TrueUO
1b76fac3a6
Bug Fixes (#4839)
Flee is now more EA like
Undead creatures no longer flee
Removed AnimalAI
Fixed dispel field so mobiles can be targeted, removed messages per EA
White Tiger Form no longer reveals on cast

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-03 11:14:32 -07:00
TrueUO
6ef1e31f12
Bug Fixes (#4837)
- Fixed the loot intensity values for DCI and HCI.
- Changed how the exodus dungeon and key getting works.
- Various quest fixes.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-31 17:54:54 -07:00
TrueUO
cc2bf5cbcb
Additions (#4836)
- Dexter added in the Artisan Festival
https://uo.com/wiki/ultima-online-wiki/seasonal-events/artisan-festival/
- Redid the seasons system slightly.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-31 06:53:09 -07:00
LG Archer
93646bc5bd
Various Fixes (#4834)
* Properly implement ICommodity.Description in CommodityDeed tooltips.

* Improve arbitrary formatting for merge compatibility.

* Fix a timer dump export error.

* Remove redundant missing file from csproj list.

* Add an overload for Gump.AddTooltip that takes a single string argument.

* Fix access level checks for VvV potions.

* Rename Server.Items.Size enum to Server.Items.ItemSize to prevent ambiguity with System.Drawing.Size.

* Add helper method for adding TextDefinitions to gumps as a tooltip.

* Collection rewards now support TextDefinition tooltips.

* Removed conflicting AddTooltip(string text)

* Fixed Compile error with new ToolTip Support.

Co-authored-by: TrueUO <staff@trueuo.com>
Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-08-29 10:27:44 -07:00
TrueUO
9b5739551b
Changes (#4829)
- Fixed exploit with Mysterious Wisp outside dungeon Despise. It now works according to EA.
- Added in Publish 109 store and 23rd Anniversary Items (Thanks @argalep)

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-21 08:58:28 -07:00
TrueUO
eea7b596c0
Fixes (#4827)
- Fixed a rare crash that could occur with Vendor Search.
- Mysterious fragments drop in t-maps correctly now when Jolly Rogers is enabled.
- Display issue fix for various Kings Collection Items.cs
- Bola has incorrect (reversed) logic, this has been corrected.
- Various changes to make Exploding Tar Potion work per EA.
- Merchants Trinket upgraded to match EA. (Has charges now)
- Various confirmed loot tone downs on various ML named monsters.
- Fixed an exploit with Exploring the Deep quest monsters.
- Fixed various exploits with using the help menu to circumvent the Trade Order restrictions.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-18 09:08:48 -07:00
TrueUO
fee89ebc7e
Changes (#4826)
- All spell timers are now on one master timer. When testing with 70+ online this has lead to smoother casting when various spell casters (monsters and players) are in the same area.
- Global chat now has a forced 5 second delay per OSI.
- Trade Order Crates now except multiple "like type" items.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-12 14:10:49 -07:00
TrueUO
7b33cfc710
Fixes (#4825)
- fixes issue where you could still use teleporters and moongates while completing trade orders
- Exploding Tar Potions now work correctly.
- Added logging to Auctions.
- Can't sell items in locked containers.
- Explode potions no longer follow mobiles.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-09 19:25:04 -07:00
TrueUO
afb62a58b2
Fixes (#4823)
Fixed an exploit with Hawkwinds quest for skill masteries where players could claim an almost unlimited amount.
Fixed an issue where Rentals, when expired correctly, were depositing too much gold.
Fixed a few notority issues with hiding / felucca / ally

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-30 14:39:58 -07:00
TrueUO
45d80710d3 Fix
- Fixes an exploit with vendor rentals.
- Added Spring Deco Collection.
2020-07-28 00:20:19 +03:00
TrueUO
43ef3b7cf2
Changes (#4820)
- Shop item prices now reset at startup, per EA
- Nether Cyclone spell damage fixed
- magic reflect spell now EA like
- Vis list now persists through restarts.
- Fixed an exploit with ChickenStatue and CowStatue.cs
- Fishing poles now get luck accounted
- Restless soul is now grey
- Added proper CUB point value to tmaps
- Doom spawns are now seperated and EA accurate.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-26 18:18:34 -07:00
TrueUO
ffa594cbbb Changes
Removed CanBeWornByGargoyle, RequiredRace properties from all equipment. It is now handled in RaceDefinitions.cs and each race is responsible for validating their own equipment. It is, for the most part, done by ItemID
Consolidated various timers into one static timer: PlayerVendor, RentedVendor, FountainOfLife, Hireables
Fixed a few timer memory leaks
Clockwork leggings can now be imbued
Fixed Phylactery hue
Destard Dungeon Spawn = EA
2020-07-22 16:06:13 -04:00
TrueUO
f2e8033ef1 Bug Fixes
Orchard apples can now be eaten by pets (that eat apples)
Per EA, added action delay per each item for EC equip macro
Fixed crash for shadowguard
Fixed issue where shadowguard would get hung up
Players can now use detect hidden (not passive) on blues in fel
consolidated ItemSocket expire timers in one static timer
Mastery spells will now bypass mana check to expire
Fixed issue where shadowguard apple was hanging up encounter after server restart
Fixed issue where creatures weren't regenerating stats if they were below 100
2020-07-20 16:14:45 +03:00
TrueUO
8067c1bbcf
Additions (#4813)
- Account vaults have been added.
- Added in new aquariums.
- All missing recipes have been added.

Bug Fixes
- Fixes an exploit with mail boxes.
- Auction Safes now work correctly in regards to bid / match bid.
- Cleanup

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-14 09:54:52 -07:00
TrueUO
4cd7990aaf
Hiryu Hits are now properly scaled when tamed (#4810)
Adjusted placement of niter
added captured essence to exodus steal table
fixed display cliloc for treasure maps
Fixed shield base.

Requires a core recompile.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-05 20:35:10 -07:00
TrueUO
7338084882
- Fixed field item placement and LOS for Conflag Potions (#4809)
- Fixed issue where SOS chests were not being flipped properly with the interior decorator
- increased ecru citrine ring chance for the enhance pots
- ecru citrine rings no longer get random mods, but will get str bonus if the Enhance Pots roll fails, per EA
- Slightly increased chances to fish up rare and legendary fish
- Fixed issue where zombie fish was fished up almost eveyr time in Gravewater Lake
- BaseCreatures aggressed by controlled creatures will not have the creatures master added to aggressor list. This prevents young players from using summons/pets to kill monsters and not being attacked Back
- Added new loot drops to HS bosses
- Weapon Attributes will now be properly counted on BaseClothing items
- Fixed damage from Spell Plague

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-04 21:38:23 -07:00
VitaNex
1cf37ac9c4 Runaway stat regeneration timer fixes (prevents the build-up of erroneously allocated stat regeneration timers)
Runaway combatant update protection (prevents stack overflow issues with creatures switching combatants in certain situations)
2020-06-27 07:49:43 -04:00
TrueUO
9228461385 Bug Fixes
- Eject player is now access level based.
- Various Jolly Roger fixes.
2020-06-25 01:28:41 +03:00
TrueUO
05f0d7cbfe
Bug Fixes (#4796)
- Bone Crusher should now work properly.
- Scrappers should now have a chance to add 3 properties at 120 magery
- Players can now heal Vollem's from the crystal (CuB bought) with bandages
- Fixed snow tree/trunk id's and z offset
- Dagger from Fabrizio quest should now deleted when quest is Complete
- Fixed exploit with auto-stabling pets. Basically, added a stable count check for auto stable
- Luck can now be inc/dec by 1 for imbuing (10 for loot)
- Cleanup of various unneeded variables or preaos checks.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-06-22 08:57:10 -07:00
TrueUO
f1ecd0b168
Bug Fixes (#4793)
- FruitTrees now spawn and hold their fruit correctly.
- Mantle of the Fallen can now be repaired correctly.
- Caddellite property is now properly applied to the Treasures of Khaldun reward items.
- Bonsai seeds now display correctly inside the seed box.
- House Deeds have been removed.
- Old houseKey code was removed.
- Khal Ankur now always gives the 4 120 powerscrolls, 8 if using Justice, if killed while the Treasures of Khaldun event is active.
- Dread Warhorse now does its cosmetic "trick" ability.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-06-09 07:50:59 -07:00
TrueUO
52587d522e
Crash Fixes (#4786)
- Fixed a crash that could result if players remained in a peerless zone right up to the 15 minute kick out time.
- Fixed a crash that could result when digging up treasure chests.

Bug Fixes
- Player barkeeps now sell the correct food.
- Various undead no longer flee.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-26 11:31:51 -07:00
TrueUO
a010421b05 Bug Fixes
added square goza mats
Corgul now drops scrolls of transcendence
Corgul spawn now has a chance to drop SOT's
Dark Guardians now drop level 1or2 treasure maps
fixed issue with Ultima Store search
cloth bought from weavers now give the proper itemid
stacked items now limited to 17, per EA (was 20)
Treasures of Khaldun and Treasures of Doom should now function correctly.
2020-05-23 12:59:22 -04:00
TrueUO
26480ad389
Bug Fixes (#4783)
- Addons now ignore roofs (since they ignore floors if their height is > 16), as per EA.
- Blessed items will now drop as loot
- Consolidated methods for getting a random player from looting rights list
- PlunderBeacons and its spawn now give cargo, per EA
- Pirate/Merchant ships now give the proper amount of cargo during rising tides events
- Players can now sell commodities to brokers with no stock
- Mirror Image formula fix.
- Slayer Longbows can now be imbued.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-20 20:09:35 -07:00
TrueUO
80e0d42d33
Bug Fixes (#4782)
- Whirlwind Attack now does the correct amount of damage.
- Added in new Aqaurium system, with new catchable fish. https://uo.com/wiki/ultima-online-wiki/gameplay/aquariums/
- Fixed an issue where players could get a weird client crash, and be unable to log back in right away, when fighting Beacons.
- Fixed an exploit with RunicReforging. Recommend updating to newest Reforging code.
- Fixed an issue where item stats from equipment sets were not adding their values correctly on Mannequins.
- Fixed an issue where you sometimes had to exit and re-enter a house to get all the items the load correctly.
- Players can now correctly craft Charybdis bait.
- All scale types can now correctly be turned in to community collection Mobiles.cs
- Thieve Consumables from the Monster Stealing system now all work correctly.
- Some more file structure cleanup.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-16 15:31:52 -07:00
TrueUO
a99dec6807
Changes (#4781)
All loot pack items are now generated when the mobile is killed.

Reworked monster stealing and begging.

Various re-structuring and bug fixes.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-13 07:58:04 -07:00
TrueUO
d0184a6ce5 Bug Fixes
1. Fixes Niporailem and adds missing mobiles.
2. Seed box gump fix.
3. Various cleanup.
2020-05-08 18:59:45 -04:00
TrueUO
d695fdaeaf
Fixes (#4771)
Added decorative stable and dungeon set to the UO Store.
Fixed an exploit where anyone could gain control of someone elses mannequin.
"Expansion" is now hard coded as we no longer set it.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-04-29 07:13:55 -07:00