Commit graph

263 commits

Author SHA1 Message Date
Dan
46998bd414 Bug Fixes
- Adds missing items to Huntmaster Reward gump
- Fixes an access issue with the Jewelry box, when turning pages.
- Travesty Mirror Images will no longer turn players criminal.
- Fixes an exploit where items could be used inside of mail boxes, even without the correct access
2020-11-27 22:52:49 +03:00
Dan
3d4c04e051 Bug Fixes
- Fixes issue FermentationBarrel.cs
- Fixes issues with Fellowship Medallion
- Fixes issue where players could use the Primevil Lich champion spawn to get into the Abyss, without the quest.
2020-11-24 23:24:11 +03:00
Dan
63d251645b Bug Fixes
Fixed an issue where various new potions were incorrectly able to be placed inside potion kegs.
Fixed a display issue with the Fermentation Barrel.
Fixed an issue with Vendor Search and certain vendor maps that were being created incorrectly.
Fixed an issue where a pet owner's luck was not always being calculated when determining basic loot drops.
Fixed an issue where monsters and pets could get "stuck" while casting a spell and would not cast anymore until after a restart.
2020-11-19 05:22:25 -05:00
Dan
95772b4613 Bug Fix
- Fixes an issue with some items on house transfer.
- Cleanup of ChampSpawns folder and VendorSearch upgrades.
2020-10-28 16:21:55 -04:00
TrueUO
469e1d94b1
CleanUp (#4889)
- Guild clean up and removal of old unused methods.
- Interior Decorator now correctly works on the older style trophies to raise and lower.
2020-10-23 08:16:09 -07:00
TrueUO
550ff0e207
Restructure (#4875)
- Removed the Expansion folder in Services.
- Put everything that was in that folder in its appropriate location.

NO FILES WERE ACTUALLY CHANGED IN THIS PR - SIMPLY MOVED.
2020-10-04 09:12:11 -07:00
TrueUO
d8670d7150
Changes (#4872)
Added stam/hits/mana regen timers to registry. Players and creatures will have their own timers to reduce any timer drift for players.
Moved TimerRegistry.cs to Server folder
Fixed issue where champ spawns weren't generating after they were deleted
Fixed issue where champ spawn corpses weren't deleting after 1 minute
Added timer object threshold where if met, a new timer will be created. This will prevent timers from processing potentially large lists causing server hangups.
removed huge memory leaks of un-needed timers firing during mobile creation and deserialization
Corpse decay times are now controlled by the mobile
2020-10-02 12:50:37 -07:00
Dan
7b160c0784 Changes
- Not all Unsummons were correctly disposing of their timers.
- This has been fixed and all Summons are now on one static timer.
- Circuit Trap Trainging kit bug fix.
- Small cleanup.
2020-09-27 19:20:09 -04:00
TrueUO
4987b5ecb1
- Revert recent changes to Assistants. (#4855)
* - Revert recent changes to Assistants.
- Ship painting was giving the wrong charge.
- Renamed TreasureChestMod to DungeonChest.cs

* Assistant edit

* Update BaseDungeonChest.cs

* Update BaseDungeonChest.cs

Reverted back.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-22 12:53:20 -07:00
TrueUO
fb1802305f Bug Fixes
- Removed unneeded usings
- World chat log now has a Config option. Turned off by default now.
- Added two new timer priorities.
- Fixed a crash with box of ropes.
- Consolidation of the Pathing movements and algorithms.
- Correctly makes sure you are inside the house you are trying to place addons in.
2020-09-21 09:53:44 -04:00
TrueUO
98d111ae35 Cleanup
- Last of the yearly "cleanup" pushes.
2020-09-18 10:59:33 -04:00
TrueUO
b73897e554
Cleanup (#4848)
- Cleanup of various double calls and simplified code where possible.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-16 07:43:44 -07:00
TrueUO
105cde79e0
Bug Fixes (#4847)
- Dryad Allured creatures now delete correctly when released.
- Addons can no longer be placed on front steps per production.
- Fixed an issue with some of the newer stairs in house customization.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 15:23:52 -07:00
TrueUO
262c273723
Cleanup (#4846)
- No code changes in this branch. This is simply clean up.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 08:15:23 -07:00
TrueUO
6beef4c3d1
Bug Fixes (#4845)
- Fixes a crash with the Maze of Death
- Various addon placement improvements.
- Various fixes for galleons and their addons remaining in proper locations when using a plotted course.
- Added in the various missing new Keep and Castle designs.
- Removed a few depreciated files.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-14 15:51:04 -07:00
TrueUO
2d074dfe0a
Bug Fixes (#4844)
- Fixes crash with Exploring The Deep Peerless Encounter.
(may need to re-gen on existing shards)

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-11 19:11:11 -07:00
TrueUO
7b33cfc710
Fixes (#4825)
- fixes issue where you could still use teleporters and moongates while completing trade orders
- Exploding Tar Potions now work correctly.
- Added logging to Auctions.
- Can't sell items in locked containers.
- Explode potions no longer follow mobiles.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-09 19:25:04 -07:00
TrueUO
45d80710d3 Fix
- Fixes an exploit with vendor rentals.
- Added Spring Deco Collection.
2020-07-28 00:20:19 +03:00
TrueUO
8067c1bbcf
Additions (#4813)
- Account vaults have been added.
- Added in new aquariums.
- All missing recipes have been added.

Bug Fixes
- Fixes an exploit with mail boxes.
- Auction Safes now work correctly in regards to bid / match bid.
- Cleanup

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-14 09:54:52 -07:00
VitaNex
3ddcedd945 BaseGalleon retroactive serialization fix for shards upgrading from versions 4 or lower. 2020-06-27 07:49:43 -04:00
TrueUO
05f0d7cbfe
Bug Fixes (#4796)
- Bone Crusher should now work properly.
- Scrappers should now have a chance to add 3 properties at 120 magery
- Players can now heal Vollem's from the crystal (CuB bought) with bandages
- Fixed snow tree/trunk id's and z offset
- Dagger from Fabrizio quest should now deleted when quest is Complete
- Fixed exploit with auto-stabling pets. Basically, added a stable count check for auto stable
- Luck can now be inc/dec by 1 for imbuing (10 for loot)
- Cleanup of various unneeded variables or preaos checks.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-06-22 08:57:10 -07:00
TrueUO
1b8e5d723b
Cleanup (#4795)
- Various code removed that was using checks we no longer need.
- Required a core re-compile.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-06-16 13:23:30 -07:00
TrueUO
f1ecd0b168
Bug Fixes (#4793)
- FruitTrees now spawn and hold their fruit correctly.
- Mantle of the Fallen can now be repaired correctly.
- Caddellite property is now properly applied to the Treasures of Khaldun reward items.
- Bonsai seeds now display correctly inside the seed box.
- House Deeds have been removed.
- Old houseKey code was removed.
- Khal Ankur now always gives the 4 120 powerscrolls, 8 if using Justice, if killed while the Treasures of Khaldun event is active.
- Dread Warhorse now does its cosmetic "trick" ability.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-06-09 07:50:59 -07:00
TrueUO
470f62cdba Bug Fixes
- Fixed an issue where certain special loot items were getting magical properties when they shouldn't.
- Fixed an issue with the Khaldun pit teleporter working correctly in Trammel.
- Fixed a crash related to Osiredon.
- Formula adjustments to the Death Strike and White Tiger Form spells.
- Turned back on GC.
2020-06-06 07:42:41 -04:00
TrueUO
a010421b05 Bug Fixes
added square goza mats
Corgul now drops scrolls of transcendence
Corgul spawn now has a chance to drop SOT's
Dark Guardians now drop level 1or2 treasure maps
fixed issue with Ultima Store search
cloth bought from weavers now give the proper itemid
stacked items now limited to 17, per EA (was 20)
Treasures of Khaldun and Treasures of Doom should now function correctly.
2020-05-23 12:59:22 -04:00
TrueUO
80e0d42d33
Bug Fixes (#4782)
- Whirlwind Attack now does the correct amount of damage.
- Added in new Aqaurium system, with new catchable fish. https://uo.com/wiki/ultima-online-wiki/gameplay/aquariums/
- Fixed an issue where players could get a weird client crash, and be unable to log back in right away, when fighting Beacons.
- Fixed an exploit with RunicReforging. Recommend updating to newest Reforging code.
- Fixed an issue where item stats from equipment sets were not adding their values correctly on Mannequins.
- Fixed an issue where you sometimes had to exit and re-enter a house to get all the items the load correctly.
- Players can now correctly craft Charybdis bait.
- All scale types can now correctly be turned in to community collection Mobiles.cs
- Thieve Consumables from the Monster Stealing system now all work correctly.
- Some more file structure cleanup.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-16 15:31:52 -07:00
TrueUO
a99dec6807
Changes (#4781)
All loot pack items are now generated when the mobile is killed.

Reworked monster stealing and begging.

Various re-structuring and bug fixes.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-13 07:58:04 -07:00
TrueUO
af14d351da
Changes/Fixes (#4773)
Replaced standard create world teleporter items with regions.
Fixed an exploit with the Huntmaster.
MessageInABottle uses the new ItemID.
Various boat clean up and command fixes.
Fixed a crash that could result when t-hunting and a guardian is blocked from spawning.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-04 07:51:02 -07:00
TrueUO
4ed27e117f
Fixes an issue where bards could not use their abilities when calmed. (#4766)
Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-04-22 11:40:20 -07:00
TrueUO
f608d123a4
Bug Fixes (#4762)
-Fixed issue where client helpers could bypass the container gump and add items directly to the seed box
-SearedFireAntGoo is no longer stackable
-Blue NPC's (mainly vendors, not initial innocent) can no longer be attacked on trammel maps
-Aggressors/Aggressed from pet masters now works properly. This was suspected to crated large numbers to redundant aggressor/aggressed added to a mobiles aggressor/aggressed lists
-Aggressive action for healing a mobile while fighting another mobile has been re-enabled
-AuraDamage is now a harmful act, ie those affected will aggro on your pet!
-MLDryads should no longer attack other wild creatures during Blackthorn Invasion Instance
-More code cleanup
2020-04-21 17:25:24 -07:00
TrueUO
e78c0795a9 Books now once again work correctly in the CC and EC.
Travesty now uses the proper weapon specials. Specials when in natual form have also been toned down
Controlled creatures no longer lose focus when attacking on kill/attack control order
Temporarily removed looting rights for healing as this is suspected in causing a shard lockup. It will either be refactored or investigated further
Fixed issue where boat courses were not working properly and the tillerman was piloting the boat in the wrong DirectionL
Boat course no longer works in the corgul region
Corgul Island map now indicates when the encounter will Expire
Simplified code used to determine if an item or subclass of an item can be crafted
2020-04-19 13:26:24 -04:00
TrueUO
8427e1fc91 No more this.stuff 2020-04-16 18:41:32 -07:00
TrueUO
01f18a3eff A total convert of get return to => 2020-04-16 20:37:29 -04:00
TrueUO
5ba7d4dc76 Scripts folder cleanup. 2020-04-16 18:42:38 -04:00
TrueUO
1a40e06495 Removes unneeded ints from the entire project.
VS checked.

Tested and works fine.
2020-04-16 09:27:30 -04:00
TrueUO
6f1b24fc26 INT cleanup 2020-04-15 14:03:41 -04:00
TrueUO
528c0e0459 Made private fields readonly, where possible.
If a class has a field that's not marked readonly but is only set in the constructor, it could cause confusion about the field's intended use. To avoid confusion, such fields should be marked readonly to make their intended use explicit, and to prevent future maintainers from inadvertently changing their use.
2020-04-15 10:13:04 -04:00
Dexter
5e81848e63
Barkeep fix (#4725)
* Removed faction args from AcquireFocusMob in BaseAI

* Fixed issue with vendor rental contracts not unliking from house when using "retrieve" context menu
fixed pen of wisdom not deleting

* Barkeep owners re-set on house transfer
2020-04-14 12:23:14 -04:00
TrueUO
b289d6f679
VS cleanup of using in the Multi folder. (#4724)
Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-04-14 09:05:00 -07:00
TrueUO
21c1e75472
Escortable Cleanup (#4707)
* This removed the outdated pre-ML Escortables.

All these Escortables had two versions and the 2nd version still exists in Quests/Escortables.

All spawn files have been upgraded for new shards.

Existing shards will have to update their existing spawners. Just clean up the ones that appear in the badspawn log.

* Dark Wisp fix.
2020-04-12 12:09:40 -07:00
Dexter
0c4f9ec95f
Vendor deed fix (#4704)
* Removed faction args from AcquireFocusMob in BaseAI

* Fixed issue with vendor rental contracts not unliking from house when using "retrieve" context menu
fixed pen of wisdom not deleting

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-04-12 00:56:13 -04:00
TrueUO
d8592ea02a
Removes the restrictions on the Crystal Cave in Malas. (Old event are… (#4679)
* Removes the restrictions on the Crystal Cave in Malas. (Old event area no longer used and removed)

* More cleanup.

* House => conversion
2020-04-06 15:17:32 -07:00
Argalep
3ba7d541e5
Update HouseFoundation.cs (#4675) 2020-04-05 21:30:32 -04:00
Dexter
af1e785b78
Revert "Revert "- remove all old OnSingleClick functions (#4660)" (#4661)" (#4662)
This reverts commit 43ebeabc20.
2020-04-02 13:59:24 -04:00
Dexter
43ebeabc20
Revert "- remove all old OnSingleClick functions (#4660)" (#4661)
This reverts commit 69442afc1b.
2020-04-02 13:13:23 -04:00
Argalep
69442afc1b
- remove all old OnSingleClick functions (#4660) 2020-04-02 10:22:26 -04:00
TrueUO
a6605a4a64
Removes unused FacetGump.cs (#4648)
* Removes unused FacetGump.cs

* HouseGumpAOS renamed to HouseGump
2020-03-31 16:08:55 -04:00
Dexter
69cbd8db36
Removed Era Checks from multiple files (#4635)
* Removed faction args from AcquireFocusMob in BaseAI

* Removed Pre-AOS properties from BaseArmor

* Cleanup BaseClothing and PlayerMobile (removed era checks)

* Removed old Opposition Group, replaced by Tribe. UPdated BaseCreature

* Spell Cleanup

* Cleanued up Loot.cs, Lootpack.cs

* Removed Era Checks from multiple files

* removed old tmap config
2020-03-28 22:48:55 +03:00
TrueUO
ec2f0528f0
RegenRate cleanup. Please double check all formula merges to ensure t… (#4616)
* RegenRate cleanup. Please double check all formula merges to ensure they have been done correctly.

* Removed the older house menu.

* Guildstone not needed or used.
2020-03-24 22:02:05 -07:00
Dexter
ac8b30bde9
Remove Factions (#4612) 2020-03-24 19:05:36 -04:00