Commit graph

183 commits

Author SHA1 Message Date
pyro17
bebc100d6c
Ranger Equipment fix, Additem delete (#5012)
* Ranger Equipment fix, Additem delete
- add parameter with default value to AddItem
- On Conflict, still log conflict, but delete the conflicting Item by default

- Delete the base boots of Rangers befor adding the new boots

* Updated Mobile Scripts

- went through all scripts to update them to SetWearable
- reverted change to AddItem

* Update to SetWearable

- last item being set will be worn (if no override to OnEquip returns false
- delete the item on the layer that is the same as the new item (if existend)
- used ifs to cap item.Movable, therefor no need to call to Random if <= 0 or >= 1

* Update base InitOutFit

- replaced the Additem for Backpack with SetWearable, Movable is getting set this way too
- altered the other SetWearable calls, to allow the items to be moved / dropped (as they should normally)

* Null reference sanity check.

Co-authored-by: Voxpire <admin@vita-nex.com>
2022-06-16 04:44:54 +01:00
Dan
7aadd4796c Bug Fixes
- Safely removed depreciated quests.
- Fixed an exploit where AutoLoot own corpse should only auto loot items that were in there when killed. (prevents people from dropping items in a corpse to get them auto looted)
- Animals with instruments will no longer drop them to the world OnDrop OnRelease.
- Fixed a crash with the City Election system when it has multiple people running.
2020-12-06 00:02:27 +03:00
TrueUO
1c7f53a414
OCT17 (#4887)
* OCT17

Minor gump cleanup and XML cleanup.

* Improvements

- Skill Gain is no longer redundantly checked against the same values inside of XMLSpawner.
- AI_Animal (which was not used and just defaulted to AI_Melee) along with AI_Beserk, AI_Predator, and AI_Thief have been safely removed.
- ItemFlags.cs has been moved from XMLSpawner to MISC.
- Removed some misc double calls.

* Needed for recent AI fix.

* Item Fix
2020-10-21 10:15:47 -07:00
TrueUO
e54723ab05
Fixes (#4885)
- Kotl Black Rod now retains its correct color oncraft.
- Removed old/unreachable code in Polymorph.cs (pre aos methods)
- Spawner Cleanup.
- Removal of redundant calls.
2020-10-15 11:26:12 -07:00
TrueUO
550ff0e207
Restructure (#4875)
- Removed the Expansion folder in Services.
- Put everything that was in that folder in its appropriate location.

NO FILES WERE ACTUALLY CHANGED IN THIS PR - SIMPLY MOVED.
2020-10-04 09:12:11 -07:00
TrueUO
df528a25ae
Changes (#4867)
- Allows quests to be removed safely.
2020-09-29 09:39:45 -07:00
TrueUO
4987b5ecb1
- Revert recent changes to Assistants. (#4855)
* - Revert recent changes to Assistants.
- Ship painting was giving the wrong charge.
- Renamed TreasureChestMod to DungeonChest.cs

* Assistant edit

* Update BaseDungeonChest.cs

* Update BaseDungeonChest.cs

Reverted back.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-22 12:53:20 -07:00
TrueUO
fb1802305f Bug Fixes
- Removed unneeded usings
- World chat log now has a Config option. Turned off by default now.
- Added two new timer priorities.
- Fixed a crash with box of ropes.
- Consolidation of the Pathing movements and algorithms.
- Correctly makes sure you are inside the house you are trying to place addons in.
2020-09-21 09:53:44 -04:00
TrueUO
98d111ae35 Cleanup
- Last of the yearly "cleanup" pushes.
2020-09-18 10:59:33 -04:00
TrueUO
b73897e554
Cleanup (#4848)
- Cleanup of various double calls and simplified code where possible.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-16 07:43:44 -07:00
TrueUO
262c273723
Cleanup (#4846)
- No code changes in this branch. This is simply clean up.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 08:15:23 -07:00
TrueUO
8e0544a0aa
Cleanup (#4841)
- Removed unneeded usings
- Added recompile support for [restart <true> and console commands (save recompile, nosave recompile)

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-07 21:33:30 -07:00
TrueUO
6ef1e31f12
Bug Fixes (#4837)
- Fixed the loot intensity values for DCI and HCI.
- Changed how the exodus dungeon and key getting works.
- Various quest fixes.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-31 17:54:54 -07:00
TrueUO
afb62a58b2
Fixes (#4823)
Fixed an exploit with Hawkwinds quest for skill masteries where players could claim an almost unlimited amount.
Fixed an issue where Rentals, when expired correctly, were depositing too much gold.
Fixed a few notority issues with hiding / felucca / ally

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-30 14:39:58 -07:00
TrueUO
f2e8033ef1 Bug Fixes
Orchard apples can now be eaten by pets (that eat apples)
Per EA, added action delay per each item for EC equip macro
Fixed crash for shadowguard
Fixed issue where shadowguard would get hung up
Players can now use detect hidden (not passive) on blues in fel
consolidated ItemSocket expire timers in one static timer
Mastery spells will now bypass mana check to expire
Fixed issue where shadowguard apple was hanging up encounter after server restart
Fixed issue where creatures weren't regenerating stats if they were below 100
2020-07-20 16:14:45 +03:00
TrueUO
05f0d7cbfe
Bug Fixes (#4796)
- Bone Crusher should now work properly.
- Scrappers should now have a chance to add 3 properties at 120 magery
- Players can now heal Vollem's from the crystal (CuB bought) with bandages
- Fixed snow tree/trunk id's and z offset
- Dagger from Fabrizio quest should now deleted when quest is Complete
- Fixed exploit with auto-stabling pets. Basically, added a stable count check for auto stable
- Luck can now be inc/dec by 1 for imbuing (10 for loot)
- Cleanup of various unneeded variables or preaos checks.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-06-22 08:57:10 -07:00
TrueUO
80e0d42d33
Bug Fixes (#4782)
- Whirlwind Attack now does the correct amount of damage.
- Added in new Aqaurium system, with new catchable fish. https://uo.com/wiki/ultima-online-wiki/gameplay/aquariums/
- Fixed an issue where players could get a weird client crash, and be unable to log back in right away, when fighting Beacons.
- Fixed an exploit with RunicReforging. Recommend updating to newest Reforging code.
- Fixed an issue where item stats from equipment sets were not adding their values correctly on Mannequins.
- Fixed an issue where you sometimes had to exit and re-enter a house to get all the items the load correctly.
- Players can now correctly craft Charybdis bait.
- All scale types can now correctly be turned in to community collection Mobiles.cs
- Thieve Consumables from the Monster Stealing system now all work correctly.
- Some more file structure cleanup.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-16 15:31:52 -07:00
TrueUO
a99dec6807
Changes (#4781)
All loot pack items are now generated when the mobile is killed.

Reworked monster stealing and begging.

Various re-structuring and bug fixes.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-13 07:58:04 -07:00
TrueUO
8b8519dba4
Bug Fixes (#4767)
Added removed mobiles to Spawner Persistence to remove them from spawners.
Re-Added harful effects for aura effect, reduced range to 3.
Various code cleanup.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-04-23 21:02:21 -07:00
TrueUO
f608d123a4
Bug Fixes (#4762)
-Fixed issue where client helpers could bypass the container gump and add items directly to the seed box
-SearedFireAntGoo is no longer stackable
-Blue NPC's (mainly vendors, not initial innocent) can no longer be attacked on trammel maps
-Aggressors/Aggressed from pet masters now works properly. This was suspected to crated large numbers to redundant aggressor/aggressed added to a mobiles aggressor/aggressed lists
-Aggressive action for healing a mobile while fighting another mobile has been re-enabled
-AuraDamage is now a harmful act, ie those affected will aggro on your pet!
-MLDryads should no longer attack other wild creatures during Blackthorn Invasion Instance
-More code cleanup
2020-04-21 17:25:24 -07:00
TrueUO
65ea32264b
Imbue fix. (#4761)
Various Cleanup
2020-04-20 10:09:58 -07:00
TrueUO
8427e1fc91 No more this.stuff 2020-04-16 18:41:32 -07:00
TrueUO
01f18a3eff A total convert of get return to => 2020-04-16 20:37:29 -04:00
TrueUO
5ba7d4dc76 Scripts folder cleanup. 2020-04-16 18:42:38 -04:00
TrueUO
1a40e06495 Removes unneeded ints from the entire project.
VS checked.

Tested and works fine.
2020-04-16 09:27:30 -04:00
TrueUO
528c0e0459 Made private fields readonly, where possible.
If a class has a field that's not marked readonly but is only set in the constructor, it could cause confusion about the field's intended use. To avoid confusion, such fields should be marked readonly to make their intended use explicit, and to prevent future maintainers from inadvertently changing their use.
2020-04-15 10:13:04 -04:00
TrueUO
34c6eb0a95
using. quest cleanup / regions / xmlspawner (#4726) 2020-04-14 12:32:03 -04:00
TrueUO
3bd4fdc266
LayerConflict fix - cleanup of Escortables. (#4722) 2020-04-14 08:08:52 -07:00
TrueUO
479d17bdda
LayerConflict (#4714)
Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-04-13 17:01:45 -04:00
TrueUO
c96b21c4f8
Removes chaos/order guild system shield guards. (#4681)
* Removes chaos/order guild system shield guards.

* Fixes Hawkwind. Uses the TimeLord body value.
2020-04-06 16:32:31 -07:00
Dexter
5318f48aa9
Bug fixes (#4644)
* Removed faction args from AcquireFocusMob in BaseAI

* Removed Pre-AOS properties from BaseArmor

* Cleanup BaseClothing and PlayerMobile (removed era checks)

* Removed old Opposition Group, replaced by Tribe. UPdated BaseCreature

* Spell Cleanup

* Cleanued up Loot.cs, Lootpack.cs

* Removed Era Checks from multiple files

* removed old tmap config

* Bug Fixes
- Added Bag of Gold, Bag of Gems, and Bag of Regs to TMap contents
- Honor now updates perfect % property when perfection is achieved
- Remove Trap now gains property on gm made traps
- Nether Blast and Nether Cyclone now will combat flag caster on the mobile damaged

* Fixed issue where certain properties weren't applying to name prefix/suffix themed items.

* Bug Fixes
- Fixed issue where alchemy special scrolls couldn't be dropped from special scroll books
- Removed Bad Spawn from Spawners
- Cora can now be counted as a kill in A Forced Sacrafice Quest
- Removed IsSoulBound from serialization in BaseCreature
- Fixed issue where Mysterious Potion wasn't working on Cora's mana Attack
2020-03-30 23:15:10 -04:00
Dexter
69cbd8db36
Removed Era Checks from multiple files (#4635)
* Removed faction args from AcquireFocusMob in BaseAI

* Removed Pre-AOS properties from BaseArmor

* Cleanup BaseClothing and PlayerMobile (removed era checks)

* Removed old Opposition Group, replaced by Tribe. UPdated BaseCreature

* Spell Cleanup

* Cleanued up Loot.cs, Lootpack.cs

* Removed Era Checks from multiple files

* removed old tmap config
2020-03-28 22:48:55 +03:00
Dexter
ac8b30bde9
Remove Factions (#4612) 2020-03-24 19:05:36 -04:00
TrueUO
e5a4078a27
Dan2 (#4609)
* This removes the remaining unused Quests that use locations no longer used on EA.
DarkTides
EminosUndertaking

* Removed the "OldDespise" spawn file. Consolidated the other folders.

* Minor edits

* Cleanup

* Minor updates.

* Update Scripts.csproj

Updated DreamWraith.cs name.

Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-03-24 11:22:28 -04:00
TrueUO
1475511fd5
DO NOT COMMIT UNTIL LAST RELEASE IS COMPILED (#4606)
* DO NOT COMMIT UNTIL LAST RELEASE IS COMPILED

FOR REVIEW ONLY RIGHT NOW.

Removes the unused Ethics system.

* Removed the outdated Uzeraan Turmoil quest chain. (Used Old Haven, now destroyed)

This safely "disables" it. These quests are Ser/Deser within the old quest system so we can find a way to remove them all at once.

There are 3 more I will break down to this level.
2020-03-24 00:30:31 -04:00
Dexter
0189230576
Forgotten treasures (#4580)
* - Internal Galleon Update: Galleon Facing now  uses the Multi Component List to change the ID's of fixtures. Some of the ID's (weapon pads) were not using the correct ID's, and this way the code is much more simplified. All fixture lists have been consolidated into one list.
- Gargish Jewels no longer drop on non-SA Core
- Fixed issue with trapped boxes
- Added Event Sink for sending detailed house foundation packet.
- Fixed issue where imbued jewelry weren't getting durability.

* update solution
fixed graphical issue

* Bug Fixes
- Added Blackthorne DUngeon stealables
- Added proper base resists to Leather Ninja Hood
- Medusa now drops Medusa Floor Tile Addon Deed (THANKS MILVA!)
- AOSWeaponAttributes now work on Armor
- Protection now expires after player death
- Fixed crash in PVP Arena Gumps
- Exceptional Damage Inc no longer gives extra points for Clean up Britannia Turn In
- Fixed Loyalty Gump Crash
- Fixed Stygian Dragon arty drops per EA

* Potential Crash Fix

* csproj update

* Fixed conflict issue... WTF?

* Bug Fixes *Requires Core Recompile*
- Fixed cliloc on new belt craftables
- failed craft no longer deletes crimson cincture and luck mempo
- Added a core edit to Container.cs (had to do it folks) for better resource evaluation when considering resources to consume while crafting. In this instance, we don't want VvV or Faction items being used as craftable resources due to thier ease of obtaining.
- Consolidated no-delete resources in CraftSystem.cs
- Fellowship Data now serializes to prevent generation at each server start

* Resolve Conflicts

* Bug Fixes
- Shield bash forumula no more EA like (still not perfect)
- Healers now show to dead players (needs work)
- Honor buff now persists through death
-

* crash fix

* Initial Commit - Publish 105 Forgotten Treasures
- Removed Remove trap skill prerequisites

* Moongate Fix
- You have to be 1 tile to double click it. All other range checks are correct.

* Commit #2

* crash fix

* Commit #3

* Crash Fix

* Commit #3

* More updates and additions. Compiles!

* Final Commit

* Project Update

* Shields no longer engraveable w/ armor engraving tool.
2020-03-11 09:38:28 -04:00
Dexter
c3d003134d
Bug fixes (#4568)
* - Internal Galleon Update: Galleon Facing now  uses the Multi Component List to change the ID's of fixtures. Some of the ID's (weapon pads) were not using the correct ID's, and this way the code is much more simplified. All fixture lists have been consolidated into one list.
- Gargish Jewels no longer drop on non-SA Core
- Fixed issue with trapped boxes
- Added Event Sink for sending detailed house foundation packet.
- Fixed issue where imbued jewelry weren't getting durability.

* update solution
fixed graphical issue

* Bug Fixes
- Added Blackthorne DUngeon stealables
- Added proper base resists to Leather Ninja Hood
- Medusa now drops Medusa Floor Tile Addon Deed (THANKS MILVA!)
- AOSWeaponAttributes now work on Armor
- Protection now expires after player death
- Fixed crash in PVP Arena Gumps
- Exceptional Damage Inc no longer gives extra points for Clean up Britannia Turn In
- Fixed Loyalty Gump Crash
- Fixed Stygian Dragon arty drops per EA

* Potential Crash Fix

* csproj update

* Fixed conflict issue... WTF?

* Bug Fixes *Requires Core Recompile*
- Fixed cliloc on new belt craftables
- failed craft no longer deletes crimson cincture and luck mempo
- Added a core edit to Container.cs (had to do it folks) for better resource evaluation when considering resources to consume while crafting. In this instance, we don't want VvV or Faction items being used as craftable resources due to thier ease of obtaining.
- Consolidated no-delete resources in CraftSystem.cs
- Fellowship Data now serializes to prevent generation at each server start

* Resolve Conflicts

* Bug Fixes
- Shield bash forumula no more EA like (still not perfect)
- Healers now show to dead players (needs work)
- Honor buff now persists through death
-

* crash fix
2020-02-26 11:42:34 -05:00
Dexter
59d0134f22 -Fixed tiger rug Hue
-Fixed facet on vendor search gump
2019-07-16 21:14:42 -07:00
Dexter
f4dda5aee7 Bug Fixes
- Cu Sidhe stats are reduced properly after Tame

Moved the following BaseCreature Overrides to Special moves and area effects:
-True Fear
-Damage Auras
-Life Drain (succubus type)
-Colossal Blow
-Colossal Rage
2019-07-12 18:50:16 -07:00
Dexter
5b2a4926ac Bug Fixes
Changed "armorer" to "armourer" per EA.
Plague Beast lord now uses poison spit ability

Enhancements:
consolidated dragon breath/area poison data in the respective SpecialAbility/AreaEffect Class
2019-07-08 16:35:07 -07:00
Dexter
e0b508e409 Bug Fixes
- Tiered Quests [http://www.uoguide.com/Tier_Quests] now work per EA
- Updated Museum Reward bags and Percolem Reward backpacks per EA.
- Added Ter Mur Quests Reward Books
- Fixed issue where leather wasn't being moved to players backpack when skinned with Harvester's Blade
- Fixed issue where auction claim period would reset after a server Restart
- Pet training gains should now be more in line with EA
- Cleanup Britannia now accepts armor/weapons/shields/jewels. Points given per item resource is in line with EA. Points given for item power (loot) is probably as close as we're going to get
-

Behind the Scenes:
- Mondains Quests no longer serialize/deserialize through PlayerMobile. The system now utilizes its own Persistence for this
- Added a feature (disabled by default) to archive saves on your computer. See config under AutoSave.cfg how to enabled this
2019-07-06 11:18:00 -07:00
Dexter
293d4d5cf8 Bug Fixes
- Added missing banners to banner deed
- Fixed Huntmaster trophy names
- Huntmaster trophies (ones that are only 1 piece) no longer come in deed form, per EA. Any and all deeds will be converted to the Trophy
- Added durability to Virute Shield
- Paroxysmus Swampy now has proper name
- Removed conflict from Merchange Escortable
- Gaining city loyalty no longer gains hate/neutrality in other Cities
- Pet training option now appears, even if the player will not be able to control the creature. It will simply fail and give a message when they commit to train, per EA
- Added direct damage to Word of Death while inside the damage threshold
2019-05-19 09:51:33 -07:00
Dexter
e4797ae691
Merge pull request #313 from ServUO/master
merge w/ upstream
2019-04-14 07:58:03 -07:00
Dexter
a1448036c8 Fixed underworld teleporters
escortables no longer offer escorts to the city they are currently in.
2019-04-13 22:56:34 -07:00
Dexter
99e54de0af Krampus Encoutner Initial Commit 2019-04-08 17:46:01 -07:00
Dexter
7fd24f7165 Ritual Quest Line Initial Commit 2019-04-06 07:43:48 -07:00
Dexter
0a9dfdb52d Crash Fix
- Fixed issue where constellations were not showing up
- Rare tinker recipe's now drop properly
2019-04-03 20:19:57 -07:00
Dexter
0c1385a05a Additions:
Astronomy https://uo.com/wiki/ultima-online-wiki/gameplay/astronomy/

Don't forget to configure the dates for the AnniversaryGiver21st in AnniversaryGiver21st.cs. The date set needs to be AFTER the current date to ensure each player gets a gift.

Bug Fixes
- Fixed an issue where certain addons were not being created properly in world decorate. Next server start will replace addons that were deleted
- Aegis of Grace (circlet version) is now meddable
- Flesh Ripper now has Mage Slayer, per EA
- Sand is now stackable and supports int32 constructor Arg
- City Trade Deals that increase stats not work properly
- Createing characters in Enhanced Client now gives the proper starting stats and skills
- Removed invalid FacialHairItemID from Garamon
- Fixed NAN error when calculating MinTameChance when skill was set to zero
- Tiger Cub now takes damage from their Master
- Tiger Cub Statuette can now only be used once. Until this is verified on EA, this will eb how it remains
- Tiger Cubs can now be trained up to 3 slots
- Added EOWMU (Spelling?) to pet training table. It will be like all other vanity pets.
- Remove Trap now has a skill variance of 10 (used to be 30) for skill gains, per EA
2019-04-03 12:25:34 -07:00
Dexter
c223e8276a Bug Fixes
- Conflag potions now do effects in houses
- Fixed message for Cuffs of the Archmage failed Craft
- fixed (hopefully) virtuabane Crash
- Inferno now drops 25% total fire Resist
- Fixed issue where special imbuable items couldnt be imbued

Additions:
Added several event sinks that could help shard owners:
- SkillCapChangeEventHandler
- StatCapChangeEventHandler
- QuestCompleteEventHandler (supports ML quests and old quest system)
2019-03-15 21:50:39 -07:00
Dexter
3ba63a229d Bug Fixes
- VvV now appears after player name in guild roster (guild gump)
- Changed Type Name for ScrollofAlacrity to ScrollOfAlacrity
- Changed Type Name for ScrollofTranscendence to ScrollOfTranscendence
- Removed unused code from BaseExplosionPotion. It now uses LOS for hitting targets
- TerMurStyleChair now retains resource hue when crafted
- Players no longer become reveales when their pet performs various actions. They only get revealed when they give commands via context menu and typed commands
- Locked container contents no longer show on Item Insurance Menu
- TRex no longer flees
- Detect Hidden Spell no longer reveals blues in tram, it now follows same rules as the skill

Updated Body Table with new wearables
2019-03-10 22:24:13 -07:00