Commit graph

119 commits

Author SHA1 Message Date
pyro17
bebc100d6c
Ranger Equipment fix, Additem delete (#5012)
* Ranger Equipment fix, Additem delete
- add parameter with default value to AddItem
- On Conflict, still log conflict, but delete the conflicting Item by default

- Delete the base boots of Rangers befor adding the new boots

* Updated Mobile Scripts

- went through all scripts to update them to SetWearable
- reverted change to AddItem

* Update to SetWearable

- last item being set will be worn (if no override to OnEquip returns false
- delete the item on the layer that is the same as the new item (if existend)
- used ifs to cap item.Movable, therefor no need to call to Random if <= 0 or >= 1

* Update base InitOutFit

- replaced the Additem for Backpack with SetWearable, Movable is getting set this way too
- altered the other SetWearable calls, to allow the items to be moved / dropped (as they should normally)

* Null reference sanity check.

Co-authored-by: Voxpire <admin@vita-nex.com>
2022-06-16 04:44:54 +01:00
TrueUO
21ce1dd042
Changes (#4878)
* Changes

- More timer registry conversions.
- Cleanup of un-needed code.

* Change
2020-10-06 07:44:17 -07:00
TrueUO
d8670d7150
Changes (#4872)
Added stam/hits/mana regen timers to registry. Players and creatures will have their own timers to reduce any timer drift for players.
Moved TimerRegistry.cs to Server folder
Fixed issue where champ spawns weren't generating after they were deleted
Fixed issue where champ spawn corpses weren't deleting after 1 minute
Added timer object threshold where if met, a new timer will be created. This will prevent timers from processing potentially large lists causing server hangups.
removed huge memory leaks of un-needed timers firing during mobile creation and deserialization
Corpse decay times are now controlled by the mobile
2020-10-02 12:50:37 -07:00
TrueUO
4987b5ecb1
- Revert recent changes to Assistants. (#4855)
* - Revert recent changes to Assistants.
- Ship painting was giving the wrong charge.
- Renamed TreasureChestMod to DungeonChest.cs

* Assistant edit

* Update BaseDungeonChest.cs

* Update BaseDungeonChest.cs

Reverted back.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-22 12:53:20 -07:00
TrueUO
98d111ae35 Cleanup
- Last of the yearly "cleanup" pushes.
2020-09-18 10:59:33 -04:00
TrueUO
b73897e554
Cleanup (#4848)
- Cleanup of various double calls and simplified code where possible.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-16 07:43:44 -07:00
TrueUO
262c273723
Cleanup (#4846)
- No code changes in this branch. This is simply clean up.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 08:15:23 -07:00
TrueUO
a18e34074c
Additions (#4843)
- Adds in the Anvil of Artifacts https://uo.com/wiki/ultima-online-wiki/items/ultima-store-inventory/anvil-of-artifacts/
- Fixed an issue with the WinchAssembly not working correctly to access the Shadowlord peerless.
- Magic Reflect now lowers max physical resist correctly.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-10 08:59:30 -07:00
TrueUO
8e0544a0aa
Cleanup (#4841)
- Removed unneeded usings
- Added recompile support for [restart <true> and console commands (save recompile, nosave recompile)

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-07 21:33:30 -07:00
TrueUO
e2dd8b44dd
Change (#4840)
Converted Winch Assembly to peerless Altar
Converted Shadowlord to BasePeerless
Converted peerless keys to BaseDecayingItem
Server startup will require you to delete items. This if fine. It will auto re-generate deleted items.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-06 09:13:59 -07:00
TrueUO
6ef1e31f12
Bug Fixes (#4837)
- Fixed the loot intensity values for DCI and HCI.
- Changed how the exodus dungeon and key getting works.
- Various quest fixes.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-31 17:54:54 -07:00
TrueUO
eea7b596c0
Fixes (#4827)
- Fixed a rare crash that could occur with Vendor Search.
- Mysterious fragments drop in t-maps correctly now when Jolly Rogers is enabled.
- Display issue fix for various Kings Collection Items.cs
- Bola has incorrect (reversed) logic, this has been corrected.
- Various changes to make Exploding Tar Potion work per EA.
- Merchants Trinket upgraded to match EA. (Has charges now)
- Various confirmed loot tone downs on various ML named monsters.
- Fixed an exploit with Exploring the Deep quest monsters.
- Fixed various exploits with using the help menu to circumvent the Trade Order restrictions.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-18 09:08:48 -07:00
TrueUO
7b33cfc710
Fixes (#4825)
- fixes issue where you could still use teleporters and moongates while completing trade orders
- Exploding Tar Potions now work correctly.
- Added logging to Auctions.
- Can't sell items in locked containers.
- Explode potions no longer follow mobiles.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-09 19:25:04 -07:00
TrueUO
ffa594cbbb Changes
Removed CanBeWornByGargoyle, RequiredRace properties from all equipment. It is now handled in RaceDefinitions.cs and each race is responsible for validating their own equipment. It is, for the most part, done by ItemID
Consolidated various timers into one static timer: PlayerVendor, RentedVendor, FountainOfLife, Hireables
Fixed a few timer memory leaks
Clockwork leggings can now be imbued
Fixed Phylactery hue
Destard Dungeon Spawn = EA
2020-07-22 16:06:13 -04:00
TrueUO
26480ad389
Bug Fixes (#4783)
- Addons now ignore roofs (since they ignore floors if their height is > 16), as per EA.
- Blessed items will now drop as loot
- Consolidated methods for getting a random player from looting rights list
- PlunderBeacons and its spawn now give cargo, per EA
- Pirate/Merchant ships now give the proper amount of cargo during rising tides events
- Players can now sell commodities to brokers with no stock
- Mirror Image formula fix.
- Slayer Longbows can now be imbued.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-20 20:09:35 -07:00
TrueUO
a99dec6807
Changes (#4781)
All loot pack items are now generated when the mobile is killed.

Reworked monster stealing and begging.

Various re-structuring and bug fixes.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-13 07:58:04 -07:00
TrueUO
8b8519dba4
Bug Fixes (#4767)
Added removed mobiles to Spawner Persistence to remove them from spawners.
Re-Added harful effects for aura effect, reduced range to 3.
Various code cleanup.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-04-23 21:02:21 -07:00
TrueUO
f608d123a4
Bug Fixes (#4762)
-Fixed issue where client helpers could bypass the container gump and add items directly to the seed box
-SearedFireAntGoo is no longer stackable
-Blue NPC's (mainly vendors, not initial innocent) can no longer be attacked on trammel maps
-Aggressors/Aggressed from pet masters now works properly. This was suspected to crated large numbers to redundant aggressor/aggressed added to a mobiles aggressor/aggressed lists
-Aggressive action for healing a mobile while fighting another mobile has been re-enabled
-AuraDamage is now a harmful act, ie those affected will aggro on your pet!
-MLDryads should no longer attack other wild creatures during Blackthorn Invasion Instance
-More code cleanup
2020-04-21 17:25:24 -07:00
TrueUO
65ea32264b
Imbue fix. (#4761)
Various Cleanup
2020-04-20 10:09:58 -07:00
TrueUO
8427e1fc91 No more this.stuff 2020-04-16 18:41:32 -07:00
TrueUO
01f18a3eff A total convert of get return to => 2020-04-16 20:37:29 -04:00
TrueUO
5ba7d4dc76 Scripts folder cleanup. 2020-04-16 18:42:38 -04:00
TrueUO
1a40e06495 Removes unneeded ints from the entire project.
VS checked.

Tested and works fine.
2020-04-16 09:27:30 -04:00
TrueUO
528c0e0459 Made private fields readonly, where possible.
If a class has a field that's not marked readonly but is only set in the constructor, it could cause confusion about the field's intended use. To avoid confusion, such fields should be marked readonly to make their intended use explicit, and to prevent future maintainers from inadvertently changing their use.
2020-04-15 10:13:04 -04:00
TrueUO
f25e60cf56
Services Folder Cleanup (#4728) 2020-04-14 14:04:34 -04:00
TrueUO
e3c0c14d8e
Moved TyballsShadow to correct location. (#4706)
* Moved TyballsShadow to correct location.

* Forgot
2020-04-12 10:09:49 -07:00
TrueUO
29bc67a2a8
Cleaned up TC and some random mobiles. (#4700)
* Cleaned up TC and some random mobiles.

* Why did we ever hide when the world was saving and the save times from players?

* Removed BankChecks from Community Collections
2020-04-11 15:03:56 -07:00
Dexter
69cbd8db36
Removed Era Checks from multiple files (#4635)
* Removed faction args from AcquireFocusMob in BaseAI

* Removed Pre-AOS properties from BaseArmor

* Cleanup BaseClothing and PlayerMobile (removed era checks)

* Removed old Opposition Group, replaced by Tribe. UPdated BaseCreature

* Spell Cleanup

* Cleanued up Loot.cs, Lootpack.cs

* Removed Era Checks from multiple files

* removed old tmap config
2020-03-28 22:48:55 +03:00
Dexter
7442490abb
Cleanup (#4628)
* Removed faction args from AcquireFocusMob in BaseAI

* Removed Pre-AOS properties from BaseArmor

* Cleanup BaseClothing and PlayerMobile (removed era checks)

* Removed old Opposition Group, replaced by Tribe. UPdated BaseCreature
2020-03-26 18:54:34 -04:00
Dexter
f4dda5aee7 Bug Fixes
- Cu Sidhe stats are reduced properly after Tame

Moved the following BaseCreature Overrides to Special moves and area effects:
-True Fear
-Damage Auras
-Life Drain (succubus type)
-Colossal Blow
-Colossal Rage
2019-07-12 18:50:16 -07:00
Dexter
5b2a4926ac Bug Fixes
Changed "armorer" to "armourer" per EA.
Plague Beast lord now uses poison spit ability

Enhancements:
consolidated dragon breath/area poison data in the respective SpecialAbility/AreaEffect Class
2019-07-08 16:35:07 -07:00
Argalep
9ead0096d2 Underwater region fix. 2019-06-10 22:40:21 +03:00
Tasanar
601073a699 All the missing or incorrect Level 4 chests. Only 3 more levels! Will get to them this weekend. 2019-05-08 18:48:42 -04:00
Dexter
d20a7c53a5 Event System initial commit.
- Treasures of Doom Complete
- Treasures of Khaldun incomplete
- Treasures of Sorcerer's Dungeon not started
2019-02-10 09:35:03 -07:00
Argalep
95215a87c9
Update ShipBat.cs 2018-11-24 21:10:13 +03:00
Dexter
2d80cf4524 Bug Fixes
- Changed Sea Market boat restriction to 20 minutes per EA
- Exploring the deep quest now gives title if not on the town crier quest
2018-09-16 19:42:33 -07:00
Dexter
1d8d670ece Bug Fixes
- StatLossOnTame is now handled, for most creatures, in OnAfterTame. Since Pet Training, it has become more of a pain keeping up with all the different stat loss types. This way, the individual stat losses can be easier handled in the respective creatures' scripts.
- date caught now added to big fish trophy
2018-08-09 11:56:26 -07:00
Dexter
25404c3e99 Bug Fixes / Enhancements
- Added Champion Spawns to Create World. THey no longer generate automatically
- Added Exploring the Deep and Fortune Fire Casino generation to SA Decoration. For existing servers, you can use the commands [GenExploringTheDeep and [GenerateCasino respectively. Be advised, do not generate exploring the deep if it already exists, it will double spawn.
- Added paladin spawn to trinsic
- Added auto versioning to SpawnerPersistence so fresh shards are not running spawn fixes that should be addressed in the spawner folders
2018-07-11 14:28:35 -07:00
Dexter
2550743ee8 New Town Crier System
- Added non-repeatable quests
- Updated mondain quest system for flexibility in new Quests
2018-07-09 22:10:22 -07:00
Argalep
7b5d5bf3f1 * StorageLocker fix. 2018-06-19 18:22:24 +03:00
Dexter
68ba624d1d Bug Fixes
- Added Orc Pirates to Repond Slayer Group
- Refreshing houses now works for friend+ while opening doors, stepping on plot (customizable houses), and accessing the house sign
- Added Ship's Strong Box, 1/100 drop chance while fishing up SOS Chest
- Fish Trophies now re-deed to moving crate
- Poisoning ability now applies to dread spiders
- Arcane Bookshelf and Elven Dresser now crafts the correct container addon
- Peerless altar now removes pets via AllFollowers and no longer uses pet table. This will remove pets such as familiars that are casted/summomed after the encounter begins
- Detect Hidden should now work properly
- Momentum strike should now attack the proper targets. It basically uses the same rules as AOE spells
- Added Invisibility potions to potion kegs
- Fixed issue in BaseBoat where players weren't counted properly
- Added Function to BaseContainer where adding items will check for a stack (DropItemStack). Before, this was only achievable with TryDropItem, which requires a mobile to be passed in as an argument.
2018-05-19 08:41:54 -07:00
James Kidd
3e4bb3c63c Continuation of previous commit, solves #3401 and issues raised in previous PR. 2018-05-10 18:54:49 +10:00
James Kidd
79034149e1 Bunch of misc issues found using PVS-Studio 2018-05-10 05:34:40 +10:00
Dexter
20238d28d9 update 2018-03-08 17:26:02 -07:00
Dexter
9b5b02296e Revert "I dunno what im doing"
This reverts commit 714c2c7519.
2018-03-07 19:48:24 -07:00
Dexter
714c2c7519 I dunno what im doing 2018-03-07 19:46:19 -07:00
Dexter
d6c7bd534f Pet Training Initial Commit. Will not compile! 2018-03-05 20:30:00 -07:00
Argalep
719743733c * Exploring the deep Mobile fix. 2018-02-18 15:30:00 +03:00
Dexter
60036b4b99 Bug Fixes
- Fixed issue with VvV notoriety - report back!
- Guardzone/Guardwhacking should now be per EA - report back!
- Added much need IsMonster propery to BaseCreature.cs
- Added pack checks for gorgon lense
- remove durability from Blackthorn Epaulettes and Hooded robes. Do we need to do this to the dresses too?
2018-01-15 22:41:01 -07:00
Dexter
7bbbf815f5 Bug Fixes
- Moved CheckHouseLimit to BaseHouse
- Consolidated HumanBrigand into Brigand
- Removed HumanBrigandCamp, uses BrigandCamp
- fixed bug where a player would lose mastery levels if they soulstone a skill off *Requires Core Re-Compile*
- Added mastery check where active mastery is deactivated if skill level drops below 90
- Armor Ignore is now capped vs players (even from monsters)
2017-11-11 20:57:55 -07:00