Commit graph

477 commits

Author SHA1 Message Date
tr1age
f6cda56c1f
Fix Ethereal burst typo (#5053) 2023-04-30 20:35:31 +01:00
tr1age
4ce7068f34
Fix: Death Ray does not use SDI on OSI (#5049)
* Death Ray does not use SDI on OSI 

By utilizing SDI on deathray you create a very overpowered Mastery Skill. OSI does not calculate SDI into the skill they only use Magery and Eval and Mastery level.

* update: fix Deathray
2023-03-27 23:49:14 +01:00
tr1age
2207d58539
Stop from defaulting to 90 min cooldown (#5045)
It looks like the code was missing an else-if statement. The current servuo code will always set the duration to 30 if the skill is greater than or equal to 120, and then set it to 60 if the skill is greater than or equal to 100, and THEN set it to 90 if 60 regardless of whether the duration has already been set to 30. This will properly set the timer.
2023-03-13 14:52:35 +00:00
Hjornskar
6d5e5c69ff
Update SpellHelper.cs (#4998) 2022-02-28 16:12:44 +00:00
Hjornskar
65fb10a4ed
Update SpellHelper.cs (#4943) 2021-06-04 23:36:45 -07:00
LG Archer
aa84c79ae0
Fix creatures inability to execute certain skills with no mastery level (#4940)
* Fix creatures inability to execute certain skills with no mastery level

* Temporary revert

* Reinstate update
2021-05-19 15:23:10 +01:00
Dan
7aadd4796c Bug Fixes
- Safely removed depreciated quests.
- Fixed an exploit where AutoLoot own corpse should only auto loot items that were in there when killed. (prevents people from dropping items in a corpse to get them auto looted)
- Animals with instruments will no longer drop them to the world OnDrop OnRelease.
- Fixed a crash with the City Election system when it has multiple people running.
2020-12-06 00:02:27 +03:00
Dan
46998bd414 Bug Fixes
- Adds missing items to Huntmaster Reward gump
- Fixes an access issue with the Jewelry box, when turning pages.
- Travesty Mirror Images will no longer turn players criminal.
- Fixes an exploit where items could be used inside of mail boxes, even without the correct access
2020-11-27 22:52:49 +03:00
Dan
63d251645b Bug Fixes
Fixed an issue where various new potions were incorrectly able to be placed inside potion kegs.
Fixed a display issue with the Fermentation Barrel.
Fixed an issue with Vendor Search and certain vendor maps that were being created incorrectly.
Fixed an issue where a pet owner's luck was not always being calculated when determining basic loot drops.
Fixed an issue where monsters and pets could get "stuck" while casting a spell and would not cast anymore until after a restart.
2020-11-19 05:22:25 -05:00
TrueUO
e54723ab05
Fixes (#4885)
- Kotl Black Rod now retains its correct color oncraft.
- Removed old/unreachable code in Polymorph.cs (pre aos methods)
- Spawner Cleanup.
- Removal of redundant calls.
2020-10-15 11:26:12 -07:00
TrueUO
8b82bdd254
Additions (#4881)
* Additions

- Adds two missing deco mail boxes.
- Pumpkins you wish to carve must now be in your backpack.

* More changes and bug fixes.
2020-10-13 13:31:23 -07:00
TrueUO
21ce1dd042
Changes (#4878)
* Changes

- More timer registry conversions.
- Cleanup of un-needed code.

* Change
2020-10-06 07:44:17 -07:00
TrueUO
6ff5ae05df
Bug Fixes (#4873)
* Bug Fixes

Fixed crash while enabling Kotl System
Added support for invoking commands without a mobile
Bolt of CLoth is no longer flipable with housing
Fixed issue with castle ladders
Chest guardians will now get Soul Bound tag during active Event
Fixed issue where physcial resist wasnt returning to normal value when disabling magic reflect spell

* Bug Fix

- https://www.servuo.com/threads/black-rock-stew-recipe-ingredients-are-not-consumed.13056/
2020-10-03 07:09:47 -07:00
TrueUO
d8670d7150
Changes (#4872)
Added stam/hits/mana regen timers to registry. Players and creatures will have their own timers to reduce any timer drift for players.
Moved TimerRegistry.cs to Server folder
Fixed issue where champ spawns weren't generating after they were deleted
Fixed issue where champ spawn corpses weren't deleting after 1 minute
Added timer object threshold where if met, a new timer will be created. This will prevent timers from processing potentially large lists causing server hangups.
removed huge memory leaks of un-needed timers firing during mobile creation and deserialization
Corpse decay times are now controlled by the mobile
2020-10-02 12:50:37 -07:00
Dan
7b160c0784 Changes
- Not all Unsummons were correctly disposing of their timers.
- This has been fixed and all Summons are now on one static timer.
- Circuit Trap Trainging kit bug fix.
- Small cleanup.
2020-09-27 19:20:09 -04:00
TrueUO
fb1802305f Bug Fixes
- Removed unneeded usings
- World chat log now has a Config option. Turned off by default now.
- Added two new timer priorities.
- Fixed a crash with box of ropes.
- Consolidation of the Pathing movements and algorithms.
- Correctly makes sure you are inside the house you are trying to place addons in.
2020-09-21 09:53:44 -04:00
LG Archer
e3581d2a15
Updates (#4850)
Update to increase merge friendliness for shards updating to the latest codebase.
Fixed an inconsistency with PlayerMobile EquipMacro statements.
2020-09-18 23:27:35 +01:00
TrueUO
98d111ae35 Cleanup
- Last of the yearly "cleanup" pushes.
2020-09-18 10:59:33 -04:00
TrueUO
b73897e554
Cleanup (#4848)
- Cleanup of various double calls and simplified code where possible.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-16 07:43:44 -07:00
TrueUO
262c273723
Cleanup (#4846)
- No code changes in this branch. This is simply clean up.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 08:15:23 -07:00
TrueUO
2d074dfe0a
Bug Fixes (#4844)
- Fixes crash with Exploring The Deep Peerless Encounter.
(may need to re-gen on existing shards)

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-11 19:11:11 -07:00
TrueUO
a18e34074c
Additions (#4843)
- Adds in the Anvil of Artifacts https://uo.com/wiki/ultima-online-wiki/items/ultima-store-inventory/anvil-of-artifacts/
- Fixed an issue with the WinchAssembly not working correctly to access the Shadowlord peerless.
- Magic Reflect now lowers max physical resist correctly.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-10 08:59:30 -07:00
TrueUO
8e0544a0aa
Cleanup (#4841)
- Removed unneeded usings
- Added recompile support for [restart <true> and console commands (save recompile, nosave recompile)

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-07 21:33:30 -07:00
TrueUO
e2dd8b44dd
Change (#4840)
Converted Winch Assembly to peerless Altar
Converted Shadowlord to BasePeerless
Converted peerless keys to BaseDecayingItem
Server startup will require you to delete items. This if fine. It will auto re-generate deleted items.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-06 09:13:59 -07:00
TrueUO
1b76fac3a6
Bug Fixes (#4839)
Flee is now more EA like
Undead creatures no longer flee
Removed AnimalAI
Fixed dispel field so mobiles can be targeted, removed messages per EA
White Tiger Form no longer reveals on cast

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-03 11:14:32 -07:00
LG Archer
93646bc5bd
Various Fixes (#4834)
* Properly implement ICommodity.Description in CommodityDeed tooltips.

* Improve arbitrary formatting for merge compatibility.

* Fix a timer dump export error.

* Remove redundant missing file from csproj list.

* Add an overload for Gump.AddTooltip that takes a single string argument.

* Fix access level checks for VvV potions.

* Rename Server.Items.Size enum to Server.Items.ItemSize to prevent ambiguity with System.Drawing.Size.

* Add helper method for adding TextDefinitions to gumps as a tooltip.

* Collection rewards now support TextDefinition tooltips.

* Removed conflicting AddTooltip(string text)

* Fixed Compile error with new ToolTip Support.

Co-authored-by: TrueUO <staff@trueuo.com>
Co-authored-by: Dexter <kevin_bourne10@yahoo.com>
2020-08-29 10:27:44 -07:00
TrueUO
fee89ebc7e
Changes (#4826)
- All spell timers are now on one master timer. When testing with 70+ online this has lead to smoother casting when various spell casters (monsters and players) are in the same area.
- Global chat now has a forced 5 second delay per OSI.
- Trade Order Crates now except multiple "like type" items.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-12 14:10:49 -07:00
TrueUO
7b33cfc710
Fixes (#4825)
- fixes issue where you could still use teleporters and moongates while completing trade orders
- Exploding Tar Potions now work correctly.
- Added logging to Auctions.
- Can't sell items in locked containers.
- Explode potions no longer follow mobiles.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-09 19:25:04 -07:00
TrueUO
01068a1882
Fixes (#4824)
- fixed an exploit with the recipe book
- fixed an exploit where cutting up gargish cloth armor resulted in getting leather back.
- Aegis of Grace (elf id) can now be worn by humans
- Heal Potions now subject to 2 seconds heal stone timer and reduce heal amount on Heal Stone when consumed
- Gargoyle cloth armor can no longer be crafted with leather resources
- Gargoyle cloth armor will now only yield cloth when cut with scissors
- gargoyles can now wear detective credentials
- added gargish talons to gargoyle only gear
- NecroMageAI now attempts to cast Conduit
- Bulletin Boards now retain the color of the crafted resources
- Mystic/Sorcery named properties no longer have lower reg cost, per EA. Added int bonus.
- Spirit Speak now reveals the user

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-04 10:58:20 -07:00
TrueUO
afb62a58b2
Fixes (#4823)
Fixed an exploit with Hawkwinds quest for skill masteries where players could claim an almost unlimited amount.
Fixed an issue where Rentals, when expired correctly, were depositing too much gold.
Fixed a few notority issues with hiding / felucca / ally

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-30 14:39:58 -07:00
TrueUO
43ef3b7cf2
Changes (#4820)
- Shop item prices now reset at startup, per EA
- Nether Cyclone spell damage fixed
- magic reflect spell now EA like
- Vis list now persists through restarts.
- Fixed an exploit with ChickenStatue and CowStatue.cs
- Fishing poles now get luck accounted
- Restless soul is now grey
- Added proper CUB point value to tmaps
- Doom spawns are now seperated and EA accurate.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-26 18:18:34 -07:00
TrueUO
ffa594cbbb Changes
Removed CanBeWornByGargoyle, RequiredRace properties from all equipment. It is now handled in RaceDefinitions.cs and each race is responsible for validating their own equipment. It is, for the most part, done by ItemID
Consolidated various timers into one static timer: PlayerVendor, RentedVendor, FountainOfLife, Hireables
Fixed a few timer memory leaks
Clockwork leggings can now be imbued
Fixed Phylactery hue
Destard Dungeon Spawn = EA
2020-07-22 16:06:13 -04:00
TrueUO
f2e8033ef1 Bug Fixes
Orchard apples can now be eaten by pets (that eat apples)
Per EA, added action delay per each item for EC equip macro
Fixed crash for shadowguard
Fixed issue where shadowguard would get hung up
Players can now use detect hidden (not passive) on blues in fel
consolidated ItemSocket expire timers in one static timer
Mastery spells will now bypass mana check to expire
Fixed issue where shadowguard apple was hanging up encounter after server restart
Fixed issue where creatures weren't regenerating stats if they were below 100
2020-07-20 16:14:45 +03:00
TrueUO
3802b3042e
Exploit Fix (#4815)
Fixes an exploit that allowed EC, ClassicUO, Orion, Etc, clients to auto arm / drink potions / rearm with no delay.

After extensive testing 750ms is a more appropriate action delay. All of this has been moved to the core and simplified.

Various other cleanup.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-16 11:45:08 -07:00
TrueUO
30c25d52a9
Bug Fixes (#4814)
Fixed issue where dying vendor hair wasn't working
Fixed various bugs with new account Vaults
Vaults now have siege support
SOS chests should no longer delete if player is overfull
fixed gump on Shipwreck book
Fixed Spell Damage focus skills per EA
Animate dead creatures now degenerate hits properly

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-15 08:31:26 -07:00
TrueUO
75177a1cb8 Crash Fix
- Fixes a crash from Mysterious Fragments
- Fix for shield bash damage in PVP
2020-07-07 19:22:40 -04:00
TrueUO
4cd7990aaf
Hiryu Hits are now properly scaled when tamed (#4810)
Adjusted placement of niter
added captured essence to exodus steal table
fixed display cliloc for treasure maps
Fixed shield base.

Requires a core recompile.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-05 20:35:10 -07:00
TrueUO
7338084882
- Fixed field item placement and LOS for Conflag Potions (#4809)
- Fixed issue where SOS chests were not being flipped properly with the interior decorator
- increased ecru citrine ring chance for the enhance pots
- ecru citrine rings no longer get random mods, but will get str bonus if the Enhance Pots roll fails, per EA
- Slightly increased chances to fish up rare and legendary fish
- Fixed issue where zombie fish was fished up almost eveyr time in Gravewater Lake
- BaseCreatures aggressed by controlled creatures will not have the creatures master added to aggressor list. This prevents young players from using summons/pets to kill monsters and not being attacked Back
- Added new loot drops to HS bosses
- Weapon Attributes will now be properly counted on BaseClothing items
- Fixed damage from Spell Plague

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-04 21:38:23 -07:00
TrueUO
05f0d7cbfe
Bug Fixes (#4796)
- Bone Crusher should now work properly.
- Scrappers should now have a chance to add 3 properties at 120 magery
- Players can now heal Vollem's from the crystal (CuB bought) with bandages
- Fixed snow tree/trunk id's and z offset
- Dagger from Fabrizio quest should now deleted when quest is Complete
- Fixed exploit with auto-stabling pets. Basically, added a stable count check for auto stable
- Luck can now be inc/dec by 1 for imbuing (10 for loot)
- Cleanup of various unneeded variables or preaos checks.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-06-22 08:57:10 -07:00
TrueUO
470f62cdba Bug Fixes
- Fixed an issue where certain special loot items were getting magical properties when they shouldn't.
- Fixed an issue with the Khaldun pit teleporter working correctly in Trammel.
- Fixed a crash related to Osiredon.
- Formula adjustments to the Death Strike and White Tiger Form spells.
- Turned back on GC.
2020-06-06 07:42:41 -04:00
TrueUO
a010421b05 Bug Fixes
added square goza mats
Corgul now drops scrolls of transcendence
Corgul spawn now has a chance to drop SOT's
Dark Guardians now drop level 1or2 treasure maps
fixed issue with Ultima Store search
cloth bought from weavers now give the proper itemid
stacked items now limited to 17, per EA (was 20)
Treasures of Khaldun and Treasures of Doom should now function correctly.
2020-05-23 12:59:22 -04:00
TrueUO
a99dec6807
Changes (#4781)
All loot pack items are now generated when the mobile is killed.

Reworked monster stealing and begging.

Various re-structuring and bug fixes.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-05-13 07:58:04 -07:00
TrueUO
8b8519dba4
Bug Fixes (#4767)
Added removed mobiles to Spawner Persistence to remove them from spawners.
Re-Added harful effects for aura effect, reduced range to 3.
Various code cleanup.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-04-23 21:02:21 -07:00
TrueUO
f608d123a4
Bug Fixes (#4762)
-Fixed issue where client helpers could bypass the container gump and add items directly to the seed box
-SearedFireAntGoo is no longer stackable
-Blue NPC's (mainly vendors, not initial innocent) can no longer be attacked on trammel maps
-Aggressors/Aggressed from pet masters now works properly. This was suspected to crated large numbers to redundant aggressor/aggressed added to a mobiles aggressor/aggressed lists
-Aggressive action for healing a mobile while fighting another mobile has been re-enabled
-AuraDamage is now a harmful act, ie those affected will aggro on your pet!
-MLDryads should no longer attack other wild creatures during Blackthorn Invasion Instance
-More code cleanup
2020-04-21 17:25:24 -07:00
TrueUO
65ea32264b
Imbue fix. (#4761)
Various Cleanup
2020-04-20 10:09:58 -07:00
TrueUO
8427e1fc91 No more this.stuff 2020-04-16 18:41:32 -07:00
TrueUO
01f18a3eff A total convert of get return to => 2020-04-16 20:37:29 -04:00
TrueUO
5ba7d4dc76 Scripts folder cleanup. 2020-04-16 18:42:38 -04:00
TrueUO
1a40e06495 Removes unneeded ints from the entire project.
VS checked.

Tested and works fine.
2020-04-16 09:27:30 -04:00
TrueUO
528c0e0459 Made private fields readonly, where possible.
If a class has a field that's not marked readonly but is only set in the constructor, it could cause confusion about the field's intended use. To avoid confusion, such fields should be marked readonly to make their intended use explicit, and to prevent future maintainers from inadvertently changing their use.
2020-04-15 10:13:04 -04:00