Commit graph

113 commits

Author SHA1 Message Date
Hjornskar
6d5e5c69ff
Update SpellHelper.cs (#4998) 2022-02-28 16:12:44 +00:00
Hjornskar
65fb10a4ed
Update SpellHelper.cs (#4943) 2021-06-04 23:36:45 -07:00
TrueUO
d8670d7150
Changes (#4872)
Added stam/hits/mana regen timers to registry. Players and creatures will have their own timers to reduce any timer drift for players.
Moved TimerRegistry.cs to Server folder
Fixed issue where champ spawns weren't generating after they were deleted
Fixed issue where champ spawn corpses weren't deleting after 1 minute
Added timer object threshold where if met, a new timer will be created. This will prevent timers from processing potentially large lists causing server hangups.
removed huge memory leaks of un-needed timers firing during mobile creation and deserialization
Corpse decay times are now controlled by the mobile
2020-10-02 12:50:37 -07:00
TrueUO
b73897e554
Cleanup (#4848)
- Cleanup of various double calls and simplified code where possible.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-16 07:43:44 -07:00
TrueUO
262c273723
Cleanup (#4846)
- No code changes in this branch. This is simply clean up.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-09-15 08:15:23 -07:00
TrueUO
fee89ebc7e
Changes (#4826)
- All spell timers are now on one master timer. When testing with 70+ online this has lead to smoother casting when various spell casters (monsters and players) are in the same area.
- Global chat now has a forced 5 second delay per OSI.
- Trade Order Crates now except multiple "like type" items.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-12 14:10:49 -07:00
TrueUO
01068a1882
Fixes (#4824)
- fixed an exploit with the recipe book
- fixed an exploit where cutting up gargish cloth armor resulted in getting leather back.
- Aegis of Grace (elf id) can now be worn by humans
- Heal Potions now subject to 2 seconds heal stone timer and reduce heal amount on Heal Stone when consumed
- Gargoyle cloth armor can no longer be crafted with leather resources
- Gargoyle cloth armor will now only yield cloth when cut with scissors
- gargoyles can now wear detective credentials
- added gargish talons to gargoyle only gear
- NecroMageAI now attempts to cast Conduit
- Bulletin Boards now retain the color of the crafted resources
- Mystic/Sorcery named properties no longer have lower reg cost, per EA. Added int bonus.
- Spirit Speak now reveals the user

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-08-04 10:58:20 -07:00
TrueUO
afb62a58b2
Fixes (#4823)
Fixed an exploit with Hawkwinds quest for skill masteries where players could claim an almost unlimited amount.
Fixed an issue where Rentals, when expired correctly, were depositing too much gold.
Fixed a few notority issues with hiding / felucca / ally

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-30 14:39:58 -07:00
TrueUO
43ef3b7cf2
Changes (#4820)
- Shop item prices now reset at startup, per EA
- Nether Cyclone spell damage fixed
- magic reflect spell now EA like
- Vis list now persists through restarts.
- Fixed an exploit with ChickenStatue and CowStatue.cs
- Fishing poles now get luck accounted
- Restless soul is now grey
- Added proper CUB point value to tmaps
- Doom spawns are now seperated and EA accurate.

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-26 18:18:34 -07:00
TrueUO
30c25d52a9
Bug Fixes (#4814)
Fixed issue where dying vendor hair wasn't working
Fixed various bugs with new account Vaults
Vaults now have siege support
SOS chests should no longer delete if player is overfull
fixed gump on Shipwreck book
Fixed Spell Damage focus skills per EA
Animate dead creatures now degenerate hits properly

Co-authored-by: TrueUO <knight.daniel.r@gmail.com>
2020-07-15 08:31:26 -07:00
TrueUO
f608d123a4
Bug Fixes (#4762)
-Fixed issue where client helpers could bypass the container gump and add items directly to the seed box
-SearedFireAntGoo is no longer stackable
-Blue NPC's (mainly vendors, not initial innocent) can no longer be attacked on trammel maps
-Aggressors/Aggressed from pet masters now works properly. This was suspected to crated large numbers to redundant aggressor/aggressed added to a mobiles aggressor/aggressed lists
-Aggressive action for healing a mobile while fighting another mobile has been re-enabled
-AuraDamage is now a harmful act, ie those affected will aggro on your pet!
-MLDryads should no longer attack other wild creatures during Blackthorn Invasion Instance
-More code cleanup
2020-04-21 17:25:24 -07:00
TrueUO
01f18a3eff A total convert of get return to => 2020-04-16 20:37:29 -04:00
TrueUO
5ba7d4dc76 Scripts folder cleanup. 2020-04-16 18:42:38 -04:00
TrueUO
528c0e0459 Made private fields readonly, where possible.
If a class has a field that's not marked readonly but is only set in the constructor, it could cause confusion about the field's intended use. To avoid confusion, such fields should be marked readonly to make their intended use explicit, and to prevent future maintainers from inadvertently changing their use.
2020-04-15 10:13:04 -04:00
TrueUO
4fd6edbcaf
The only folders left are Items, Mobiles, and Services. (#4727) 2020-04-14 13:03:33 -04:00
TrueUO
d8592ea02a
Removes the restrictions on the Crystal Cave in Malas. (Old event are… (#4679)
* Removes the restrictions on the Crystal Cave in Malas. (Old event area no longer used and removed)

* More cleanup.

* House => conversion
2020-04-06 15:17:32 -07:00
TrueUO
8a36e13cad
Fixes region travel restrictions error. (#4634) 2020-03-27 18:03:48 -07:00
Dexter
509489dec9
Cleanup (#4630)
* Removed faction args from AcquireFocusMob in BaseAI

* Removed Pre-AOS properties from BaseArmor

* Cleanup BaseClothing and PlayerMobile (removed era checks)

* Removed old Opposition Group, replaced by Tribe. UPdated BaseCreature

* Spell Cleanup

* Cleanued up Loot.cs, Lootpack.cs
2020-03-27 02:46:30 -04:00
Dexter
ac8b30bde9
Remove Factions (#4612) 2020-03-24 19:05:36 -04:00
Dexter
0189230576
Forgotten treasures (#4580)
* - Internal Galleon Update: Galleon Facing now  uses the Multi Component List to change the ID's of fixtures. Some of the ID's (weapon pads) were not using the correct ID's, and this way the code is much more simplified. All fixture lists have been consolidated into one list.
- Gargish Jewels no longer drop on non-SA Core
- Fixed issue with trapped boxes
- Added Event Sink for sending detailed house foundation packet.
- Fixed issue where imbued jewelry weren't getting durability.

* update solution
fixed graphical issue

* Bug Fixes
- Added Blackthorne DUngeon stealables
- Added proper base resists to Leather Ninja Hood
- Medusa now drops Medusa Floor Tile Addon Deed (THANKS MILVA!)
- AOSWeaponAttributes now work on Armor
- Protection now expires after player death
- Fixed crash in PVP Arena Gumps
- Exceptional Damage Inc no longer gives extra points for Clean up Britannia Turn In
- Fixed Loyalty Gump Crash
- Fixed Stygian Dragon arty drops per EA

* Potential Crash Fix

* csproj update

* Fixed conflict issue... WTF?

* Bug Fixes *Requires Core Recompile*
- Fixed cliloc on new belt craftables
- failed craft no longer deletes crimson cincture and luck mempo
- Added a core edit to Container.cs (had to do it folks) for better resource evaluation when considering resources to consume while crafting. In this instance, we don't want VvV or Faction items being used as craftable resources due to thier ease of obtaining.
- Consolidated no-delete resources in CraftSystem.cs
- Fellowship Data now serializes to prevent generation at each server start

* Resolve Conflicts

* Bug Fixes
- Shield bash forumula no more EA like (still not perfect)
- Healers now show to dead players (needs work)
- Honor buff now persists through death
-

* crash fix

* Initial Commit - Publish 105 Forgotten Treasures
- Removed Remove trap skill prerequisites

* Moongate Fix
- You have to be 1 tile to double click it. All other range checks are correct.

* Commit #2

* crash fix

* Commit #3

* Crash Fix

* Commit #3

* More updates and additions. Compiles!

* Final Commit

* Project Update

* Shields no longer engraveable w/ armor engraving tool.
2020-03-11 09:38:28 -04:00
Vorspire
aa6e998471 + Fix an exception caused by erroneous method overload call with a null reference argument. 2019-10-20 15:33:32 +01:00
Dexter
fc8fdfe9a3 Bug Fixes
- Explosion Potions no longer use throwers LOS for Damage
- Fixed class name for "Putrefaction"
- Failed craft no longer consumes ML Peerless resources
- Vendor Searing now recursively checks child containers in vendors backpack
- Vendor Searching now shows price of parent container if the entire container is for sale
2019-06-30 16:02:37 -07:00
Dexter
f1b5180cd1 Bug Fixes
- Orc Helm now gives 3% inherent LMC
- Animal Taming Masteries can no longer be used on Despise Creatures
- Mage Armor Conversion now enabled for artifacts
- Despise Creatures now raise resists as they level up
- Despise creatures should now properly discord (those that discord)
- Enabled Damage reflection for executioners (%100) and Shadowguard pirates (37%)
- Added 0x0F Encoded packet, even though there is no use for this yet. THis will keep the packet file from being filled up
- Added City Loyalty and Trade properties to PlayerMobile Command Properties
- Shadowguard apple trees now only produce 1 apple, per EA
- Increased bump chances of Shadowguard Greater Dragon
- Added Weight propery to Hunt trophies (not item weight, but weight when hunted)
- Added proper weapon abilities to saber toohted tiger
- Stat offset for buffs/curses now use math.ceiling
- Replaced TileFlag NoDiagonal with HoverOver (proper EA Use)
- Fixed issue where LOS was returning false from stacked containers in houses with roof
2019-05-22 19:44:13 -07:00
Dexter
b08a9d99f5 Bug Fix:
Fixed issue where fire fields were not appearing on the proper surface for Stygian Dragon specials

Added various EventSinks. They currently have no use, however the intent is to ease custom code with minimizing distro code
2019-04-24 13:45:24 -07:00
Dexter
99e54de0af Krampus Encoutner Initial Commit 2019-04-08 17:46:01 -07:00
Dexter
7fd24f7165 Ritual Quest Line Initial Commit 2019-04-06 07:43:48 -07:00
Dexter
e5384662e9 New Features:
- Added Config for murderer travel restriction. Default is true. Change to false to allow reds in Trammel. They will not be able to use vendors in guardzones
- Added overrideable property in Region.cs for insurance multiplier. Set to 0 if you want no insurance cost, etc.
2019-03-23 20:50:41 -07:00
Dexter
c223e8276a Bug Fixes
- Conflag potions now do effects in houses
- Fixed message for Cuffs of the Archmage failed Craft
- fixed (hopefully) virtuabane Crash
- Inferno now drops 25% total fire Resist
- Fixed issue where special imbuable items couldnt be imbued

Additions:
Added several event sinks that could help shard owners:
- SkillCapChangeEventHandler
- StatCapChangeEventHandler
- QuestCompleteEventHandler (supports ML quests and old quest system)
2019-03-15 21:50:39 -07:00
Dexter
67d5cdd18c Bug Fixes
- Added support for furniture addons to be dyable via furniture dye tub
- Fixed Coffee Craft Fix
- Stygian Dragon special abilities should be more in line with EA
- Fixed issue with Bod Times after bod collection
- Fixed issue where lightning effect wasn't visible when player was not facing the Target
- Attune Weapon now updates buff bar when damage is absorbed
- Enemy of One no longer shows pets orange, per EA
2019-02-23 13:41:49 -07:00
Dexter
b5865c2bb5 Bug Fixes *Requires Core Re-Compile*
- Core.SA+ speeds up stamina regen rate, per EA. It used to be 24 stam per minute, is now 85 per minute. Significant increase!
- Added Wood and Stone armor to ArmorEnum MaterialType
- Added inherent stamina loss reduction, per EA (Core.SA)
- Added Core.SA to inherent lower mana cost regarding Armor
- Removed static DFAlgorithm property and added it to Mobile.cs as an instance property. This would have cause potential issues where the wrong stam loss was given out on damage
- Added public assessors to BaseTalisman killer/protection lists and RunicReforging property lists
- Added previously omitted TalismanSlayerName to Vendor Search Criteria serialization
- Fixed Casting Focus cliloc in Imbuing.cs, this was giving the wrong label in vendor search
2018-12-20 10:17:58 -07:00
Dexter
6920798e0e Removed redundant check. This was already checked. 2018-11-28 21:12:14 -07:00
Dexter
31a6ff593f More list conversion to SpellHelper.AcquireIndirectTargets
Added line to include creatures not in same team to AcquireIndirectTargets
2018-11-28 19:06:03 -07:00
Dexter
3334e679b1 Bug Fixes
- Added Era checks for cleanup britannia
- added era checks for trashcans
- Bard Mastery Spells now show/use the proper bonuses
2018-11-24 15:45:33 -07:00
Dexter
8603832787 Bug Fixes
- Added Rare armor set drops to peerless's
- Fixed conflagration potion LabelNumber
- Fixed issue where anyone could take items from a Mailbox
- Added Poppies Dust to Plant System Resource
- Flax Flowers now drop proper Resource
- Added Elemental Damage to Exquisite/Quality
- Hit Lower Defense no longer drops on Exquisite/Quality. It now drops as a random reforged property
- Fixed Hit Spell Property for Enchant Spell
2018-10-25 22:05:27 -07:00
Dexter
bc07371f70
Merge branch 'master' into BugFixes 2018-10-24 18:20:45 -07:00
Dexter
a1a7de1aae Bug Fixes
- Fixed issue where on hit weapon properties would not work
- Subsequent tames on pets will no longer reduce stats, however will reduce skills
- Fixed issue where britannian ships would not move with addons on the proper addon spots
- Fixed issue where pets were flagging other controlled pets when they shouldnt with indirect damage
- Skill Mastery spells now expire when the caster dies
2018-10-19 22:24:42 -07:00
Dexter
b241eba218
Updateds to ValidIndirectTarget
Specifically adding support for controlled creature vs controlled creature.
2018-10-19 12:24:39 -07:00
Dexter
ce95c51d06 Bug Fixes
- Fabled Fishing Nets now have a chance to spawn Osiredon.
- More indirect targeting optimizations
- Mastery Party spells now deactivate for players who leave party. If the party disbands, the spell remains for the caster/pets only.
2018-10-16 08:17:56 -07:00
Dexter
e72b1d96fb Removed Commented out lines 2018-10-14 20:56:46 -07:00
Dexter
beecaed211 Bug Fixes *Requires Core Re-Compile*
- Emptying plant bowl no longer gives empty bowl with raising garden
- Aggressor info now updates after death. Timer added so its not conflicting with other tasks.

Additions
- Added Reset() function to AggressorInfo for death. This makes sure the proper aggressor info is removed via regular means
- Moved Spell.cs AcquireIndirectTargets to static method in SpellHelper.cs so it can easily be utilized by other systems, such as BaseWeapon and FireBomb.
2018-10-14 20:54:54 -07:00
Dexter
7a1b651b3b Bug Fixes
- Fixed new Huntsman trophy id's.
- Huntsman trophies that don't require a wall no longer require a wall
- Cleanup up some recent code in BaseAI for Guard actions
- Renamed AttackMessage to Aggression.cs for obvious reasons
- Death now clears aggressors/aggressed, and removes the dead mobile from others' aggressor/aggressed lists
- Added standard AcquireIndirectTarget for all indirect AOE spells.
- All Indirect targeting regarding pets/masters now go through ValidIndirectTarget method in spellhelper
- Added check to removed ServUO Shard List from spamming console of connection/disconnection
2018-10-13 19:05:25 -07:00
Dexter
4987e03232 Bug Fixes
- Barreraak's ring and Xenrr Fishing Pole now use body/hue mods. Also, player gets teh effect on server start if eqiupped.
- Neville should not be harmed anymore
- Fixed issue where palyers hit by riding swipe could not mount another moutn. The riding swipe mount restriction now is rmeoved when the pet dies.
- Taming EC target macro should work with animal taming
- Junk should now drop (as well as regular fish) regardless of skill level. THe higher the skill, the less are fished up, per EA.
- Transformation Spells now check for skill requirement when skill changes on a Player
- Fixed Fists of Fury Crash
2018-09-15 11:29:53 -07:00
Dexter
46c7e4c5ce Bug Fixes
- Sanity Check in Para Blow
- Added proper durability to Bone Machete
- Bone Machete now has a 40% chance to break on Use
- Console Save no longer interferes with create world
- Non-house owners can no un-secure container they secured
- Players are now restricted to 1 Boat
- Refinement Amalgamator now requries the proper amount of lesser refinements to work depending on the quality of the Mods
- Fixed issue with Magincia Message Gumps
- Travel restrictions no longer effect combat heat unless you are the aggressor
2018-09-08 19:37:50 -07:00
Dexter
6979dad1ab Bug Fixes
- Berserk Set no longer gives improper Resists
- Berserk no longer knocks a player out of a transform Spell
- Vial of Vitriol now stacks
- Removed unused, mispelled vialvitrol
- Removed Era check for creature Special Ability and area effects. These were active prior to pet training helper
- Vendor rental deeds no longer stay locked down when released via retrieve context menu
- House teleporters are not longer functional during house customization
- Damage Region now uses proper interval when inflicting Damage
2018-08-17 21:16:00 -07:00
VitaNex
7851c5e88c + Removed most file header regions.
+ Add MONO to Makefile compile definitions.
+ Update Ultima SDK to support MONO compile definition.
+ Rename Properties Gump parent directory to prevent VS issues.
+ Console error messages will now use red instead of dark red font.
+ Add crash state handler function to Core.
+ AI optimizations and housekeeping.
+ Context Menu optimizations and housekeeping.
+ Add ability to drop throttled packets.
+ Add string parsing support to Rectangle3D.
+ Optimize guild messages and chat.
+ IAddon implements IChopable.
+ Add more flexibility for altering Mobile names.
+ Add ability to enable or disable OPL for individual mobiles.
+ Optimize damaging regions and ensure timers are removed properly.
+ Update Welcome Timer with more intuitive message groups.
+ Normalize all virtue related objects to the Server.Services.Virtues namespace.
+ Add ability for ISpawner to append OPL and Context Menus to their spawn.
+ Add EventSink events for obtaining items, equipping items, context menus, and world broadcasts.
+ Add ability to lock a creature's direction and movement regardless of AI manipulation.
+ Add ability to dynamically change a creature's approach range and wait state.
+ Add extended enumeration features for AOS attributes.
+ Add ability to control whether creatures have blood, and its color.
+ Expose corpse flag manipulation methods.
+ Add ability to prevent criminal action when looting a corpse.
+ Corpse will now be permanently tagged as murderer at time of death if owner is a murderer.
+ Add TextDefinition support for Commodity Deed descriptions.
+ House add-on and component optimizations and housekeeping.
+ Item light is no longer backed by the direction property.
+ ITool implements IEntity.
+ Prevent trading of Siege Bless items.
+ Guards are naturally be immune to guards.
+ Siege Shard initialization housekeeping.
+ Character Creation housekeeping.
+ Generic commands housekeeping.
+ Add Mark command for staff.
2018-07-19 22:12:52 +01:00
Dexter
5311538a0a Bug Fixes
- Removed StatLossAfterTame when PetTraining is enabled for fire beetle and LesserHiryu
- Clumsy/weaken/feeblemind now gives resist gains
- removed double resist skill check in debuff spells
- Fixed crash bug
2018-06-21 16:30:07 -07:00
Dexter
b0693c2db9 Bug Fixes
- Fixed Effects for DamageableItems
- Added Abilities to Elemental Creatures
- Moved AlterMeleeDamageTo and AlterMeleeDamageFrom to AOS.cs Damage Method
- Fixed Spawner Issue where Min/Max respawn is adjusted
- Fixed Spell reflection on creatures
2018-05-24 19:47:27 -07:00
Dexter
fe22ccf003 Bug Fixes
- Fixed riding swipe (on ethy) message
- Riding swipe victims (on ehty) can now re-mount once 10 second dazed effect wears off
- added proper target checks for momentum strike
- fixed spell reflection, should only effect pre-aos servers

Additions
- added sound/effects/particle support for Damageable items. It is now implemented via IDamageable, which is inherited by Mobile. Calling sound/particles/effects will no be the same as calling them for a mobile
- Added EffectMobile for certain effects that require a mobile, ie bolt effect.
2018-04-28 12:57:43 -07:00
Dexter
b695458720 Bug Fixes
- Added overridable function in DamageableItem for reflecting spells for future use
- Added Mystic direct damaging spell support for damaging IDamageableItem
- Added IDamageable support for CheckReflect in SpellHelper
- Shame: removed conditional teleporters and added teleporter specific for Shame
- Explosive goo is now in line with EA
- Fixed particles for Grasping Claw to match EA
- Retrieve context menu option no longer available for house container addons
2018-04-22 22:09:25 -07:00
Dexter
9a3f00c93a Updated Eodon bounds 2018-04-13 20:55:05 -07:00