mmo-ref/stendhal
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Webclient: Use gamewindow to measure text instead of creating a new canvas

Browse source
This commit is contained in:
Jordan Irwin 2023-02-27 13:54:29 -08:00
parent cc8b254fec
commit 91501000ea
1 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
srcjs/stendhal/sprite/AchievementBanner.ts
View file

@ -45,7 +45,7 @@ export class AchievementBanner extends TextBubble {
const gamewindow =
<HTMLCanvasElement> document.getElementById("gamewindow")!;
const td = this.getTextDimensions();
const td = this.getTextDimensions(gamewindow.getContext("2d")!);
this.innerWidth = td.width + this.padding; // add padding between icon & text
this.innerHeight = td.height;
this.width = this.innerWidth + (this.padding * 2); // add left & right padding
@ -81,15 +81,13 @@ export class AchievementBanner extends TextBubble {
return this.expired();
}
getTextDimensions(): any {
private getTextDimensions(ctx: CanvasRenderingContext2D): any {
const ret = {} as any;
// XXX: is this safe? garbage collection?
const ctemp = (document.createElement("canvas") as HTMLCanvasElement).getContext("2d")!;
ctemp.font = this.font;
let m = ctemp.measureText(this.text);
ctx.font = this.font;
let m = ctx.measureText(this.text);
ret.width = m.width;
ctemp.font = this.fontT;
m = ctemp.measureText(this.title);
ctx.font = this.fontT;
m = ctx.measureText(this.title);
ret.width = Math.max(ret.width, m.width);
// FIXME: how to find text height
ret.height = 96;