mirror of
https://github.com/mod-playerbots/mod-playerbots
synced 2026-08-14 18:29:08 -04:00
51f98b49bd
## Pull Request Description This PR adds Korean localization data for `ai_playerbot_texts`. Related issue: - https://github.com/mod-playerbots/mod-playerbots/issues/2523 This change only updates Korean locale text and does not replace the default English text. Contributors / translation source: - Hobbyist - summersnowmen Scope: - Adds Korean locale text for existing `ai_playerbot_texts` rows - Uses `text_loc1` for Korean localization - Does not change bot logic - Does not change gameplay behavior - Does not change strategy, AI decision-making, or performance-sensitive code Not included: - No bot name replacement - No guild name replacement - No arena team name replacement - No dungeon suggestion replacement - No speech table replacement - No balance changes - No gameplay changes - No C++ code changes ## Feature Evaluation - Describe the **minimum logic** required to achieve the intended behavior. No new logic is added. This PR only adds Korean localization data to the existing SQL localization column for `ai_playerbot_texts`. - Describe the **processing cost** when this logic executes across many bots. No additional per-bot or per-tick processing cost is introduced. The PR only updates database localization text. It does not add new bot triggers, decisions, AI actions, strategy checks, or runtime loops. ## How to Test the Changes 1. Apply the SQL update. 2. Start `worldserver`. 3. Confirm that the SQL update is applied without database errors. 4. Confirm that the default English `text` column is not overwritten. 5. Confirm that Korean localized text is stored in `text_loc1`. 6. Use a Korean locale setup and verify that existing playerbot text can display Korean localized text where applicable. Expected result: - Existing English fallback text remains unchanged. - Korean localization data is available in the locale column. - No bot behavior, strategy, combat, movement, or performance behavior changes. ## Impact Assessment - Does this change increase per-bot/per-tick processing or risk scaling poorly with thousands of bots? - [x] No, not at all - [ ] Minimal impact (**explain below**) - [ ] Moderate impact (**explain below**) Explanation: This is a database localization-only update. It does not add any new runtime logic, bot decision branches, triggers, actions, or per-tick processing. - Does this change modify default bot behavior? - [x] No - [ ] Yes (**explain why**) Explanation: Default bot behavior is unchanged. This PR only adds Korean localization data. - Does this change add new decision branches or increase maintenance complexity? - [x] No - [ ] Yes (**explain below**) Explanation: No C++ code, strategy logic, or decision-making logic is modified. ## AI Assistance Was AI assistance used while working on this change? - [ ] No - [x] Yes (**explain below**) AI assistance was used to help format the Pull Request description and convert the localization submission into a reviewable PR structure. The SQL content and translation data were reviewed before submission. No C++ code or bot logic was generated by AI in this PR. ## Code Provenance / Attribution Was any code in this PR copied or adapted from a sister / upstream project (e.g. CMaNGOS playerbots, MaNGOS, another module)? - [x] No, all code in this PR is original - [ ] Yes (**name the project and the original author(s) below**) No code was copied or adapted from another project. This PR contains Korean localization data only. Translation contributors: - Hobbyist - summersnowmen ## Final Checklist - [x] Stability is not compromised. - [x] Performance impact is understood, tested, and acceptable. - [x] Added logic complexity is justified and explained. - [x] Any new bot dialogue lines are translated. - [x] Any code ported/adapted from another project is attributed, if applicable. - [x] New source files use the GPLv2 header, if applicable. - [x] Documentation updated if needed. - [x] New and modified files do not introduce new compiler warnings. ## Notes for Reviewers This PR is intentionally limited to `ai_playerbot_texts` Korean localization only. The previous Korean localization package included additional data such as bot names, guild names, arena team names, dungeon suggestions, and speech text. Those are intentionally not included in this PR to keep the review scope small and safe. If this approach is acceptable, additional Korean localization data can be separated into future PRs. [2026_07_05_00_ai_playerbot_korean_texts.sql](https://github.com/user-attachments/files/29676014/2026_07_05_00_ai_playerbot_korean_texts.sql) --------- Co-authored-by: Keleborn <22352763+Celandriel@users.noreply.github.com> Co-authored-by: bash <hermensb@gmail.com> Co-authored-by: Revision <tkn963@gmail.com> Co-authored-by: kadeshar <kadeshar@gmail.com> |
||
|---|---|---|
| .. | ||
| archive | ||
| base | ||
| create | ||
| custom | ||
| updates | ||