sovereign-rf/DAPNETGateway
1
0
Fork 0
mirror of https://github.com/g4klx/DAPNETGateway.git synced 2026-08-26 12:32:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

lookup(): fix undefined result of address_length

Browse source 
When getaddrinfo() failed, the result of address_length is undefined.
Original (IPv4) code returns INADDR_NONE, IPv6 capable code should
do same behavior.
This commit is contained in:
SASANO Takayoshi 2019-10-22 19:25:40 +09:00
parent 90e43e15f8
commit 9d65424d8c
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
UDPSocket.cpp
View file

@ -68,19 +68,21 @@ int CUDPSocket::lookup(const std::string& hostname, unsigned int port, sockaddr_
std::string portstr = std::to_string(port);
struct addrinfo hints, *res;
::memset(&addr, 0, sizeof(sockaddr_storage));
::memset(&hints, 0, sizeof(struct addrinfo));
hints.ai_flags = AI_NUMERICSERV;
err = getaddrinfo(hostname.c_str(), portstr.c_str(), &hints, &res);
if (err) {
sockaddr_in *paddr = (sockaddr_in *)&addr;
::memset(paddr, 0, address_length = sizeof(sockaddr_in));
paddr->sin_family = AF_INET;
paddr->sin_port = htons(port);
paddr->sin_addr.s_addr = htonl(INADDR_NONE);
LogError("Cannot find address for host %s", hostname.c_str());
return err;
}
::memcpy(&addr, res->ai_addr, res->ai_addrlen);
address_length = res->ai_addrlen;
::memcpy(&addr, res->ai_addr, address_length = res->ai_addrlen);
freeaddrinfo(res);
return 0;