From a7925bd74ea4229e8437991cd61af77bc306dd63 Mon Sep 17 00:00:00 2001 From: Martin Ling Date: Mon, 18 May 2026 16:31:54 +0100 Subject: [PATCH] Remove some superfluous spi_bus_setup calls. --- firmware/common/rom_iap.c | 2 -- firmware/hackrf_usb/hackrf_usb.c | 1 - firmware/hackrf_usb/usb_api_spiflash.c | 3 --- 3 files changed, 6 deletions(-) diff --git a/firmware/common/rom_iap.c b/firmware/common/rom_iap.c index 25dfa269..ce1f113b 100644 --- a/firmware/common/rom_iap.c +++ b/firmware/common/rom_iap.c @@ -23,7 +23,6 @@ #include #include "rom_iap.h" -#include "spi_bus.h" #include "w25q80bv.h" #define ROM_IAP_ADDR (0x10400100) @@ -77,7 +76,6 @@ isp_iap_ret_code_t iap_cmd_call(iap_cmd_res_t* iap_cmd_res) Alternative way to retrieve Part Id on MCU with no IAP Read Serial No => Read Unique ID in SPIFI (only compatible with W25Q80BV */ - spi_bus_start(spi_flash.bus, &ssp_config_w25q80bv); w25q80bv_setup(&spi_flash); switch (iap_cmd_res->cmd_param.command_code) { diff --git a/firmware/hackrf_usb/hackrf_usb.c b/firmware/hackrf_usb/hackrf_usb.c index 5d71fa80..197ffb8a 100644 --- a/firmware/hackrf_usb/hackrf_usb.c +++ b/firmware/hackrf_usb/hackrf_usb.c @@ -275,7 +275,6 @@ extern uint32_t _binary_fpga_bin_start; void fpga_loader_setup(void) { - spi_bus_start(spi_flash.bus, &ssp_config_w25q80bv); w25q80bv_setup(&spi_flash); } diff --git a/firmware/hackrf_usb/usb_api_spiflash.c b/firmware/hackrf_usb/usb_api_spiflash.c index c698d599..21370bd0 100644 --- a/firmware/hackrf_usb/usb_api_spiflash.c +++ b/firmware/hackrf_usb/usb_api_spiflash.c @@ -26,7 +26,6 @@ #include #include -#include #include #include #include @@ -40,7 +39,6 @@ usb_request_status_t usb_vendor_request_erase_spiflash( const usb_transfer_stage_t stage) { if (stage == USB_TRANSFER_STAGE_SETUP) { - spi_bus_start(spi_flash.bus, &ssp_config_w25q80bv); w25q80bv_setup(&spi_flash); /* only chip erase is implemented */ w25q80bv_chip_erase(&spi_flash); @@ -69,7 +67,6 @@ usb_request_status_t usb_vendor_request_write_spiflash( len, NULL, NULL); - spi_bus_start(spi_flash.bus, &ssp_config_w25q80bv); w25q80bv_setup(&spi_flash); return USB_REQUEST_STATUS_OK; }