uefi-ref/binutils-gdb
1
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2026-08-27 00:26:02 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Assume an unrecognized gnatmake is very new

Browse source 
I don't know why -- though I suspect there may have been a change to
the output of "gnatmake --version" -- but recently some gdb.ada tests
have stopped running when llvm-gnatmake is used.

The llvm-gnatmake I am testing against prints a version string that
isn't recognized by gnat_version_compare.  However, it seems to me
that AdaCore is probably the main place where this can even occur; and
furthermore that without some extra work, it seems reasonable for
gnat_version_compare to assume that an unrecognized gnatmake is "very
new".
This commit is contained in:
Tom Tromey 2026-07-01 10:05:24 -06:00
parent be0be9e7a8
commit f8ebb8db3b
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
gdb/testsuite/lib/ada.exp
View file

@ -180,7 +180,8 @@ proc find_ada_tool {tool} {
}
# Compare the GNAT version against L2 using version_compare. If the
# compiler does not appear to be GCC, this will always return false.
# compiler does not appear to be GCC, this will assume that gnatmake
# is very new.
proc gnat_version_compare {op l2} {
set gnatmake [find_gnatmake]
@ -189,7 +190,8 @@ proc gnat_version_compare {op l2} {
return 0
}
if {![regexp {GNATMAKE ([0-9]+(\.[0-9]+)*)} $output match version]} {
return 0
# Assume a "very new" version.
set version 99
}
return [version_compare [split $version .] $op $l2]