Andrew Burgess dff7f6c72d gdb/python: stop using PyObject_IsInstance in py-disasm.c ... The PyObject_IsInstance function can return -1 for errors, 0 to indicate false, and 1 to indicate true. I noticed in python/py-disasm.c that we treat the result of PyObject_IsInstance as a bool. This means that if PyObject_IsInstance returns -1, then this will be treated as true. The consequence of this is that we will invoke undefined behaviour by treating the result from the _print_insn call as if it was a DisassemblerResult object, even though PyObject_IsInstance raised an error, and the result might not be of the required type. I could fix this by taking the -1 result into account, however, gdb.DisassemblerResult cannot be sub-classed, the type doesn't have the Py_TPFLAGS_BASETYPE flag. As such, we can switch to using PyObject_TypeCheck instead, which only return 0 or 1, with no error case. I have also taken the opportunity to improve the error message emitted if the result has the wrong type. Better error message make debugging issues easier. I've added a test which exposes the problem when using PyObject_IsInstance, and I've updated the existing test for the improved error message. Approved-By: Tom Tromey <tom@tromey.com>		2025-04-23 15:41:35 +01:00
..
lib/gdb	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-all-events.def	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-arch.c	gdb/python: add void_type () method to gdb.Architecture object	2025-02-04 13:56:49 +00:00
py-auto-load.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-block.c	gdb/python: add subblocks property to gdb.Block	2025-02-04 13:56:49 +00:00
py-bpevent.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-breakpoint.c	gdb/python: remove stray white space in error message	2025-04-22 17:50:55 +01:00
py-cmd.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-color.c	gdb/python: address some coding style issues in py-color.c	2025-04-22 17:53:54 +01:00
py-color.h	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-connection.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-continueevent.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-dap.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-disasm.c	gdb/python: stop using PyObject_IsInstance in py-disasm.c	2025-04-23 15:41:35 +01:00
py-event-types.def	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-event.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-event.h	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-events.h	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-evtregistry.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-evts.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-exitedevent.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-finishbreakpoint.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-frame.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-framefilter.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-function.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-gdb-readline.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-inferior.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-infevents.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-infthread.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-instruction.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-instruction.h	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-lazy-string.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-linetable.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-membuf.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-mi.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-micmd.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-newobjfileevent.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-objfile.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-param.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-prettyprint.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-progspace.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-record-btrace.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-record-btrace.h	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-record-full.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-record-full.h	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-record.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-record.h	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-ref.h	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-registers.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-signalevent.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-stopevent.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-stopevent.h	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-symbol.c	gdb/python: convert gdb.Symbol to use gdbpy_registry	2025-03-19 21:12:53 +00:00
py-symtab.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-threadevent.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-tui.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-type.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-uiout.h	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-unwind.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-utils.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-value.c	Clean up value_struct_elt_bitpos	2025-04-17 09:25:55 -06:00
py-varobj.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
py-xmethods.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
python-config.py	Run isort	2024-04-02 11:21:39 -06:00
python-internal.h	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
python.c	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00
python.h	Update copyright dates to include 2025	2025-04-08 10:54:39 -06:00