From 0a74b3a4de0ee98e6a5ad73d328c86bea04bada8 Mon Sep 17 00:00:00 2001 From: Jiaqing Zhao Date: Tue, 23 Jun 2026 23:06:09 +0800 Subject: [PATCH] OvmfPkg/VirtioKeyboardDxe: Drop unused functions and variables VirtioKeyboardRingHasBuffer() and VIRTIO_KBD_DEV.KeyNotifyTimer are defined but never called, drop them. Signed-off-by: Jiaqing Zhao --- OvmfPkg/VirtioKeyboardDxe/VirtioKeyboard.c | 23 ---------------------- OvmfPkg/VirtioKeyboardDxe/VirtioKeyboard.h | 1 - 2 files changed, 24 deletions(-) diff --git a/OvmfPkg/VirtioKeyboardDxe/VirtioKeyboard.c b/OvmfPkg/VirtioKeyboardDxe/VirtioKeyboard.c index e517e26d64..28cffe7f19 100644 --- a/OvmfPkg/VirtioKeyboardDxe/VirtioKeyboard.c +++ b/OvmfPkg/VirtioKeyboardDxe/VirtioKeyboard.c @@ -104,29 +104,6 @@ VirtioKeyboardRingSendBuffer ( return EFI_SUCCESS; } -// ----------------------------------------------------------------------------- -// Look for buffer ready to be processed -BOOLEAN -EFIAPI -VirtioKeyboardRingHasBuffer ( - IN OUT VIRTIO_KBD_DEV *Dev, - IN UINT16 Index - ) -{ - VIRTIO_KBD_RING *Ring = Dev->Rings + Index; - UINT16 UsedIdx = *Ring->Ring.Used.Idx; - - if (!Ring->Ready) { - return FALSE; - } - - if (Ring->LastUsedIdx == UsedIdx) { - return FALSE; - } - - return TRUE; -} - // ----------------------------------------------------------------------------- // Get data from buffer which is marked as ready from device BOOLEAN diff --git a/OvmfPkg/VirtioKeyboardDxe/VirtioKeyboard.h b/OvmfPkg/VirtioKeyboardDxe/VirtioKeyboard.h index b244dec12e..4e08493d33 100644 --- a/OvmfPkg/VirtioKeyboardDxe/VirtioKeyboard.h +++ b/OvmfPkg/VirtioKeyboardDxe/VirtioKeyboard.h @@ -97,7 +97,6 @@ typedef struct { // List for notifications LIST_ENTRY NotifyList; - EFI_EVENT KeyNotifyTimer; // Last pressed key // typedef struct {