diff --git a/MdeModulePkg/Library/ArmFfaLib/ArmFfaCommon.h b/MdeModulePkg/Library/ArmFfaLib/ArmFfaCommon.h index 22bcd650e5..7be469f71d 100644 --- a/MdeModulePkg/Library/ArmFfaLib/ArmFfaCommon.h +++ b/MdeModulePkg/Library/ArmFfaLib/ArmFfaCommon.h @@ -34,7 +34,7 @@ FfaArgsToEfiStatus ( ); /** - Common ArmFfaLib Constructor. + Common ArmFfaLib init. @param [out] PartId PartitionId @param [out] IsFfaSupported FF-A supported flag diff --git a/MdeModulePkg/Library/ArmFfaLib/ArmFfaDxeLib.c b/MdeModulePkg/Library/ArmFfaLib/ArmFfaDxeLib.c index 3c81435334..8e0eecfa45 100644 --- a/MdeModulePkg/Library/ArmFfaLib/ArmFfaDxeLib.c +++ b/MdeModulePkg/Library/ArmFfaLib/ArmFfaDxeLib.c @@ -84,12 +84,9 @@ ArmFfaDxeLibConstructor ( if (EFI_ERROR (Status)) { if (!mIsFfaSupported) { /* - * EFI_UNSUPPORTED return from ArmFfaLibCommonInit() means - * FF-A interface doesn't support. - * However, It doesn't make failure of loading driver/library instance - * (i.e) ArmPkg's MmCommunication Dxe/PEI Driver uses as well as SpmMm. - * So If FF-A is not supported the the MmCommunication Dxe/PEI falls - * back to SpmMm. + * FF-A being unsupported doesn't mean a failure of loading the driver/library + * instance (i.e) ArmPkg's MmCommunication Dxe/PEI Driver uses as well as SpmMm. + * So If FF-A is not supported the the MmCommunication Dxe/PEI falls back to SpmMm. * For this case, return EFI_SUCCESS. */ return EFI_SUCCESS; diff --git a/MdeModulePkg/Library/ArmFfaLib/ArmFfaPeiLib.c b/MdeModulePkg/Library/ArmFfaLib/ArmFfaPeiLib.c index 420d5e89d7..7a9080a289 100644 --- a/MdeModulePkg/Library/ArmFfaLib/ArmFfaPeiLib.c +++ b/MdeModulePkg/Library/ArmFfaLib/ArmFfaPeiLib.c @@ -125,14 +125,10 @@ ArmFfaPeiLibConstructor ( if (EFI_ERROR (Status)) { if (!mIsFfaSupported) { /* - * EFI_UNSUPPORTED return from ArmFfaLibCommonInit() means - * FF-A interface doesn't support. - * However, It doesn't make failure of loading driver/library instance - * (i.e) ArmPkg's MmCommunication Dxe/PEI Driver uses as well as SpmMm. - * So If FF-A is not supported the the MmCommunication Dxe/PEI falls - * back to SpmMm. + * FF-A being unsupported doesn't mean a failure of loading the driver/library + * instance (i.e) ArmPkg's MmCommunication Dxe/PEI Driver uses as well as SpmMm. + * So If FF-A is not supported the the MmCommunication Dxe/PEI falls back to SpmMm. * For this case, return EFI_SUCCESS. - */ return EFI_SUCCESS; } diff --git a/MdeModulePkg/Library/ArmFfaLib/ArmFfaSecLib.c b/MdeModulePkg/Library/ArmFfaLib/ArmFfaSecLib.c index 3e7355b503..c0468dd899 100644 --- a/MdeModulePkg/Library/ArmFfaLib/ArmFfaSecLib.c +++ b/MdeModulePkg/Library/ArmFfaLib/ArmFfaSecLib.c @@ -58,12 +58,9 @@ ArmFfaSecLibConstructor ( if (EFI_ERROR (Status)) { if (!IsFfaSupported) { /* - * EFI_UNSUPPORTED return from ArmFfaLibCommonInit() means - * FF-A interface doesn't support. - * However, It doesn't make failure of loading driver/library instance - * (i.e) ArmPkg's MmCommunication Dxe/PEI Driver uses as well as SpmMm. - * So If FF-A is not supported the the MmCommunication Dxe/PEI falls - * back to SpmMm. + * FF-A being unsupported doesn't mean a failure of loading the driver/library + * instance (i.e) ArmPkg's MmCommunication Dxe/PEI Driver uses as well as SpmMm. + * So If FF-A is not supported the the MmCommunication Dxe/PEI falls back to SpmMm. * For this case, return EFI_SUCCESS. */ return EFI_SUCCESS; @@ -78,6 +75,8 @@ ArmFfaSecLibConstructor ( return Status; } + DEBUG ((DEBUG_INFO, "%a Rx/Tx buffer isn't supported.\n", __func__)); + /* * When ARM_FID_FFA_PARTITION_INFO_GET_REGS is supported, * Rx/Tx buffer might not be required to request service to @@ -91,7 +90,7 @@ ArmFfaSecLibConstructor ( &Property2 ); if (!EFI_ERROR (Status)) { - DEBUG ((DEBUG_INFO, "%a Rx/Tx buffer doesn't support.\n", __func__)); + DEBUG ((DEBUG_INFO, "%a PARTITION_INFO_GET_REGS is available as an alternative to Rx/Tx buffer.\n", __func__)); } return Status; diff --git a/MdeModulePkg/Library/ArmFfaLib/ArmFfaSecRxTxMap.c b/MdeModulePkg/Library/ArmFfaLib/ArmFfaSecRxTxMap.c index b11a883051..80fc5a5f5a 100644 --- a/MdeModulePkg/Library/ArmFfaLib/ArmFfaSecRxTxMap.c +++ b/MdeModulePkg/Library/ArmFfaLib/ArmFfaSecRxTxMap.c @@ -134,7 +134,7 @@ ArmFfaLibRxTxMap ( if (EFI_ERROR (Status)) { DEBUG (( DEBUG_ERROR, - "%a: Failed to get RX/TX buffer property... Status: %r\n", + "%a: Failed to get Rx/Tx buffer property... Status: %r\n", __func__, Status )); @@ -283,8 +283,8 @@ ErrorHandler: Rx/Tx buffer is registered only once per partition. @retval EFI_SUCCESS - @retval EFI_INVALID_PARAMETERS Already unregistered - @retval EFI_UNSUPPORTED Not supported + @retval EFI_INVALID_PARAMETER Already unregistered + @retval EFI_UNSUPPORTED Not supported **/ EFI_STATUS @@ -336,9 +336,9 @@ ArmFfaLibRxTxUnmap ( } /** - Update Rx/TX buffer information. + Update Rx/Tx buffer information. - @param BufferInfo Rx/Tx buffer information. + @param BufferInfo Rx/Tx buffer information. **/ VOID @@ -364,7 +364,7 @@ UpdateRxTxBufferInfo ( } /** - Find Rx/TX buffer memory allocation hob. + Find Rx/Tx buffer memory allocation hob. @param UseGuid Find MemoryAllocationHob using Guid. @@ -389,7 +389,7 @@ FindRxTxBufferAllocationHob ( } /** - Remap Rx/TX buffer with converted Rx/Tx Buffer address after + Remap Rx/Tx buffer with converted Rx/Tx Buffer address after using permanent memory. @param[out] BufferInfo BufferInfo diff --git a/MdeModulePkg/Library/ArmFfaLib/ArmFfaStandaloneMmLib.c b/MdeModulePkg/Library/ArmFfaLib/ArmFfaStandaloneMmLib.c index 2d3c15ed78..b1e8af3dc2 100644 --- a/MdeModulePkg/Library/ArmFfaLib/ArmFfaStandaloneMmLib.c +++ b/MdeModulePkg/Library/ArmFfaLib/ArmFfaStandaloneMmLib.c @@ -49,7 +49,7 @@ ArmFfaStandaloneMmLibConstructor ( Status = ArmFfaLibCommonInit (&mPartId, &mIsFfaSupported); if (!mIsFfaSupported) { /* - * EFI_UNSUPPORTED means FF-A interface isn't available. + * Unsupported means FF-A interface isn't available. * However, for Standalone MM modules, FF-A availability is not required. * i.e. Standalone MM could use SpmMm as a legitimate protocol. * Thus, returning EFI_SUCCESS here to avoid the entrypoint to assert.