From 4ad28a8588f1ca8e0f448bfdf2e092171d61b742 Mon Sep 17 00:00:00 2001 From: VarshitPandya Date: Fri, 26 Jun 2026 16:45:35 +0100 Subject: [PATCH] ShellPkg: ShellPkg: Fix SMBIOS Type 28 probe labels Use a Temperature Probe specific HII string when displaying the Type 28 Location field in smbiosview. The Type 28 decoder was using the Voltage Probe location label, causing temperature probe records to be displayed with the wrong field name. Signed-off-by: Varshit Pandya --- .../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 4 ++-- .../SmbiosView/SmbiosViewStrings.uni | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c index cbfb281c99..4dce68dccf 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c @@ -5101,7 +5101,7 @@ DisplayTemperatureProbeStatus ( UINT8 Status; Status = (UINT8)((Key & 0xE0) >> 5); - ShellPrintHiiDefaultEx (STRING_TOKEN (STR_SMBIOSVIEW_QUERYTABLE_TEMP_PROBE), gShellDebug1HiiHandle); + ShellPrintHiiDefaultEx (STRING_TOKEN (STR_SMBIOSVIEW_QUERYTABLE_TEMP_PROBE_STATUS), gShellDebug1HiiHandle); PRINT_INFO_OPTION (Status, Option); PRINT_TABLE_ITEM (TemperatureProbeStatusTable, Status); } @@ -5121,7 +5121,7 @@ DisplayTemperatureProbeLoc ( UINT8 Loc; Loc = (UINT8)(Key & 0x1F); - ShellPrintHiiDefaultEx (STRING_TOKEN (STR_SMBIOSVIEW_QUERYTABLE_VOLTAGE_PROBE_LOC), gShellDebug1HiiHandle); + ShellPrintHiiDefaultEx (STRING_TOKEN (STR_SMBIOSVIEW_QUERYTABLE_TEMP_PROBE_LOC), gShellDebug1HiiHandle); PRINT_INFO_OPTION (Loc, Option); PRINT_TABLE_ITEM (TemperatureProbeLocTable, Loc); } diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni index 10edc12aa7..898a449796 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni @@ -6,6 +6,7 @@ // (C) Copyright 2015-2019 Hewlett Packard Enterprise Development LP
// Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved. // Copyright (C) 2025 Advanced Micro Devices, Inc. All rights reserved. +// Copyright (c) 2026 Arm Limited. All rights reserved.
// SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: @@ -452,7 +453,8 @@ #string STR_SMBIOSVIEW_QUERYTABLE_VOLTAGE_PROBE_STATUS #language en-US "Voltage Probe - Status:" #string STR_SMBIOSVIEW_QUERYTABLE_COOLING_DEV_STATUS #language en-US "Cooling Device - Status: " #string STR_SMBIOSVIEW_QUERYTABLE_COOLING_DEV_TYPE #language en-US "Cooling Device - Type: " -#string STR_SMBIOSVIEW_QUERYTABLE_TEMP_PROBE #language en-US "Temperature Probe - Status:" +#string STR_SMBIOSVIEW_QUERYTABLE_TEMP_PROBE_STATUS #language en-US "Temperature Probe - Status:" +#string STR_SMBIOSVIEW_QUERYTABLE_TEMP_PROBE_LOC #language en-US "Temperature Probe - Location:" #string STR_SMBIOSVIEW_QUERYTABLE_ELEC_PROBE_STATUS #language en-US "Electrical Current Probe - Status:" #string STR_SMBIOSVIEW_QUERYTABLE_ELEC_PROBE_LOC #language en-US "Electrical Current Probe - Location:" #string STR_SMBIOSVIEW_QUERYTABLE_MANAGEMENT_DEV_TYPE #language en-US "Management Device Type:"