uefi-ref/edk2
1
0
Fork 0
mirror of https://github.com/tianocore/edk2 synced 2026-08-27 00:23:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

MdeModulePkg/SetupBrowserDxe: Sync ordered lists before action callback

Browse source 
When the user selects an EFI_IFR_ACTION_OP (for example Commit Changes
and Exit), SetupBrowser may submit the form and invoke the driver's
callback before ordered-list question values are copied from their
edit buffer into storage. HiiGetBrowserData() in the callback then sees
stale list ordering and the submitted configuration is wrong.

Sync all ordered-list values to storage on EFI_BROWSER_ACTION_CHANGED
for action opcodes only. Only run for action opcodes to avoid affecting
menu navigation (GOTO/REFRESH).

Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Matt DeVillier 2026-03-10 14:11:12 -05:00 • committed by MrChromebox
parent d98a39d4ce
commit 55d4a3924f
1 changed files with 25 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

25
MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
View file

@ -2063,6 +2063,31 @@ ProcessCallBackFunction (
return EFI_SUCCESS;
}
//
// When processing CHANGED for an action opcode (e.g., "Commit Changes and Exit"),
// sync ordered list values to Storage first. Action opcodes can trigger form submit;
// ordered lists use separate BufferValue that must be synced before the callback
// runs HiiGetBrowserData. Only run for action opcodes to avoid affecting menu
// navigation (GOTO/REFRESH).
//
if ((Action == EFI_BROWSER_ACTION_CHANGED) &&
(Question != NULL) &&
(Question->Operand == EFI_IFR_ACTION_OP))
{
Link = GetFirstNode (&Form->StatementListHead);
while (!IsNull (&Form->StatementListHead, Link)) {
Statement = FORM_BROWSER_STATEMENT_FROM_LINK (Link);
Link = GetNextNode (&Form->StatementListHead, Link);
if ((Statement->Operand == EFI_IFR_ORDERED_LIST_OP) &&
(Statement->Storage != NULL) &&
(Statement->BufferValue != NULL))
{
SetQuestionValue (FormSet, Form, Statement, GetSetValueWithEditBuffer);
}
}
}
Link = GetFirstNode (&Form->StatementListHead);
while (!IsNull (&Form->StatementListHead, Link)) {
Statement = FORM_BROWSER_STATEMENT_FROM_LINK (Link);