uefi-ref/edk2
1
0
Fork 0
mirror of https://github.com/tianocore/edk2 synced 2026-08-27 00:23:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

ShellPkg/AcpiView: Avoid mutating HEST hardware bank count during parse

Browse source 
Remove post-parse write to mHestIA32HardwareBankCount.
Keep HEST parsing read-only.

*mHestIA32HardwareBankCount = 0, line in code corrupts the
ACPI HEST table data Hardware bank count to zero.

mHestIA32HardwareBankCount points into the parsed HEST table
data (input buffer). Writing through it modifies ACPI table
contents during parsing, which should be read-only behavior.

Signed-off-by: Gaurav Pandya <Gaurav.Pandya@amd.com>
This commit is contained in:
Gaurav Pandya 2026-03-30 12:23:03 +00:00 • committed by mergify[bot]
parent 35c03c1c9f
commit bd8ec21280
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Hest/HestParser.c
View file

@ -2,6 +2,7 @@
HEST table parser
Copyright (c) 2024, Arm Limited.
Copyright (C) 2026 Advanced Micro Devices, Inc. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@par Specification Reference:
@ -16,9 +17,9 @@
#include "AcpiView.h"
STATIC ACPI_DESCRIPTION_HEADER_INFO mAcpiHdrInfo;
STATIC UINT32 *mHestErrorSourceCount;
STATIC UINT16 *mHestErrorSourceType;
STATIC UINT8 *mHestIA32HardwareBankCount;
STATIC CONST UINT32 *mHestErrorSourceCount;
STATIC CONST UINT16 *mHestErrorSourceType;
STATIC CONST UINT8 *mHestIA32HardwareBankCount;
/**
An String array for Error Notification Structure's type.
@ -551,8 +552,6 @@ DumpIA32ArchMachineCheckErrorBankStructure (
sizeof (EFI_ACPI_6_5_IA32_ARCHITECTURE_MACHINE_CHECK_ERROR_BANK_STRUCTURE);
}
*mHestIA32HardwareBankCount = 0;
return EFI_SUCCESS;
}