uefi-ref/edk2
1
0
Fork 0
mirror of https://github.com/tianocore/edk2 synced 2026-08-27 00:23:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

DynamicTablesPkg: Clear output parameter before callback invocation

Browse source 
BuildSmbiosTable() and BuildSmbiosTableEx() callback are called
with uninitialized pointers which might contain garbage data. If
one of these function fails, the exit handler uses these
uninitialized fields.

Set these uninitialized pointers in the caller function.

Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
This commit is contained in:
Pierre Gondois 2026-06-05 17:26:22 +02:00 • committed by mergify[bot]
parent e3e93cf092
commit d1806ae8fa
1 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

22
DynamicTablesPkg/Drivers/DynamicTableManagerDxe/SmbiosTableBuilder.c
View file

@ -207,16 +207,18 @@ BuildAndInstallMultipleSmbiosTables (
UINTN TableCount;
UINTN Index;
TableCount = 0;
Status = Generator->BuildSmbiosTableEx (
Generator,
TableFactoryProtocol,
SmbiosTableInfo,
CfgMgrProtocol,
&SmbiosTable,
&CmObjToken,
&TableCount
);
SmbiosTable = NULL;
CmObjToken = NULL;
TableCount = 0;
Status = Generator->BuildSmbiosTableEx (
Generator,
TableFactoryProtocol,
SmbiosTableInfo,
CfgMgrProtocol,
&SmbiosTable,
&CmObjToken,
&TableCount
);
if (EFI_ERROR (Status)) {
DEBUG ((
DEBUG_ERROR,