uefi-ref/edk2
1
0
Fork 0
mirror of https://github.com/tianocore/edk2 synced 2026-08-27 00:23:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

OvmfPkg/PlatformInitLib: do not ASSERT on an invalid NvVarStore

Browse source 
The varstore lives in writable pflash, so it is external input and an
interrupted write or a crafted image can damage it. That needs an error
path, not an ASSERT: a DEBUG build ends in CpuDeadLoop() with no output
at all, while a RELEASE build already carries on without the emulated
store.

Log the error and return. Both callers ignore the return value, so the
boot continues as it does in a RELEASE build.

Signed-off-by: Denis V. Lunev <den@openvz.org>
This commit is contained in:
Denis V. Lunev 2026-08-11 13:40:05 +02:00
parent 5102939369
commit e822c82b12
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
OvmfPkg/Library/PlatformInitLib/Platform.c
View file

@ -1003,7 +1003,7 @@ PlatformInitEmuVariableNvStore (
ASSERT (Size < EmuVariableNvStoreSize);
if (!PlatformValidateNvVarStore (Base, PcdGet32 (PcdCfvRawDataSize))) {
ASSERT (FALSE);
DEBUG ((DEBUG_ERROR, "Invalid FlashNvStorage, EmuVariableNvStore not initialized.\n"));
return EFI_INVALID_PARAMETER;
}