mirror of
https://github.com/tianocore/edk2
synced 2026-08-27 00:23:19 -04:00
01f75b3927
Replace traditional `#ifndef`/`#define`/`#endif` include guards with
`#pragma` once.
`#pragma once` is a widely supported preprocessor directive that
prevents header files from being included multiple times. It is
supported by all toolchains used to build edk2: GCC, Clang/LLVM, and
MSVC.
Compared to macro-based include guards, `#pragma once`:
- Eliminates the risk of macro name collisions or copy/paste errors
where two headers inadvertently use the same guard macro.
- Eliminate inconsistency in the way include guard macros are named
(e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.).
- Reduces boilerplate (three lines replaced by one).
- Avoids polluting the macro namespace with guard symbols.
- Can improve build times as the preprocessor can skip re-opening the
file entirely, rather than re-reading it to find the matching
`#endif` ("multiple-include optimization").
- Note that some compilers may already optimize traditional include
guards, by recognzining the idiomatic pattern.
This change is made acknowledging that overall portability of the
code will technically be reduced, as `#pragma once` is not part of the
C/C++ standards.
However, this is considered acceptable given:
1. edk2 already defines a subset of supported compilers in
BaseTools/Conf/tools_def.template, all of which have supported
`#pragma once` for over two decades.
2. There have been concerns raised to the project about inconsistent
include guard naming and potential macro collisions.
Approximate compiler support dates:
- MSVC: Supported since Visual C++ 4.2 (1996)
- GCC: Supported since 3.4 (2004)
(http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html)
- Clang (LLVM based): Since initial release in 2007
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
55 lines
2.1 KiB
C
55 lines
2.1 KiB
C
/** @file
|
|
Configuration Manager Helper Library.
|
|
|
|
Copyright (c) 2025, Arm Limited. All rights reserved.<BR>
|
|
SPDX-License-Identifier: BSD-2-Clause-Patent
|
|
**/
|
|
|
|
#pragma once
|
|
|
|
/** Check if an ACPI table is present in the Configuration manager's ACPI table list.
|
|
|
|
@param [in] CfgMgrProtocol Pointer to the Configuration Manager
|
|
Protocol Interface.
|
|
@param [in] AcpiTableId Acpi Table Id.
|
|
|
|
@retval TRUE if the ACPI table is in the list of ACPI tables to install.
|
|
FALSE otherwise.
|
|
**/
|
|
BOOLEAN
|
|
EFIAPI
|
|
CheckAcpiTablePresent (
|
|
IN CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL *CONST CfgMgrProtocol,
|
|
IN ESTD_ACPI_TABLE_ID AcpiTableId
|
|
);
|
|
|
|
/** Get a Proximity Domain Id.
|
|
|
|
Proximity Domain Id are now to be placed in
|
|
CM_ARCH_COMMON_PROXIMITY_DOMAIN_INFO objects rather than in the various
|
|
CmObj using them. This function handles the logic in the selection
|
|
of the ProximityDomainId to use.
|
|
|
|
Proximity Domain Id should be preferably placed in
|
|
CM_ARCH_COMMON_PROXIMITY_DOMAIN_INFO objects now.
|
|
|
|
@param [in] CfgMgrProtocol Pointer to the Configuration Manager
|
|
Protocol Interface.
|
|
@param [in] DefaultDomainId Default per-CmObj Proximity Domain Id.
|
|
The CM_ARCH_COMMON_PROXIMITY_DOMAIN_INFO
|
|
should be preferably used.
|
|
@param [in] Token Token referencing a
|
|
CM_ARCH_COMMON_PROXIMITY_DOMAIN_INFO object.
|
|
@param [out] DomainId If Success, contains DomainId to use.
|
|
|
|
@retval EFI_SUCCESS Table generated successfully.
|
|
@retval EFI_INVALID_PARAMETER The table pointer is NULL or invalid.
|
|
**/
|
|
EFI_STATUS
|
|
EFIAPI
|
|
GetProximityDomainId (
|
|
IN CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL *CfgMgrProtocol,
|
|
IN UINT32 DefaultDomainId,
|
|
IN CM_OBJECT_TOKEN Token,
|
|
OUT UINT32 *DomainId
|
|
);
|