mirror of
https://github.com/tianocore/edk2
synced 2026-08-27 00:23:19 -04:00
7a934d0bef
Replace traditional `#ifndef`/`#define`/`#endif` include guards with
`#pragma` once.
`#pragma once` is a widely supported preprocessor directive that
prevents header files from being included multiple times. It is
supported by all toolchains used to build edk2: GCC, Clang/LLVM, and
MSVC.
Compared to macro-based include guards, `#pragma once`:
- Eliminates the risk of macro name collisions or copy/paste errors
where two headers inadvertently use the same guard macro.
- Eliminate inconsistency in the way include guard macros are named
(e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.).
- Reduces boilerplate (three lines replaced by one).
- Avoids polluting the macro namespace with guard symbols.
- Can improve build times as the preprocessor can skip re-opening the
file entirely, rather than re-reading it to find the matching
`#endif` ("multiple-include optimization").
- Note that some compilers may already optimize traditional include
guards, by recognzining the idiomatic pattern.
This change is made acknowledging that overall portability of the
code will technically be reduced, as `#pragma once` is not part of the
C/C++ standards.
However, this is considered acceptable given:
1. edk2 already defines a subset of supported compilers in
BaseTools/Conf/tools_def.template, all of which have supported
`#pragma once` for over two decades.
2. There have been concerns raised to the project about inconsistent
include guard naming and potential macro collisions.
Approximate compiler support dates:
- MSVC: Supported since Visual C++ 4.2 (1996)
- GCC: Supported since 3.4 (2004)
(http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html)
- Clang (LLVM based): Since initial release in 2007
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
83 lines
3 KiB
C
83 lines
3 KiB
C
/** @file
|
|
|
|
Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
|
|
SPDX-License-Identifier: BSD-2-Clause-Patent
|
|
|
|
**/
|
|
|
|
#pragma once
|
|
|
|
#include <Protocol/DevicePath.h>
|
|
|
|
///
|
|
/// Global ID for the EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI.
|
|
///
|
|
#define EDKII_NVME_EXPRESS_HOST_CONTROLLER_PPI_GUID \
|
|
{ \
|
|
0xcae3aa63, 0x676f, 0x4da3, { 0xbd, 0x50, 0x6c, 0xc5, 0xed, 0xde, 0x9a, 0xad } \
|
|
}
|
|
|
|
//
|
|
// Forward declaration for the EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI.
|
|
//
|
|
typedef struct _EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI;
|
|
|
|
/**
|
|
Get the MMIO base address of NVM Express host controller.
|
|
|
|
@param[in] This The PPI instance pointer.
|
|
@param[in] ControllerId The ID of the NVM Express host controller.
|
|
@param[out] MmioBar The MMIO base address of the controller.
|
|
|
|
@retval EFI_SUCCESS The operation succeeds.
|
|
@retval EFI_INVALID_PARAMETER The parameters are invalid.
|
|
@retval EFI_NOT_FOUND The specified NVM Express host controller not
|
|
found.
|
|
|
|
**/
|
|
typedef
|
|
EFI_STATUS
|
|
(EFIAPI *EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR)(
|
|
IN EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI *This,
|
|
IN UINT8 ControllerId,
|
|
OUT UINTN *MmioBar
|
|
);
|
|
|
|
/**
|
|
Get the device path of NVM Express host controller.
|
|
|
|
@param[in] This The PPI instance pointer.
|
|
@param[in] ControllerId The ID of the NVM Express host controller.
|
|
@param[out] DevicePathLength The length of the device path in bytes specified
|
|
by DevicePath.
|
|
@param[out] DevicePath The device path of NVM Express host controller.
|
|
This field re-uses EFI Device Path Protocol as
|
|
defined by Section 10.2 EFI Device Path Protocol
|
|
of UEFI 2.7 Specification.
|
|
|
|
@retval EFI_SUCCESS The operation succeeds.
|
|
@retval EFI_INVALID_PARAMETER The parameters are invalid.
|
|
@retval EFI_NOT_FOUND The specified NVM Express host controller not
|
|
found.
|
|
@retval EFI_OUT_OF_RESOURCES The operation fails due to lack of resources.
|
|
|
|
**/
|
|
typedef
|
|
EFI_STATUS
|
|
(EFIAPI *EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATH)(
|
|
IN EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI *This,
|
|
IN UINT8 ControllerId,
|
|
OUT UINTN *DevicePathLength,
|
|
OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath
|
|
);
|
|
|
|
//
|
|
// This PPI contains a set of services to interact with the NVM Express host
|
|
// controller.
|
|
//
|
|
struct _EDKII_NVM_EXPRESS_HOST_CONTROLLER_PPI {
|
|
EDKII_NVM_EXPRESS_HC_GET_MMIO_BAR GetNvmeHcMmioBar;
|
|
EDKII_NVM_EXPRESS_HC_GET_DEVICE_PATH GetNvmeHcDevicePath;
|
|
};
|
|
|
|
extern EFI_GUID gEdkiiPeiNvmExpressHostControllerPpiGuid;
|