mirror of
https://github.com/tianocore/edk2
synced 2026-08-27 00:23:19 -04:00
Replace traditional `#ifndef`/`#define`/`#endif` include guards with
`#pragma` once.
`#pragma once` is a widely supported preprocessor directive that
prevents header files from being included multiple times. It is
supported by all toolchains used to build edk2: GCC, Clang/LLVM, and
MSVC.
Compared to macro-based include guards, `#pragma once`:
- Eliminates the risk of macro name collisions or copy/paste errors
where two headers inadvertently use the same guard macro.
- Eliminate inconsistency in the way include guard macros are named
(e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.).
- Reduces boilerplate (three lines replaced by one).
- Avoids polluting the macro namespace with guard symbols.
- Can improve build times as the preprocessor can skip re-opening the
file entirely, rather than re-reading it to find the matching
`#endif` ("multiple-include optimization").
- Note that some compilers may already optimize traditional include
guards, by recognzining the idiomatic pattern.
This change is made acknowledging that overall portability of the
code will technically be reduced, as `#pragma once` is not part of the
C/C++ standards.
However, this is considered acceptable given:
1. edk2 already defines a subset of supported compilers in
BaseTools/Conf/tools_def.template, all of which have supported
`#pragma once` for over two decades.
2. There have been concerns raised to the project about inconsistent
include guard naming and potential macro collisions.
Approximate compiler support dates:
- MSVC: Supported since Visual C++ 4.2 (1996)
- GCC: Supported since 3.4 (2004)
(http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html)
- Clang (LLVM based): Since initial release in 2007
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
56 lines
1.7 KiB
C
56 lines
1.7 KiB
C
/** @file
|
|
Universal Payload general definitions.
|
|
|
|
Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
|
|
SPDX-License-Identifier: BSD-2-Clause-Patent
|
|
|
|
@par Revision Reference:
|
|
- Universal Payload Specification 0.75 (https://universalpayload.github.io/documentation/)
|
|
**/
|
|
|
|
#pragma once
|
|
|
|
/**
|
|
Main entry point to Universal Payload.
|
|
|
|
@param HobList Pointer to the beginning of the HOB List from boot loader.
|
|
**/
|
|
typedef VOID (EFIAPI *UNIVERSAL_PAYLOAD_ENTRY)(VOID *HobList);
|
|
|
|
#define UNIVERSAL_PAYLOAD_IDENTIFIER SIGNATURE_32('P', 'L', 'D', 'H')
|
|
#define UNIVERSAL_PAYLOAD_INFO_SEC_NAME ".upld_info"
|
|
#define UNIVERSAL_PAYLOAD_EXTRA_SEC_NAME_PREFIX ".upld."
|
|
#define UNIVERSAL_PAYLOAD_EXTRA_SEC_NAME_PREFIX_LENGTH (sizeof (UNIVERSAL_PAYLOAD_EXTRA_SEC_NAME_PREFIX) - 1)
|
|
|
|
#pragma pack(1)
|
|
|
|
typedef struct {
|
|
UINT32 Identifier;
|
|
UINT32 HeaderLength;
|
|
UINT16 SpecRevision;
|
|
UINT8 Reserved[2];
|
|
UINT32 Revision;
|
|
UINT32 Attribute;
|
|
UINT32 Capability;
|
|
CHAR8 ProducerId[16];
|
|
CHAR8 ImageId[16];
|
|
} UNIVERSAL_PAYLOAD_INFO_HEADER;
|
|
|
|
typedef struct {
|
|
UINT8 Revision;
|
|
UINT8 Reserved;
|
|
UINT16 Length;
|
|
} UNIVERSAL_PAYLOAD_GENERIC_HEADER;
|
|
|
|
#pragma pack()
|
|
|
|
/**
|
|
Returns the size of a structure of known type, up through and including a specified field.
|
|
|
|
@param TYPE The name of the data structure that contains the field specified by Field.
|
|
@param Field The name of the field in the data structure.
|
|
|
|
@return size, in bytes.
|
|
|
|
**/
|
|
#define UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD(TYPE, Field) (OFFSET_OF(TYPE, Field) + sizeof (((TYPE *) 0)->Field))
|