mirror of
https://github.com/tianocore/edk2
synced 2026-08-27 00:23:19 -04:00
The return value stored in Status after call to SetDriveParameters is not made of any use thereafter and hence it remains as UNUSED. Based on Hao's findings (https://edk2.groups.io/g/devel/message/106844), the successful execution of SetDriveParameters() is not mandatory for initializing IDE mode of a hard disk device. Hence remove the 'Status' assignment of the return value from SetDriveParameters() and instead add error checks & DEBUG_WARN level messages within SetDriveParameters() function after sending INIT_DRIVE_PARAM & SET_MULTIPLE_MODE ATA commands. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4204 Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com> Signed-off-by: Ranbir Singh <rsingh@ventanamicro.com> Reviewed-by: Hao A Wu <hao.a.wu@intel.com> |
||
|---|---|---|
| .. | ||
| AhciMode.c | ||
| AhciMode.h | ||
| AtaAtapiPassThru.c | ||
| AtaAtapiPassThru.h | ||
| AtaAtapiPassThru.inf | ||
| AtaAtapiPassThruDxe.uni | ||
| AtaAtapiPassThruDxeExtra.uni | ||
| ComponentName.c | ||
| IdeMode.c | ||
| IdeMode.h | ||