mirror of
https://github.com/tianocore/edk2
synced 2026-08-27 00:23:19 -04:00
40a45b5a2b
The patch "[PATCH v3 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver architecture independent" (https://edk2.groups.io/g/devel/message/109178) removed ArmPkg/ArmPkg.dec from the Packages section in the INF file: StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf This change was done as part of making the StandaloneMmCpu driver architecture independent. Although this change is correct, it results in a side effect here some platforms that utilise PCDs declared in ArmPkg.dec are no longer declared. An example of this issue can be seen when building edk2-platforms/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc $ build -a AARCH64 -t GCC -p Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc build.py... /mnt/source/edk2-platforms/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf(23): error F001: PCD (gArmTokenSpaceGuid.PcdFdBaseAddress) used in FDF is not declared in DEC files. As seen above, removing ArmPkg.dec from the Packages section in the StandAloneMmCpu Driver Inf file triggers build failure. Although, ArmPkg.dec is included in other Library Instances, the build system does not include the declarations from .dec files defined in Library instances. The build system only includes the PCD declarations from DEC files that are specified in INF files for Modules (components). Therefore, extend the build system to include the Packages from Library Instances so that the PCD declarations from the respective package DEC files are included. This patch can be seen on https://github.com/LeviYeoReum/edk2/tree/levi/2848_dec_check_on_library Signed-off-by: levi.yun <yeoreum.yun@arm.com> Tested-by: Pierre Gondois <pierre.gondois@arm.com> Reviewed-by: Rebecca Cran <rebecca@bsdio.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| AutoGen.py | ||
| AutoGenWorker.py | ||
| BuildEngine.py | ||
| DataPipe.py | ||
| GenC.py | ||
| GenDepex.py | ||
| GenMake.py | ||
| GenPcdDb.py | ||
| GenVar.py | ||
| IdfClassObject.py | ||
| IncludesAutoGen.py | ||
| InfSectionParser.py | ||
| ModuleAutoGen.py | ||
| ModuleAutoGenHelper.py | ||
| PlatformAutoGen.py | ||
| StrGather.py | ||
| UniClassObject.py | ||
| ValidCheckingInfoObject.py | ||
| WorkspaceAutoGen.py | ||