mirror of
https://github.com/tianocore/edk2
synced 2026-08-27 00:23:19 -04:00
Replace traditional `#ifndef`/`#define`/`#endif` include guards with
`#pragma` once.
`#pragma once` is a widely supported preprocessor directive that
prevents header files from being included multiple times. It is
supported by all toolchains used to build edk2: GCC, Clang/LLVM, and
MSVC.
Note: Headers taken directly from external projects, such as those
in OvmfPkg/Include/IndustryStandard/Xen/ were not modified since they
may be periodically re-synced and do not follow other edk2 coding
stadards.
Compared to macro-based include guards, `#pragma once`:
- Eliminates the risk of macro name collisions or copy/paste errors
where two headers inadvertently use the same guard macro.
- Eliminate inconsistency in the way include guard macros are named
(e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.).
- Reduces boilerplate (three lines replaced by one).
- Avoids polluting the macro namespace with guard symbols.
- Can improve build times as the preprocessor can skip re-opening the
file entirely, rather than re-reading it to find the matching
`#endif` ("multiple-include optimization").
- Note that some compilers may already optimize traditional include
guards, by recognzining the idiomatic pattern.
This change is made acknowledging that overall portability of the
code will technically be reduced, as `#pragma once` is not part of the
C/C++ standards.
However, this is considered acceptable given:
1. edk2 already defines a subset of supported compilers in
BaseTools/Conf/tools_def.template, all of which have supported
`#pragma once` for over two decades.
2. There have been concerns raised to the project about inconsistent
include guard naming and potential macro collisions.
Approximate compiler support dates:
- MSVC: Supported since Visual C++ 4.2 (1996)
- GCC: Supported since 3.4 (2004)
(http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html)
- Clang (LLVM based): Since initial release in 2007
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
74 lines
2.4 KiB
C
74 lines
2.4 KiB
C
/** @file
|
|
Library to define platform customization functions for a
|
|
Firmare Volume Block driver.
|
|
|
|
Copyright (c) 2009 - 2011, Intel Corporation. All rights reserved.<BR>
|
|
SPDX-License-Identifier: BSD-2-Clause-Patent
|
|
|
|
**/
|
|
|
|
#pragma once
|
|
|
|
#include <Protocol/FirmwareVolumeBlock.h>
|
|
|
|
/**
|
|
This function will be called following a call to the
|
|
EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL Read function.
|
|
|
|
@param[in] This The EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL instance.
|
|
@param[in] Lba The starting logical block index
|
|
from which to read.
|
|
@param[in] Offset Offset into the block at which to begin reading.
|
|
@param[in] NumBytes The number of bytes read.
|
|
@param[in] Buffer Pointer to the buffer that was read, and will be
|
|
returned to the caller.
|
|
|
|
**/
|
|
VOID
|
|
EFIAPI
|
|
PlatformFvbDataRead (
|
|
IN CONST EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL *This,
|
|
IN EFI_LBA Lba,
|
|
IN UINTN Offset,
|
|
IN UINTN NumBytes,
|
|
IN UINT8 *Buffer
|
|
);
|
|
|
|
/**
|
|
This function will be called following a call to the
|
|
EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL Write function.
|
|
|
|
@param[in] This EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL instance.
|
|
@param[in] Lba The starting logical block index to written to.
|
|
@param[in] Offset Offset into the block at which to begin writing.
|
|
@param[in] NumBytes The number of bytes written.
|
|
@param[in] Buffer Pointer to the buffer that was written.
|
|
|
|
**/
|
|
VOID
|
|
EFIAPI
|
|
PlatformFvbDataWritten (
|
|
IN CONST EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL *This,
|
|
IN EFI_LBA Lba,
|
|
IN UINTN Offset,
|
|
IN UINTN NumBytes,
|
|
IN UINT8 *Buffer
|
|
);
|
|
|
|
/**
|
|
This function will be called following a call to the
|
|
EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL Erase function.
|
|
|
|
@param This Indicates the EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL
|
|
instance.
|
|
@param List The variable argument list as documented for
|
|
the EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL Erase
|
|
function.
|
|
|
|
**/
|
|
VOID
|
|
EFIAPI
|
|
PlatformFvbBlocksErased (
|
|
IN CONST EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL *This,
|
|
IN VA_LIST List
|
|
);
|