mirror of
https://github.com/tianocore/edk2
synced 2026-08-27 00:23:19 -04:00
8472271dae
Replace traditional `#ifndef`/`#define`/`#endif` include guards with
`#pragma` once.
`#pragma once` is a widely supported preprocessor directive that
prevents header files from being included multiple times. It is
supported by all toolchains used to build edk2: GCC, Clang/LLVM, and
MSVC.
Compared to macro-based include guards, `#pragma once`:
- Eliminates the risk of macro name collisions or copy/paste errors
where two headers inadvertently use the same guard macro.
- Eliminate inconsistency in the way include guard macros are named
(e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.).
- Reduces boilerplate (three lines replaced by one).
- Avoids polluting the macro namespace with guard symbols.
- Can improve build times as the preprocessor can skip re-opening the
file entirely, rather than re-reading it to find the matching
`#endif` ("multiple-include optimization").
- Note that some compilers may already optimize traditional include
guards, by recognzining the idiomatic pattern.
This change is made acknowledging that overall portability of the
code will technically be reduced, as `#pragma once` is not part of the
C/C++ standards.
However, this is considered acceptable given:
1. edk2 already defines a subset of supported compilers in
BaseTools/Conf/tools_def.template, all of which have supported
`#pragma once` for over two decades.
2. There have been concerns raised to the project about inconsistent
include guard naming and potential macro collisions.
Approximate compiler support dates:
- MSVC: Supported since Visual C++ 4.2 (1996)
- GCC: Supported since 3.4 (2004)
(http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html)
- Clang (LLVM based): Since initial release in 2007
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
65 lines
1.7 KiB
C
65 lines
1.7 KiB
C
/** @file
|
|
Declares titlebar interface functions.
|
|
|
|
Copyright (c) 2005 - 2011, Intel Corporation. All rights reserved. <BR>
|
|
SPDX-License-Identifier: BSD-2-Clause-Patent
|
|
|
|
**/
|
|
|
|
#pragma once
|
|
|
|
/**
|
|
Initialize a title bar.
|
|
|
|
@param[in] Prompt The prompt to print in the title bar.
|
|
|
|
@retval EFI_SUCCESS The initialization was successful.
|
|
@retval EFI_OUT_OF_RESOURCES A memory allocation failed.
|
|
**/
|
|
EFI_STATUS
|
|
MainTitleBarInit (
|
|
CONST CHAR16 *Prompt
|
|
);
|
|
|
|
/**
|
|
Clean up the memory used.
|
|
**/
|
|
VOID
|
|
MainTitleBarCleanup (
|
|
VOID
|
|
);
|
|
|
|
typedef enum {
|
|
FileTypeNone,
|
|
FileTypeAscii,
|
|
FileTypeUnicode,
|
|
FileTypeDiskBuffer,
|
|
FileTypeMemBuffer,
|
|
FileTypeFileBuffer
|
|
} EDIT_FILE_TYPE;
|
|
|
|
/**
|
|
Refresh function for MainTitleBar
|
|
|
|
@param[in] FileName The open file's name (or NULL).
|
|
@param[in] FileType The type fo the file.
|
|
@param[in] ReadOnly TRUE if the file is read only. FALSE otherwise.
|
|
@param[in] Modified TRUE if the file was modified. FALSE otherwise.
|
|
@param[in] LastCol The last printable column.
|
|
@param[in] LastRow The last printable row.
|
|
@param[in] Offset The offset into the file. (only for mem/disk)
|
|
@param[in] Size The file's size. (only for mem/disk)
|
|
|
|
@retval EFI_SUCCESS The operation was successful.
|
|
**/
|
|
EFI_STATUS
|
|
MainTitleBarRefresh (
|
|
IN CONST CHAR16 *FileName OPTIONAL,
|
|
IN CONST EDIT_FILE_TYPE FileType,
|
|
IN CONST BOOLEAN ReadOnly,
|
|
IN CONST BOOLEAN Modified,
|
|
IN CONST UINTN LastCol,
|
|
IN CONST UINTN LastRow,
|
|
IN CONST UINTN Offset,
|
|
IN CONST UINTN Size
|
|
);
|