mirror of
https://github.com/tianocore/edk2
synced 2026-08-27 00:23:19 -04:00
fac297724e
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4540 Bug Details: PixieFail Bug #7 CVE-2023-45235 CVSS 8.3 : CVSS:3.1/AV:A/AC:L/PR:N/UI:N/S:U/C:H/I:L/A:H CWE-119 Improper Restriction of Operations within the Bounds of a Memory Buffer Buffer overflow when handling Server ID option from a DHCPv6 proxy Advertise message Change Overview: Performs two checks 1. Checks that the length of the duid is accurate > + // > + // Check that the minimum and maximum requirements are met > + // > + if ((OpLen < PXEBC_MIN_SIZE_OF_DUID) || (OpLen > PXEBC_MAX_SIZE_OF_DUID)) { > + Status = EFI_INVALID_PARAMETER; > + goto ON_ERROR; > + } 2. Ensures that the amount of data written to the buffer is tracked and never exceeds that > + // > + // Check that the option length is valid. > + // > + if ((DiscoverLen + OpLen + PXEBC_COMBINED_SIZE_OF_OPT_CODE_AND_LEN) > DiscoverLenNeeded) { > + Status = EFI_OUT_OF_RESOURCES; > + goto ON_ERROR; > + } Additional code clean up and fix for memory leak in case Option was NULL Cc: Saloni Kasbekar <saloni.kasbekar@intel.com> Cc: Zachary Clark-williams <zachary.clark-williams@intel.com> Signed-off-by: Doug Flick [MSFT] <doug.edk2@gmail.com> Reviewed-by: Saloni Kasbekar <saloni.kasbekar@intel.com> |
||
|---|---|---|
| .. | ||
| Application/VConfig | ||
| ArpDxe | ||
| Dhcp4Dxe | ||
| Dhcp6Dxe | ||
| DnsDxe | ||
| DpcDxe | ||
| HttpBootDxe | ||
| HttpDxe | ||
| HttpUtilitiesDxe | ||
| Include | ||
| Ip4Dxe | ||
| Ip6Dxe | ||
| IScsiDxe | ||
| Library | ||
| MnpDxe | ||
| Mtftp4Dxe | ||
| Mtftp6Dxe | ||
| SnpDxe | ||
| TcpDxe | ||
| Test | ||
| TlsAuthConfigDxe | ||
| TlsDxe | ||
| Udp4Dxe | ||
| Udp6Dxe | ||
| UefiPxeBcDxe | ||
| VlanConfigDxe | ||
| WifiConnectionManagerDxe | ||
| Network.dsc.inc | ||
| Network.fdf.inc | ||
| NetworkBuildOptions.dsc.inc | ||
| NetworkComponents.dsc.inc | ||
| NetworkDefines.dsc.inc | ||
| NetworkLibs.dsc.inc | ||
| NetworkPcds.dsc.inc | ||
| NetworkPkg.ci.yaml | ||
| NetworkPkg.dec | ||
| NetworkPkg.dsc | ||
| NetworkPkg.uni | ||
| NetworkPkgExtra.uni | ||