uefi-ref/qemu
1
0
Fork 0
mirror of https://gitlab.com/qemu-project/qemu.git synced 2026-08-26 22:23:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests/qtest/ide-test: cover raw (2352-byte) ATAPI CD reads

Browse source 
READ CD with the field-selector set to 0xf8 returns full 2352-byte
raw sectors (sync + header + 2048 data + EDC/ECC), driving the ATAPI
raw read path that READ10 never touches. Add a send_scsi_cdb_read_cd()
helper and a CDROM_RAW flag to cdrom_read_impl(), then exercise both
PIO and DMA. The PIO case uses a byte-count limit spanning several
raw sectors so the device must rebuffer mid-burst, and each sector's
2048-byte payload is verified at its in-sector offset.

Signed-off-by: Denis V. Lunev <den@openvz.org>
This commit is contained in:
Denis V. Lunev 2026-06-19 02:29:11 +02:00
parent fe543c2d78
commit 502dbdfd96
1 changed files with 70 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

76
tests/qtest/ide-test.c
View file

@ -48,6 +48,10 @@
#define ATAPI_BLOCK_SIZE 2048
/* Raw READ CD sector: 12 sync + 4 header + 2048 data + 288 EDC/ECC. */
#define ATAPI_RAW_SIZE 2352
#define ATAPI_RAW_DATA 16
/* How many bytes to receive via ATAPI PIO at one time.
* Must be less than 0xFFFF. */
#define BYTE_COUNT_LIMIT 5120
@ -982,6 +986,41 @@ static void send_scsi_cdb_read10(QPCIDevice *dev, QPCIBar ide_bar,
}
}
typedef struct ReadCDCDB {
uint8_t opcode;
uint8_t sector_type;
uint32_t lba;
uint8_t length[3];
uint8_t main_channel;
uint8_t sub_channel;
uint8_t control;
} __attribute__((__packed__)) ReadCDCDB;
static void send_scsi_cdb_read_cd(QPCIDevice *dev, QPCIBar ide_bar,
uint64_t lba, int nblocks)
{
ReadCDCDB pkt = { };
int i;
g_assert_cmpint(lba, <=, UINT32_MAX);
g_assert_cmpint(nblocks, >=, 0);
g_assert_cmpint(nblocks, <=, 0xffffff);
/* Construct SCSI CDB packet */
pkt.opcode = 0xbe;
pkt.lba = cpu_to_be32(lba);
pkt.length[0] = (nblocks >> 16) & 0xff;
pkt.length[1] = (nblocks >> 8) & 0xff;
pkt.length[2] = nblocks & 0xff;
pkt.main_channel = 0xf8; /* sync + headers + user data + EDC/ECC: 2352 */
/* Send Packet */
for (i = 0; i < sizeof(ReadCDCDB) / 2; i++) {
qpci_io_writew(dev, ide_bar, reg_data,
le16_to_cpu(((uint16_t *)&pkt)[i]));
}
}
static void nsleep(QTestState *qts, int64_t nsecs)
{
const struct timespec val = { .tv_nsec = nsecs };
@ -1036,10 +1075,12 @@ static void ide_wait_intr(QTestState *qts, int irq)
#define CDROM_PIO 0
#define CDROM_DMA (1 << 0)
#define CDROM_RAW (1 << 1)
static void cdrom_read_impl(int nblocks, unsigned flags)
{
bool dma = flags & CDROM_DMA;
bool raw = flags & CDROM_RAW;
QTestState *qts;
QPCIDevice *dev;
QPCIBar bmdma_bar, ide_bar;
@ -1047,8 +1088,11 @@ static void cdrom_read_impl(int nblocks, unsigned flags)
int patt_blocks = MAX(16, nblocks);
size_t patt_len = ATAPI_BLOCK_SIZE * patt_blocks;
char *pattern = g_malloc(patt_len);
size_t rxsize = ATAPI_BLOCK_SIZE * nblocks;
unsigned xfer = raw ? ATAPI_RAW_SIZE : ATAPI_BLOCK_SIZE;
size_t rxsize = xfer * nblocks;
uint16_t *rx = g_malloc0(rxsize);
void (*send_cdb)(QPCIDevice *, QPCIBar, uint64_t, int) =
raw ? send_scsi_cdb_read_cd : send_scsi_cdb_read10;
int i, j;
uint8_t data;
uint16_t limit;
@ -1075,8 +1119,7 @@ static void cdrom_read_impl(int nblocks, unsigned flags)
prdt[0].size = cpu_to_le32(rxsize | PRDT_EOT);
send_dma_request_dev(qts, dev, bmdma_bar, ide_bar, CMD_PACKET, 0,
nblocks, prdt, ARRAY_SIZE(prdt),
send_scsi_cdb_read10);
nblocks, prdt, ARRAY_SIZE(prdt), send_cdb);
qtest_memread(qts, guest_buf, rx, rxsize);
} else {
@ -1093,8 +1136,7 @@ static void cdrom_read_impl(int nblocks, unsigned flags)
assert_bit_set(data, DRQ | DRDY);
assert_bit_clear(data, ERR | DF | BSY);
/* SCSI CDB (READ10) -- read n*2048 bytes from block 0 */
send_scsi_cdb_read10(dev, ide_bar, 0, nblocks);
send_cdb(dev, ide_bar, 0, nblocks);
/*
* Read data back: occurs in bursts of 'BYTE_COUNT_LIMIT' bytes.
@ -1134,7 +1176,17 @@ static void cdrom_read_impl(int nblocks, unsigned flags)
assert_bit_clear(data, DRQ | ERR | DF | BSY);
}
g_assert_cmpint(memcmp(pattern, rx, rxsize), ==, 0);
if (raw) {
/* The 2048-byte payload of each raw sector sits past its header. */
for (i = 0; i < nblocks; i++) {
uint8_t *sec = (uint8_t *)rx + i * ATAPI_RAW_SIZE + ATAPI_RAW_DATA;
g_assert_cmpint(memcmp(sec, pattern + i * ATAPI_BLOCK_SIZE,
ATAPI_BLOCK_SIZE), ==, 0);
}
} else {
g_assert_cmpint(memcmp(pattern, rx, rxsize), ==, 0);
}
g_free(pattern);
g_free(rx);
@ -1163,6 +1215,16 @@ static void test_cdrom_dma_large(void)
cdrom_read_impl(BYTE_COUNT_LIMIT * 4 / ATAPI_BLOCK_SIZE, CDROM_DMA);
}
static void test_cdrom_pio_raw(void)
{
cdrom_read_impl(4, CDROM_RAW);
}
static void test_cdrom_dma_raw(void)
{
cdrom_read_impl(4, CDROM_DMA | CDROM_RAW);
}
int main(int argc, char **argv)
{
const char *base;
@ -1223,6 +1285,8 @@ int main(int argc, char **argv)
qtest_add_func("/ide/cdrom/pio_large", test_cdrom_pio_large);
qtest_add_func("/ide/cdrom/dma", test_cdrom_dma);
qtest_add_func("/ide/cdrom/dma_large", test_cdrom_dma_large);
qtest_add_func("/ide/cdrom/pio_raw", test_cdrom_pio_raw);
qtest_add_func("/ide/cdrom/dma_raw", test_cdrom_dma_raw);
ret = g_test_run();