mirror of
https://gitlab.com/qemu-project/qemu.git
synced 2026-08-26 22:23:12 -04:00
c0e370474b
Every callsite of block_signals() checks its return value, except
the one in sparc64_set_context(). Generally you need to check,
because the standard pattern is:
if (block_signals()) {
return -QEMU_ERESTARTSYS;
}
/* do some blocking syscall */
and we need to take any pending signal before we do the blocking
operation, not afterwards.
The use in sparc64_set_context() doesn't do this. It doesn't have to
because the operations it is doing aren't blocking, so it won't get
into "we didn't take the signal that we should have" races that
blocking syscalls do. But it does make this way of updating the
signal mask inconsistent with how we do it in do_sigprocmask().
do_sigprocmask() does the usual "return -QEMU_ERESTARTSYS", so a
pending signal that was not blocked by the old signal mask and which
will be blocked by the new mask we're about to install will be taken
before we change the mask. sparc64_set_context() doesn't check the
return value, so we won't take that pending signal. That's not
wrong, because it just means the signal lost the race with the
executing code. But it seems clearer to behave the same way as
do_sigprocmask(), not differently.
Make sparc64_set_context() check the return value of block_signals()
and return early if there's a pending signal to take. We don't need
to return a separate return code to indicate this because the main
loop handles it the same either way.
Coverity CID: 1660058
Fixes:
|
||
|---|---|---|
| .. | ||
| cpu_loop.c | ||
| cpu_loop.h | ||
| elfload.c | ||
| meson.build | ||
| signal.c | ||
| sockbits.h | ||
| syscall.tbl | ||
| syscallhdr.sh | ||
| target_cpu.h | ||
| target_elf.h | ||
| target_errno_defs.h | ||
| target_fcntl.h | ||
| target_mman.h | ||
| target_prctl.h | ||
| target_proc.h | ||
| target_ptrace.h | ||
| target_resource.h | ||
| target_signal.h | ||
| target_structs.h | ||
| target_syscall.h | ||
| termbits.h | ||