qemu/io
Peter Maydell 7297a02ca8 io/channel-socket: Document why we can ignore socket_set_cork() errors
In qio_channel_socket_set_cork(), we call socket_set_cork() but
ignore its success/failure return value.  This is OK because we are
implementing qio_channel_set_cork() here, and that function's API
documentation states that the setting is merely a hint.  So even if
setting TCP_CORK on the underlying socket fails for some reason, this
isn't going to be a problem for the caller; correspondingly the
qio_channel_set_cork() function has no error return.

Add a comment in qio_channel_socket_set_cork() explaining why we
don't check for errors.

Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/2254
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2026-07-07 13:35:46 +01:00
..
channel-buffer.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
channel-command.c treewide: use qemu_set_blocking instead of g_unix_set_fd_nonblocking 2025-09-19 12:46:07 +01:00
channel-file.c treewide: use qemu_set_blocking instead of g_unix_set_fd_nonblocking 2025-09-19 12:46:07 +01:00
channel-null.c qom: Have class_init() take a const data argument 2025-04-25 17:00:41 +02:00
channel-socket.c io/channel-socket: Document why we can ignore socket_set_cork() errors 2026-07-07 13:35:46 +01:00
channel-tls.c io: Fix TLS bye task leak 2026-03-17 13:34:12 -03:00
channel-util.c io: follow coroutine AioContext in qio_channel_yield() 2023-09-07 20:32:11 -05:00
channel-watch.c error: Kill @error_warn 2025-10-01 08:33:24 +02:00
channel-websock.c io: use g_clear_handle_id() for GSource cleanup 2026-05-06 16:10:46 +02:00
channel.c io/channel: introduce qio_channel_pwrite{v,}_all() 2026-04-23 12:14:50 -03:00
dns-resolver.c io: Fix partial struct copy in qio_dns_resolver_lookup_sync_inet() 2025-05-22 11:24:41 +01:00
meson.build Revert "meson: Propagate gnutls dependency" 2024-07-03 18:41:26 +02:00
net-listener.c io/net-listener: move mutex init to instance_init 2026-05-11 23:59:12 +04:00
task.c io: separate freeing of tasks from marking them as complete 2026-03-03 10:22:46 +00:00
trace-events qio: Prepare NetListener to use AioContext 2025-11-13 10:54:50 -06:00
trace.h trace: switch position of headers to what Meson requires 2020-08-21 06:18:24 -04:00