Commit graph

16 commits

Author SHA1 Message Date
maziggy
a94f1ef4ff Updated CONTRIBUTING.md 2026-08-01 08:28:06 +02:00
maziggy
7d4dfd5a7d fix(vp): stop uvloop from silently truncating VP FTP uploads (#1896)
Native (non-Docker) installs launched uvicorn without --loop asyncio, so
uvicorn[standard] auto-selected uvloop. uvloop's SSL layer drops
already-received but still-buffered data when the client closes the data
connection without a TLS close_notify while the reader is flow-control
paused on slow storage. cmd_STOR writes each chunk to disk inside the read
loop, so a slow consumer falls behind, the tail is lost, read() returns a
clean EOF, and the loop exits with no exception -- the server acked 226 for
a file it truncated itself, then archived, queued, and forwarded the corrupt
3MF to the real printer.

Fix in two independent layers:

1. Remove the trigger: add --loop asyncio to every native launch path,
   matching the Dockerfile -- deploy/bambuddy.service, install/install.sh
   (systemd + launchd), spoolbuddy/install/install.sh, the Windows NSSM
   service, README, CONTRIBUTING dev command.

2. Defense in depth (loop-independent): cmd_STOR now validates that a
   received .3mf opens as a ZIP (reads the central directory, no
   decompression) before replying 226. A truncated/corrupt file is dropped
   and answered with 426, and on_file_received never runs -- so a broken
   upload surfaces as an immediate slicer-side send error instead of being
   archived and pushed to the printer. Scoped to .3mf; other filetypes pass
   through unchanged.
2026-07-05 10:32:13 +02:00
Ed
4c67d8a4e1
feat: Unify print dispatch through the scheduler (#1625) 2026-06-26 12:31:48 +02:00
maziggy
1b284a9e39 Updated CONTRIBUTING.md 2026-04-24 09:47:45 +02:00
maziggy
a45d2f444a Updated CONTRIBUTING.md 2026-04-10 17:50:46 +02:00
maziggy
a12b7e42dd Updated CONTRIBUTING.md 2026-04-10 16:32:33 +02:00
maziggy
4c27ee680b docs: require companion docs PRs for user-visible changes 2026-04-10 15:20:02 +02:00
maziggy
af8f7a01d9 Updated CONTRIBUTING.md 2026-04-05 12:15:12 +02:00
maziggy
1e7173fae6 Updated CONTRIBUTING.md 2026-03-18 07:32:31 +01:00
maziggy
d9049e65b1 Updated CONTRIBUTING.md 2026-03-15 16:02:43 +01:00
Wesley Silva
7ce2048e09 Fixing typo on CONTRIBUTING.md 2026-02-17 20:09:47 +00:00
Wesley Silva
3291e8c6f9 Added translation to Brazilian Portuguese on existing strings. 2026-02-17 19:49:57 +00:00
DevZwF
ce4c56fe86 adding french 2026-02-12 23:31:10 -05:00
maziggy
8503cbc5bf Updated CONTRIBUTING.md 2026-02-08 09:02:22 +01:00
maziggy
c15fb83af8 Updated CONTRIBUTING.md 2026-02-06 14:56:05 +01:00
maziggy
ac6cbd757a - Added
- .github/FUNDING.yml
  - CODE_OF_CONDUCT.md
  - CONTRIBUTING.md
  - SECURITY.md
2025-12-30 10:58:34 +01:00