mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-10 14:27:00 -04:00
b1e871d51c
## Description Extracts the proxy memory ranking formulas into a pure `memory_rank_policy` module and keeps `MemoryCandidate` / `RecencyBoostRanker` as the public adapter-facing API. Also preserves backend memory IDs when ranked candidates are rebuilt, so downstream memory update/delete handles survive the ranking boundary. Closes # ## Type of Change - [ ] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Performance improvement - [x] Code refactoring (no functional changes) ## Changes Made - Added `headroom.proxy.memory_rank_policy` for timestamp parsing, recency factor calculation, and score boosting. - Updated `RecencyBoostRanker` to delegate policy math while preserving the existing public API. - Preserved `MemoryCandidate.id` when rank output candidates are rebuilt. - Added focused policy tests plus an ID-preservation regression test. - Included the current LiteLLM callback signature compatibility shim required for repo-wide mypy on main-based slices. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] Type checking passes (`mypy headroom`) - [x] New tests added for new functionality - [ ] Manual testing performed ### Test Output ```text python -m pytest tests/test_memory_rank_policy.py tests/test_memory_ranker.py tests/test_litellm_callback.py -q 32 passed in 6.22s python -m ruff check . All checks passed! python -m ruff format --check . 1095 files already formatted python -m mypy headroom --ignore-missing-imports Success: no issues found in 409 source files gitleaks protect --staged --no-banner --redact no leaks found ``` ## Real Behavior Proof - Environment: Windows, Python 3.13.13, local worktree based on `headroomlabs/main`. - Exact command / steps: targeted pytest, ruff, ruff format check, repo-wide mypy, staged gitleaks scan. - Observed result: memory rank policy/ranker/callback tests pass; static checks pass; no staged secrets detected. - Not tested: full provider/API integration; this slice only changes pure policy delegation and candidate shape preservation. ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Checklist - [x] My code follows the project's style guidelines - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] I have updated the CHANGELOG.md if applicable ## Screenshots (if applicable) N/A ## Additional Notes Documentation and changelog updates are not applicable for this internal architecture slice. PR-specific GHAS checks will be monitored after opening.
56 lines
1.9 KiB
Python
56 lines
1.9 KiB
Python
"""Tests for pure memory rank policy formulas."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import math
|
|
from datetime import datetime, timedelta, timezone
|
|
|
|
from headroom.proxy.memory_rank_policy import (
|
|
boost_memory_score,
|
|
memory_recency_factor,
|
|
parse_memory_created_at,
|
|
)
|
|
|
|
_UTC = timezone.utc
|
|
|
|
|
|
def test_parse_memory_created_at_accepts_zulu_iso_string() -> None:
|
|
parsed = parse_memory_created_at("2026-05-19T12:00:00Z")
|
|
assert parsed == datetime(2026, 5, 19, 12, 0, tzinfo=_UTC)
|
|
|
|
|
|
def test_parse_memory_created_at_normalizes_naive_datetime_to_utc() -> None:
|
|
parsed = parse_memory_created_at(datetime(2026, 5, 19, 12, 0))
|
|
assert parsed == datetime(2026, 5, 19, 12, 0, tzinfo=_UTC)
|
|
|
|
|
|
def test_parse_memory_created_at_invalid_values_are_neutral() -> None:
|
|
assert parse_memory_created_at("not-a-date") is None
|
|
assert parse_memory_created_at(123) is None
|
|
assert parse_memory_created_at(None) is None
|
|
|
|
|
|
def test_memory_recency_factor_uses_exponential_decay() -> None:
|
|
now = datetime(2026, 5, 31, tzinfo=_UTC)
|
|
created_at = now - timedelta(days=30)
|
|
factor = memory_recency_factor(now=now, created_at=created_at, decay_days=30.0)
|
|
assert math.isclose(factor, math.exp(-1), rel_tol=1e-12)
|
|
|
|
|
|
def test_memory_recency_factor_treats_missing_and_future_dates_as_neutral() -> None:
|
|
now = datetime(2026, 5, 31, tzinfo=_UTC)
|
|
future = now + timedelta(days=3)
|
|
assert memory_recency_factor(now=now, created_at=None, decay_days=30.0) == 1.0
|
|
assert memory_recency_factor(now=now, created_at=future, decay_days=30.0) == 1.0
|
|
|
|
|
|
def test_boost_memory_score_applies_recency_factor() -> None:
|
|
now = datetime(2026, 5, 31, tzinfo=_UTC)
|
|
created_at = now - timedelta(days=60)
|
|
boosted = boost_memory_score(
|
|
score=0.9,
|
|
now=now,
|
|
created_at=created_at,
|
|
decay_days=30.0,
|
|
)
|
|
assert math.isclose(boosted, 0.9 * math.exp(-2), rel_tol=1e-12)
|