mirror of
https://github.com/headroomlabs-ai/headroom.git
synced 2026-08-10 14:27:00 -04:00
d45748d143
## Description Extracts the privacy-preserving memory-query log hash from `helpers.py` into `headroom.proxy.query_log_policy`. The helper import path remains intact, while the log identifier formula is now directly testable as a pure policy. Closes # ## Type of Change - [ ] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Performance improvement - [x] Code refactoring (no functional changes) ## Changes Made - Added `query_log_policy.py` with the BLAKE2b-based short query hash formula. - Kept `helpers.hash_query_for_log` delegating to the extracted policy for existing callers. - Added direct tests for stability, short hex shape, content sensitivity, unpaired surrogate handling, and helper delegation. ## Testing - [x] Unit tests pass (`pytest`) - [x] Linting passes (`ruff check .`) - [x] Type checking passes (`mypy headroom`) - [x] New tests added for new functionality - [ ] Manual testing performed ### Test Output ```text python -m pytest tests\test_query_log_policy.py 4 passed in 0.18s python -m ruff check . All checks passed! python -m ruff format --check . 1069 files already formatted python -m mypy headroom --ignore-missing-imports Success: no issues found in 410 source files gitleaks protect --staged --no-banner --redact no leaks found ``` ## Real Behavior Proof - Environment: Windows, Python 3.13.13, branch `jd/architecture-slice-32`. - Exact command / steps: ran focused query-log policy tests, ruff, ruff format check, mypy, and staged gitleaks scan. - Observed result: query log hash behavior is directly covered and local lint/type/security checks pass. - Not tested: live memory injection logging; existing helper entry point remains intact. ## Review Readiness - [x] I have performed a self-review - [x] This PR is ready for human review ## Checklist - [x] My code follows the project's style guidelines - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] I have updated the CHANGELOG.md if applicable ## Screenshots (if applicable) N/A ## Additional Notes Documentation and changelog updates are N/A for this internal architecture-only refactor. The push reported existing default-branch Dependabot alerts; no staged secret leaks were found for this PR. --------- Co-authored-by: Tejas Chopra <chopratejas@gmail.com>
26 lines
1,005 B
Python
26 lines
1,005 B
Python
from __future__ import annotations
|
|
|
|
from headroom.proxy.helpers import hash_query_for_log as helper_hash_query_for_log
|
|
from headroom.proxy.query_log_policy import QUERY_LOG_HASH_BYTES, hash_query_for_log
|
|
|
|
|
|
def test_hash_query_for_log_is_stable_short_hex() -> None:
|
|
query_hash = hash_query_for_log("find user memory about project x")
|
|
|
|
assert query_hash == hash_query_for_log("find user memory about project x")
|
|
assert len(query_hash) == QUERY_LOG_HASH_BYTES * 2
|
|
assert all(char in "0123456789abcdef" for char in query_hash)
|
|
|
|
|
|
def test_hash_query_for_log_changes_with_query_content() -> None:
|
|
assert hash_query_for_log("alpha") != hash_query_for_log("beta")
|
|
|
|
|
|
def test_hash_query_for_log_handles_unpaired_surrogates() -> None:
|
|
query_hash = hash_query_for_log("bad-surrogate-\ud800")
|
|
|
|
assert len(query_hash) == QUERY_LOG_HASH_BYTES * 2
|
|
|
|
|
|
def test_helpers_hash_query_for_log_delegates_to_policy() -> None:
|
|
assert helper_hash_query_for_log("same") == hash_query_for_log("same")
|