mmo-ref/mudlet
1
0
Fork 0
mirror of https://github.com/Mudlet/Mudlet synced 2026-08-13 18:26:27 -04:00
Code Issues Projects Releases Packages Wiki Activity

fix: test stub dropping data sent before the client connection is accepted

Browse source 
Tests wait on the client-side connected signal, which can fire before the
stub server has accepted the connection; sendRaw then lost the payload,
failing TelnetStringSequenceRecoveryTest on the macOS arm64 runner twice.
Queue the bytes and flush them on accept instead.

Assisted-by: Claude:claude-fable-5
This commit is contained in:
Vadim Peretokin 2026-08-13 11:39:33 +02:00
parent 75f4a5a042
commit 54e75cd64e
2 changed files with 16 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

23
test/functional_tests/TelnetServerStub.cpp
View file

@ -31,7 +31,7 @@
using namespace std::chrono_literals;
TelnetServerStub::TelnetServerStub(QObject* parent)
: QTcpServer(parent)
: QTcpServer(parent)
{
connect(this, &QTcpServer::newConnection, this, &TelnetServerStub::onNewConnection);
}
@ -50,7 +50,11 @@ void TelnetServerStub::start(const QString& host, quint16 port)
void TelnetServerStub::sendRaw(const QByteArray& data)
{
if (!mpClient) {
qWarning() << "⚠️ sendRaw called without a connected client.";
// Tests wait on the client-side connected signal, which can fire
// before this server side has accepted the connection - dropping the
// bytes here loses the payload on fast runners, so hold them until
// onNewConnection():
mPendingData.append(data);
return;
}
mpClient->write(data);
@ -68,23 +72,26 @@ void TelnetServerStub::onNewConnection()
mpClient = client;
qInfo().noquote() << qsl("🔌 Client connected: %1").arg(client->peerAddress().toString());
if (!mPendingData.isEmpty()) {
client->write(mPendingData);
client->flush();
mPendingData.clear();
}
QPointer<QTcpSocket> safeClient = client;
QTimer::singleShot(100ms, [safeClient, welcomeMessage = mpWelcomeMessage]()
{
QTimer::singleShot(100ms, [safeClient, welcomeMessage = mpWelcomeMessage]() {
if (!safeClient) {
return;
}
const auto bytesWritten = safeClient->write(welcomeMessage.toUtf8() + "\r\n");
safeClient->flush();
if (bytesWritten <= 0) {
qWarning().noquote() << qsl("⚠️ Failed to send welcome message to %1")
.arg(safeClient->peerAddress().toString());
qWarning().noquote() << qsl("⚠️ Failed to send welcome message to %1").arg(safeClient->peerAddress().toString());
}
});
connect(client, &QTcpSocket::disconnected, [safeClient]()
{
connect(client, &QTcpSocket::disconnected, [safeClient]() {
if (!safeClient) {
return;
}

1
test/functional_tests/TelnetServerStub.h
View file

@ -32,6 +32,7 @@ class TelnetServerStub : public QTcpServer
QString mpWelcomeMessage = "";
QPointer<QTcpSocket> mpClient;
QByteArray mPendingData;
public:
explicit TelnetServerStub(QObject* parent = nullptr);