Stop AttackStart from wiping RANDOM_MOTION_TYPE, persist radius/default type from action 89, re-init default movement on JustReachedHome, and make RandomMovementGenerator use direct walks with reliable retry/step distance.
Reject self-targets when Auto Self Cast selects the caster, and keep combat
on same-map spell teleports so SPELL_GO smoke is not dropped by CANCEL_COMBAT.
Closes#926.
Party/raid spell and ability crits grant a combo point while in combat,
with a 2s ICD applied after the combo cast so CheckCast does not fail
with SPELL_FAILED_NOT_READY. Removes the incorrect apply-time cast handler.
Proc Nature damage and 10 Energy from poisoned Rupture/Garrote ticks, and refund
Energy from remaining Rupture duration when the target dies.
Closes#963
Bake SPELL_AURA_MOD_POWER_REGEN_PERCENT into the power regen flat modifier so
Blade Flurry's -20% (and Adrenaline Rush) actually reduce energy regeneration.
Require a valid enemy target, hop only that target unless Blade Flurry is up,
and drive teleports/attacks from the aura script instead of random area picks.
Closes#966
Convert the dummy finisher-efficiency effect to taken-damage mod for Eviscerate,
Rupture, and Crimson Tempest; add Kidney Shot duration and Sinister Strike extra
combo point scripts.
Closes#968
Crimson Tempest only dealt its initial AoE hit and never applied the bleed.
After each hit, apply DoT 122233 at 240% of that damage over 6 ticks, including
bleed damage modifiers.
Closes#953
Fan of Knives awarded combo points on every area target, so the last/random
hit became the combo target. Restrict the combo-point effect to the current
combo or selected enemy so CPs always land on your target.
Closes#955
Vanish only entered normal Stealth because trigger spell 18461 is missing from
Spell.dbc and SPELL_EFFECT_176 did nothing. Apply Vanish aura 11327 (or
Subterfuge Vanish 115193), run sanctuary, leave combat outside encounters, and
return to Stealth when the aura expires.
Closes#935
Subterfuge Stealth was stripped on cast/damage before scripts could run, so
the 3s Subterfuge buff never applied. Keep 115191/115193 through those
interrupts, proc or FoK/Crimson Tempest into 115192, and drop the stealth
forms when that buff expires.
Closes#922
Nightstalker only applied its stealth movement speed. Apply the damage aura
(130493) while stealthed and keep it briefly on break so Ambush/Garrote still
receive the 50% bonus.
Closes#919
Resolve email-shaped world auth session names through login identities after authserver proof succeeds. Update last_ip by account id so email logins do not miss the legacy username row.
Detach queued write failures before running close-capable callbacks so socket error handling cannot continue through freed write queue storage.
Add account_login_identity storage so email-shaped login names can use SRP verifier data generated for the same client-sent identity string. Wire auth challenge, reconnect, realm list lookup, account creation, password changes, username changes, email invalidation, and schema updates around the new identity table.
Signed-off-by: AlterEgo <admin@projectskyfire.org>
Bandit's Guile never built insight. Count Sinister Strike and Revealing Strike
hits to advance Shallow -> Moderate -> Deep insight with the matching damage
buff, and stop stacking while Deep Insight is active.
Closes#964
