Stop AttackStart from wiping RANDOM_MOTION_TYPE, persist radius/default type from action 89, re-init default movement on JustReachedHome, and make RandomMovementGenerator use direct walks with reliable retry/step distance.
Reject self-targets when Auto Self Cast selects the caster, and keep combat
on same-map spell teleports so SPELL_GO smoke is not dropped by CANCEL_COMBAT.
Closes#926.
Party/raid spell and ability crits grant a combo point while in combat,
with a 2s ICD applied after the combo cast so CheckCast does not fail
with SPELL_FAILED_NOT_READY. Removes the incorrect apply-time cast handler.
Proc Nature damage and 10 Energy from poisoned Rupture/Garrote ticks, and refund
Energy from remaining Rupture duration when the target dies.
Closes#963
Bake SPELL_AURA_MOD_POWER_REGEN_PERCENT into the power regen flat modifier so
Blade Flurry's -20% (and Adrenaline Rush) actually reduce energy regeneration.
Convert the dummy finisher-efficiency effect to taken-damage mod for Eviscerate,
Rupture, and Crimson Tempest; add Kidney Shot duration and Sinister Strike extra
combo point scripts.
Closes#968
Crimson Tempest only dealt its initial AoE hit and never applied the bleed.
After each hit, apply DoT 122233 at 240% of that damage over 6 ticks, including
bleed damage modifiers.
Closes#953
Fan of Knives awarded combo points on every area target, so the last/random
hit became the combo target. Restrict the combo-point effect to the current
combo or selected enemy so CPs always land on your target.
Closes#955
Vanish only entered normal Stealth because trigger spell 18461 is missing from
Spell.dbc and SPELL_EFFECT_176 did nothing. Apply Vanish aura 11327 (or
Subterfuge Vanish 115193), run sanctuary, leave combat outside encounters, and
return to Stealth when the aura expires.
Closes#935
Subterfuge Stealth was stripped on cast/damage before scripts could run, so
the 3s Subterfuge buff never applied. Keep 115191/115193 through those
interrupts, proc or FoK/Crimson Tempest into 115192, and drop the stealth
forms when that buff expires.
Closes#922
Nightstalker only applied its stealth movement speed. Apply the damage aura
(130493) while stealthed and keep it briefly on break so Ambush/Garrote still
receive the 50% bonus.
Closes#919
Resolve email-shaped world auth session names through login identities after authserver proof succeeds. Update last_ip by account id so email logins do not miss the legacy username row.
Detach queued write failures before running close-capable callbacks so socket error handling cannot continue through freed write queue storage.
Add account_login_identity storage so email-shaped login names can use SRP verifier data generated for the same client-sent identity string. Wire auth challenge, reconnect, realm list lookup, account creation, password changes, username changes, email invalidation, and schema updates around the new identity table.
Signed-off-by: AlterEgo <admin@projectskyfire.org>
Bandit's Guile never built insight. Count Sinister Strike and Revealing Strike
hits to advance Shallow -> Moderate -> Deep insight with the matching damage
buff, and stop stacking while Deep Insight is active.
Closes#964
Restless Blades never reduced cooldowns. Proc from damaging finishers and cut
Adrenaline Rush, Killing Spree, Redirect, Shadow Blades, and Sprint by the
dummy amount times spent combo points.
Closes#967
Ruthlessness triggered Combo Point Delayed (139569), but that dummy never granted
a combo point after the finisher cleared CPs. Schedule spell 139546 after the
finish phase, and allow Ruthlessness/Relentless Strikes ADD_TARGET_TRIGGER to
fire for only one hit target.
Closes#969
Combat Potency restored Energy on every successful off-hand hit (100% proc).
Roll the MoP off-hand speed formula (~20% at 1.4s, higher for slower weapons)
and allow Main Gauche / Shadow Blade off-hand hits to participate.
Closes#965
Use the login identity classifier to resolve email-shaped GRUNT challenge names through account email fields, keep SRP proof bound to the client-sent identity, and update auth session state by account id.
Signed-off-by: AlterEgo <admin@projectskyfire.org>
Add a shared login identity helper that distinguishes legacy usernames from email-shaped login strings and logs the detected kind during the auth challenge without changing authentication behavior.
Signed-off-by: AlterEgo <admin@projectskyfire.org>
Register the missing Death Knight spell scripts, bind their world database rows, and make Runic Empowerment select across the full depleted rune set without dividing by zero.
Closes#1253Closes#1254
Signed-off-by: AlterEgo <admin@projectskyfire.org>
Replace the obsolete disabled script path with a data-driven proc filter for spell 109306. The proc now uses the live talent aura, fires at 30 percent from focus-spending ranged hunter attacks and Kill Command, and lets the triggered 34720 aura handle the three discounted Arcane Shot or Multi-Shot casts.
Closes#1261
Signed-off-by: AlterEgo <admin@projectskyfire.org>
Re-enable the Paladin aura script with 5.4 damage reduction and lethal-hit rescue handling, add focused calculation coverage, and restore the spell script binding through pending SQL.
Closes#1264
Signed-off-by: AlterEgo <admin@projectskyfire.org>
Save active spell charge buckets in the characters database, restore offline recharge progress on login, and keep player dumps aware of the new charge table.
Signed-off-by: AlterEgo <admin@projectskyfire.org>
Latch effect movement arrival only after the movement generator observes a completed spline at the final destination, so Heroic Leap landing damage is not fired from movement cleanup or interrupted stop paths. Add branch CI filters for heroic_leap.
Signed-off-by: AlterEgo <admin@projectskyfire.org>
Add spell category charge tracking so Double Time grants two Charge charges with correct recharge, keep the client from re-applying DBC recovery cooldown on charged casts, and energize Rage from Charge's Dummy effect instead of the empty legacy 34846 spell.
