uefi-ref/edk2
1
0
Fork 0
mirror of https://github.com/tianocore/edk2 synced 2026-08-27 00:23:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

MdeModulePkg: Code/Comment cleanup

Browse source 
Cleaned various comments and debug messages as well as
headers to either fix typos or for readability.

Signed-off-by: Raymond Diaz <raymonddiaz@microsoft.com>
This commit is contained in:
rdiaz 2026-02-07 00:03:59 +00:00 • committed by mergify[bot]
parent 3457388b7c
commit 0e8dc1693d
6 changed files with 21 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

2
MdeModulePkg/Library/ArmFfaLib/ArmFfaCommon.h
View file

@ -34,7 +34,7 @@ FfaArgsToEfiStatus (
);
/**
Common ArmFfaLib Constructor.
Common ArmFfaLib init.
@param [out] PartId PartitionId
@param [out] IsFfaSupported FF-A supported flag

9
MdeModulePkg/Library/ArmFfaLib/ArmFfaDxeLib.c
View file

@ -84,12 +84,9 @@ ArmFfaDxeLibConstructor (
if (EFI_ERROR (Status)) {
if (!mIsFfaSupported) {
/*
* EFI_UNSUPPORTED return from ArmFfaLibCommonInit() means
* FF-A interface doesn't support.
* However, It doesn't make failure of loading driver/library instance
* (i.e) ArmPkg's MmCommunication Dxe/PEI Driver uses as well as SpmMm.
* So If FF-A is not supported the the MmCommunication Dxe/PEI falls
* back to SpmMm.
* FF-A being unsupported doesn't mean a failure of loading the driver/library
* instance (i.e) ArmPkg's MmCommunication Dxe/PEI Driver uses as well as SpmMm.
* So If FF-A is not supported the the MmCommunication Dxe/PEI falls back to SpmMm.
* For this case, return EFI_SUCCESS.
*/
return EFI_SUCCESS;

10
MdeModulePkg/Library/ArmFfaLib/ArmFfaPeiLib.c
View file

@ -125,14 +125,10 @@ ArmFfaPeiLibConstructor (
if (EFI_ERROR (Status)) {
if (!mIsFfaSupported) {
/*
* EFI_UNSUPPORTED return from ArmFfaLibCommonInit() means
* FF-A interface doesn't support.
* However, It doesn't make failure of loading driver/library instance
* (i.e) ArmPkg's MmCommunication Dxe/PEI Driver uses as well as SpmMm.
* So If FF-A is not supported the the MmCommunication Dxe/PEI falls
* back to SpmMm.
* FF-A being unsupported doesn't mean a failure of loading the driver/library
* instance (i.e) ArmPkg's MmCommunication Dxe/PEI Driver uses as well as SpmMm.
* So If FF-A is not supported the the MmCommunication Dxe/PEI falls back to SpmMm.
* For this case, return EFI_SUCCESS.
*/
return EFI_SUCCESS;
}

13
MdeModulePkg/Library/ArmFfaLib/ArmFfaSecLib.c
View file

@ -58,12 +58,9 @@ ArmFfaSecLibConstructor (
if (EFI_ERROR (Status)) {
if (!IsFfaSupported) {
/*
* EFI_UNSUPPORTED return from ArmFfaLibCommonInit() means
* FF-A interface doesn't support.
* However, It doesn't make failure of loading driver/library instance
* (i.e) ArmPkg's MmCommunication Dxe/PEI Driver uses as well as SpmMm.
* So If FF-A is not supported the the MmCommunication Dxe/PEI falls
* back to SpmMm.
* FF-A being unsupported doesn't mean a failure of loading the driver/library
* instance (i.e) ArmPkg's MmCommunication Dxe/PEI Driver uses as well as SpmMm.
* So If FF-A is not supported the the MmCommunication Dxe/PEI falls back to SpmMm.
* For this case, return EFI_SUCCESS.
*/
return EFI_SUCCESS;
@ -78,6 +75,8 @@ ArmFfaSecLibConstructor (
return Status;
}
DEBUG ((DEBUG_INFO, "%a Rx/Tx buffer isn't supported.\n", __func__));
/*
* When ARM_FID_FFA_PARTITION_INFO_GET_REGS is supported,
* Rx/Tx buffer might not be required to request service to
@ -91,7 +90,7 @@ ArmFfaSecLibConstructor (
&Property2
);
if (!EFI_ERROR (Status)) {
DEBUG ((DEBUG_INFO, "%a Rx/Tx buffer doesn't support.\n", __func__));
DEBUG ((DEBUG_INFO, "%a PARTITION_INFO_GET_REGS is available as an alternative to Rx/Tx buffer.\n", __func__));
}
return Status;

14
MdeModulePkg/Library/ArmFfaLib/ArmFfaSecRxTxMap.c
View file

@ -134,7 +134,7 @@ ArmFfaLibRxTxMap (
if (EFI_ERROR (Status)) {
DEBUG ((
DEBUG_ERROR,
"%a: Failed to get RX/TX buffer property... Status: %r\n",
"%a: Failed to get Rx/Tx buffer property... Status: %r\n",
__func__,
Status
));
@ -283,8 +283,8 @@ ErrorHandler:
Rx/Tx buffer is registered only once per partition.
@retval EFI_SUCCESS
@retval EFI_INVALID_PARAMETERS Already unregistered
@retval EFI_UNSUPPORTED Not supported
@retval EFI_INVALID_PARAMETER Already unregistered
@retval EFI_UNSUPPORTED Not supported
**/
EFI_STATUS
@ -336,9 +336,9 @@ ArmFfaLibRxTxUnmap (
}
/**
Update Rx/TX buffer information.
Update Rx/Tx buffer information.
@param BufferInfo Rx/Tx buffer information.
@param BufferInfo Rx/Tx buffer information.
**/
VOID
@ -364,7 +364,7 @@ UpdateRxTxBufferInfo (
}
/**
Find Rx/TX buffer memory allocation hob.
Find Rx/Tx buffer memory allocation hob.
@param UseGuid Find MemoryAllocationHob using Guid.
@ -389,7 +389,7 @@ FindRxTxBufferAllocationHob (
}
/**
Remap Rx/TX buffer with converted Rx/Tx Buffer address after
Remap Rx/Tx buffer with converted Rx/Tx Buffer address after
using permanent memory.
@param[out] BufferInfo BufferInfo

2
MdeModulePkg/Library/ArmFfaLib/ArmFfaStandaloneMmLib.c
View file

@ -49,7 +49,7 @@ ArmFfaStandaloneMmLibConstructor (
Status = ArmFfaLibCommonInit (&mPartId, &mIsFfaSupported);
if (!mIsFfaSupported) {
/*
* EFI_UNSUPPORTED means FF-A interface isn't available.
* Unsupported means FF-A interface isn't available.
* However, for Standalone MM modules, FF-A availability is not required.
* i.e. Standalone MM could use SpmMm as a legitimate protocol.
* Thus, returning EFI_SUCCESS here to avoid the entrypoint to assert.