Allan:
A gutting and modernization of the cmake configuration. This first pass is only expected to work on OSX, and will require additional work for Windows and Linux.
Fixes, formatting, and commentary.
Kill off doc_dir and data_dir; unused. These properties are legacy, and no longer used in current code.
Eliminate unused accessors
Chris:
Fix MACOSX_BUNDLE_ICON_FILE variable for Info.plist
Fix MACOSX_BUNDLE_SHORT_VERSION_STRING for Info.plist
Remove MACOSX_BUNDLE_LONG_VERSION_STRING which is no longer used
Clean up legacy Darwin files for building .dmg
Allan:
Add Qt Network library to find_library() call
Stub in (untested) windeployqt phase
Fix windeployqt pathing
Update Windows section; make OmniRig optional
Use std::numbers::pi instead of M_PI
Use std::numbers::pi in lieu of M_PI
Properly guard optional OmnRig include
Update CRC.h to address compiler pragma warnings
Additional OmniRig guarding
Simplify CMAKE_MODULE_PATH addition
Use list functionality, and append to the list, rather than prepend.
Chris:
Add Entitlements.plist for code signing with hardened runtime on MacOS
Add package directory for windeployqt to package the plugins in the proper directory structure for linking
add Qt Creator CMakeLists.txt.user and build folder to .gitignore
move minimum required Qt version to 6.5 - qt_add_resources() only supported in Qt6.5 or newer
Since the sample rate is a constant, the modulator can figure out the tone spacing by itself, based on the frames per symbol, we don’t need to parameterize it.
Eliminate fSpread parameter; it’s a thread safety issue and it’s never anything other than 0.0. Invert modulator active / idle accessor to simplify logic.
Brings modulator forward to incorporate changes in current WSJTX upstream. All these seem logical and benign, but will require signficant sanity testing. If there are odd modulation issues, I’ve probably introduced them here.
