mirror of
https://github.com/tianocore/edk2
synced 2026-08-27 00:23:19 -04:00
0e6d10de1c
Replace traditional `#ifndef`/`#define`/`#endif` include guards with
`#pragma` once.
`#pragma once` is a widely supported preprocessor directive that
prevents header files from being included multiple times. It is
supported by all toolchains used to build edk2: GCC, Clang/LLVM, and
MSVC.
Note: Some files in BaseTools are excluded from the change if they
are autogenerated or direcly related to a header from a subproject,
etc. In particular, headers in these directories were ignored:
- BaseTools/Source/C/LzmaCompress/Sdk/
- BaseTools/Source/C/VfrCompile/Pccts/
Compared to macro-based include guards, `#pragma once`:
- Eliminates the risk of macro name collisions or copy/paste errors
where two headers inadvertently use the same guard macro.
- Eliminate inconsistency in the way include guard macros are named
(e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.).
- Reduces boilerplate (three lines replaced by one).
- Avoids polluting the macro namespace with guard symbols.
- Can improve build times as the preprocessor can skip re-opening the
file entirely, rather than re-reading it to find the matching
`#endif` ("multiple-include optimization").
- Note that some compilers may already optimize traditional include
guards, by recognzining the idiomatic pattern.
This change is made acknowledging that overall portability of the
code will technically be reduced, as `#pragma once` is not part of the
C/C++ standards.
However, this is considered acceptable given:
1. edk2 already defines a subset of supported compilers in
BaseTools/Conf/tools_def.template, all of which have supported
`#pragma once` for over two decades.
2. There have been concerns raised to the project about inconsistent
include guard naming and potential macro collisions.
Approximate compiler support dates:
- MSVC: Supported since Visual C++ 4.2 (1996)
- GCC: Supported since 3.4 (2004)
(http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html)
- Clang (LLVM based): Since initial release in 2007
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
|
||
|---|---|---|
| .. | ||
| BasePeCoff.c | ||
| BinderFuncs.c | ||
| BinderFuncs.h | ||
| CommonLib.c | ||
| CommonLib.h | ||
| Compress.h | ||
| Crc32.c | ||
| Crc32.h | ||
| Decompress.c | ||
| Decompress.h | ||
| EfiCompress.c | ||
| EfiUtilityMsgs.c | ||
| EfiUtilityMsgs.h | ||
| FirmwareVolumeBuffer.c | ||
| FirmwareVolumeBufferLib.h | ||
| FvLib.c | ||
| FvLib.h | ||
| GNUmakefile | ||
| Makefile | ||
| MemoryFile.c | ||
| MemoryFile.h | ||
| MyAlloc.c | ||
| MyAlloc.h | ||
| OsPath.c | ||
| OsPath.h | ||
| ParseGuidedSectionTools.c | ||
| ParseGuidedSectionTools.h | ||
| ParseInf.c | ||
| ParseInf.h | ||
| PcdValueCommon.c | ||
| PcdValueCommon.h | ||
| PeCoffLib.h | ||
| PeCoffLoaderEx.c | ||
| SimpleFileParsing.c | ||
| SimpleFileParsing.h | ||
| StringFuncs.c | ||
| StringFuncs.h | ||
| TianoCompress.c | ||